You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/09 01:56:06 UTC
[GitHub] [shardingsphere] TeslaCN opened a new pull request, #20002: Revise #19975 Simplify RegistryCenter.getJDBCDatabaseName
TeslaCN opened a new pull request, #20002:
URL: https://github.com/apache/shardingsphere/pull/20002
Revise #19975.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20002: Revise #19975 Simplify codes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20002:
URL: https://github.com/apache/shardingsphere/pull/20002#issuecomment-1208852670
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20002?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20002](https://codecov.io/gh/apache/shardingsphere/pull/20002?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c946890) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e1126a7c7897b15485aaabf5ddb3ad9fd7372fd7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1126a7) will **increase** coverage by `0.10%`.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #20002 +/- ##
============================================
+ Coverage 60.26% 60.36% +0.10%
Complexity 2413 2413
============================================
Files 3862 3862
Lines 54764 54760 -4
Branches 7667 7667
============================================
+ Hits 33002 33058 +56
+ Misses 18928 18858 -70
- Partials 2834 2844 +10
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sharding/decider/ShardingSQLFederationDecider.java](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZGVjaWRlci9TaGFyZGluZ1NRTEZlZGVyYXRpb25EZWNpZGVyLmphdmE=) | `76.92% <ø> (+76.92%)` | :arrow_up: |
| [...r/decider/context/SQLFederationDeciderContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvZGVjaWRlci9jb250ZXh0L1NRTEZlZGVyYXRpb25EZWNpZGVyQ29udGV4dC5qYXZh) | `100.00% <ø> (ø)` | |
| [.../util/exception/ShardingSphereInsideException.java](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leGNlcHRpb24vU2hhcmRpbmdTcGhlcmVJbnNpZGVFeGNlcHRpb24uamF2YQ==) | `100.00% <ø> (ø)` | |
| [...de/manager/cluster/coordinator/RegistryCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9SZWdpc3RyeUNlbnRlci5qYXZh) | `95.45% <0.00%> (-0.20%)` | :arrow_down: |
| [.../backend/exception/BackendConnectionException.java](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGNlcHRpb24vQmFja2VuZENvbm5lY3Rpb25FeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...actReadwriteSplittingRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9jaGVja2VyL0Fic3RyYWN0UmVhZHdyaXRlU3BsaXR0aW5nUnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `58.92% <100.00%> (ø)` | |
| [...ingsphere/infra/util/props/TypedPropertyValue.java](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9wcm9wcy9UeXBlZFByb3BlcnR5VmFsdWUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...table/decider/SingleTableSQLFederationDecider.java](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNpbmdsZS10YWJsZS9zaGFyZGluZ3NwaGVyZS1zaW5nbGUtdGFibGUtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2luZ2xldGFibGUvZGVjaWRlci9TaW5nbGVUYWJsZVNRTEZlZGVyYXRpb25EZWNpZGVyLmphdmE=) | `72.97% <100.00%> (+72.97%)` | :arrow_up: |
| [...here/proxy/backend/exception/BackendException.java](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGNlcHRpb24vQmFja2VuZEV4Y2VwdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ing/route/engine/condition/ShardingConditions.java](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL2NvbmRpdGlvbi9TaGFyZGluZ0NvbmRpdGlvbnMuamF2YQ==) | `68.18% <0.00%> (+7.95%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/shardingsphere/pull/20002/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo merged pull request #20002: Revise #19975 Simplify codes
Posted by GitBox <gi...@apache.org>.
totalo merged PR #20002:
URL: https://github.com/apache/shardingsphere/pull/20002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org