You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Chris Custine <no...@github.com> on 2014/06/04 21:08:59 UTC
[jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
https://issues.apache.org/jira/browse/JCLOUDS-583
Updates HP Cloud compute provider to work with 13.5 release
You can merge this Pull Request by running:
git pull https://github.com/ccustine/jclouds fixes/JCLOUDS-583
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/393
-- Commit Summary --
* Updates HP Cloud compute provider to work with 13.5 release
-- File Changes --
M compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java (2)
M providers/hpcloud-compute/pom.xml (5)
M providers/hpcloud-compute/src/main/java/org/jclouds/hpcloud/compute/HPCloudComputeProviderMetadata.java (15)
M providers/hpcloud-compute/src/test/java/org/jclouds/hpcloud/compute/HPCloudComputeProviderMetadataExpectTest.java (8)
M providers/hpcloud-compute/src/test/java/org/jclouds/hpcloud/compute/compute/HPCloudComputeTemplateBuilderLiveTest.java (20)
M providers/hpcloud-compute/src/test/resources/access_hpcloud.json (523)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/393.patch
https://github.com/jclouds/jclouds/pull/393.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Ignasi Barrera <no...@github.com>.
I really look forward to having this in. Thanks @ccustine!
Changes LGTM. Do you have a live test output, to have an idea of the health of the provider?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45141991
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Andrew Phillips <no...@github.com>.
Looks good - thanks, @ccustine! Yes, please squash'n'rebase, then we're good to go from my perspective. +1
> jclouds-java-7-pull-requests #1337 SUCCESS
There's a bunch of [Checkstyle violations here](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1337/org.apache.jclouds.api$swift/violations/), but they're unrelated to this request. In fact, I need to go clean those up!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45564744
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Andrew Phillips <no...@github.com>.
> @demobox do you want to have a look before I merge it?
Minor comments only ;-)
> jclouds-java-7-pull-requests #1328 SUCCESS
One new [Checkstyle violation](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1328/org.apache.jclouds.provider$hpcloud-compute/violations/), too.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45294585
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Ignasi Barrera <no...@github.com>.
>I have been running live tests against both regions several times a week for several weeks.
I'm pretty sure about that :) The [last time I tried to run the tests](http://markmail.org/message/oferay5of54zcugg) one third of the tests failed or were skipped, just because of the api version thing. It is great to see that we'll be able to trust the provider again!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45145704
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1197](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1197/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45554577
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Chris Custine <no...@github.com>.
I have been running live tests against both regions several times a week for several weeks. There are periodic (I would guess 1 out of 10, or even less) failures on the tests that run scripts (installing jetty, java, etc) but those seem to be sensitive to traffic and timing anyway.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45144060
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Ignasi Barrera <no...@github.com>.
Squashed, rebased and [pushed](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=c857ccc4794c3538a995fddc5ea334c2e03e68c0). I've also amended the commit message to include the issue number so it appears in a comment in JIRA.
Thanks @ccustine!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45584166
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Chris Custine <no...@github.com>.
@nacx @demobox I have fixed the unused import and cleaned up the auth keys descriptions. Let me know if you want me to squash these commits, I just appended them for now to facilitate review.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45551633
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Ignasi Barrera <no...@github.com>.
Closed #393.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#event-129669215
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Ignasi Barrera <no...@github.com>.
I've run the live tests for the PR and the results are great. Thanks! @demobox do you want to have a look before I merge it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45224884
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #866](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/866/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45553460
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Andrew Phillips <no...@github.com>.
> @@ -80,6 +86,9 @@ protected Builder() {
> id("hpcloud-compute")
> .name("HP Cloud Compute Services")
> .apiMetadata(new NovaApiMetadata().toBuilder()
> + .identityName("${tenantName}:${accessKey}")
> + .credentialName("${secret}")
Is that "secret" or "secretKey"?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393/files#r13473490
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1328](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1328/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45140098
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1185](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1185/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45148882
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #857](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/857/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45140309
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by Andrew Phillips <no...@github.com>.
> <test.hpcloud-compute.build-version />
> <!--
> - Identity must be tenantName:userName. Note that the following
> - credentials are the HP Cloud username and password, not the access
> - key id and secret key.
> + Identity must be tenantName:accessKey. Credential is the secretKey
See similar comment in #394.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393/files#r13473484
Re: [jclouds] JCLOUDS-583 - Update HP Cloud compute provider (#393)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1337](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1337/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/393#issuecomment-45553689