You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/12/28 09:35:39 UTC
[PR] HDDS-10013. Clean up test dependencies [ozone]
adoroszlai opened a new pull request, #5879:
URL: https://github.com/apache/ozone/pull/5879
## What changes were proposed in this pull request?
1. d02d6b6476: Provide the same set of basic test dependencies for all modules via `hadoop-hdds/hadoop-dependency-test`.
2. cfae55296a: Group test dependencies in submodule POMs (after prod. dependencies), and order them alphabetically.
3. Move some dependency definitions to root POM's `dependencyManagement`:
* 9f824f3d67: move `org.bouncycastle` from `hadoop-hdds/pom.xml`
* 010981f754: move jooq and spring dependency definitions from Recon
4. Remove unused dependencies:
* ead0b9c4e7: remove unused JUnit4 dependency
* 9c2dd4cdec: remove JUnit4 dependency inherited by all hdds modules
* 4019c405a8: remove unused mockito1/powermock dependencies
* b467bfc03f: remove leftover migration support
* 6ed09c055d: remove leftover junit-vintage-engine
5. Misc. improvements:
* 99cd66efcb: add explicit test scope in sub-module POMs
* 55265083bd: remove test scope from `dependencyManagement` in root POM
* 346689b4fc: depend on `hamcrest-all` consistently (some modules used `hamcrest-core`, some `hamcrest-all`, some both)
* 76e4a612d6: fix indent (mostly in `hadoop-hdds/rocks-native/pom.xml`)
https://issues.apache.org/jira/browse/HDDS-10013
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7342330195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10013. Clean up test dependencies [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5879:
URL: https://github.com/apache/ozone/pull/5879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10013. Clean up test dependencies [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on code in PR #5879:
URL: https://github.com/apache/ozone/pull/5879#discussion_r1439013030
##########
hadoop-hdds/rocks-native/pom.xml:
##########
Review Comment:
Tagging @swamirishi just in case he'd catch something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10013. Clean up test dependencies [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5879:
URL: https://github.com/apache/ozone/pull/5879#discussion_r1439016255
##########
hadoop-hdds/rocks-native/pom.xml:
##########
Review Comment:
Thanks @smengcl for the review. With `--ignore-space-change` the diff is much smaller there:
```diff
diff --git hadoop-hdds/rocks-native/pom.xml hadoop-hdds/rocks-native/pom.xml
index c9480ccbb2..d3a015a18f 100644
--- hadoop-hdds/rocks-native/pom.xml
+++ hadoop-hdds/rocks-native/pom.xml
@@ -25,10 +25,6 @@
<artifactId>hdds-rocks-native</artifactId>
<dependencies>
- <dependency>
- <groupId>org.apache.ozone</groupId>
- <artifactId>hdds-test-utils</artifactId>
- </dependency>
<dependency>
<groupId>org.apache.ozone</groupId>
<artifactId>hdds-managed-rocksdb</artifactId>
@@ -37,19 +33,16 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-io</artifactId>
</dependency>
+
+ <!-- Test dependencies -->
<dependency>
- <groupId>org.junit.jupiter</groupId>
- <artifactId>junit-jupiter-api</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.junit.jupiter</groupId>
- <artifactId>junit-jupiter-params</artifactId>
+ <groupId>org.apache.ozone</groupId>
+ <artifactId>hdds-hadoop-dependency-test</artifactId>
<scope>test</scope>
</dependency>
<dependency>
- <groupId>org.mockito</groupId>
- <artifactId>mockito-junit-jupiter</artifactId>
+ <groupId>org.apache.ozone</groupId>
+ <artifactId>hdds-test-utils</artifactId>
<scope>test</scope>
</dependency>
<dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10013. Clean up test dependencies [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5879:
URL: https://github.com/apache/ozone/pull/5879#issuecomment-1874637672
Thanks @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org