You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2017/10/11 21:48:18 UTC

[Bug 61607] New: Add browse button in all beanshell element

https://bz.apache.org/bugzilla/show_bug.cgi?id=61607

            Bug ID: 61607
           Summary: Add browse button in all beanshell element
           Product: JMeter
           Version: 3.3
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: ra0077@gmail.com
  Target Milestone: ---

Hi,

I propose to add browser button to all beanshell elements

Antonio

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61607] Add browse button in all beanshell element

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61607

--- Comment #5 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
New Revision: 1815993

URL: http://svn.apache.org/viewvc?rev=1815993&view=rev
Log:
[Bug 61591] Update templates : recording-with-think-time and recording

Modified:
    jmeter/trunk/bin/templates/recording-with-think-time.jmx
    jmeter/trunk/bin/templates/recording.jmx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61607] Add browse button in all beanshell element

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61607

--- Comment #6 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
Bad comment

Sorry
Antonio

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61607] Add browse button in all beanshell element

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61607

Antonio Gomes Rodrigues <ra...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
New Revision: 1811895

URL: http://svn.apache.org/viewvc?rev=1811895&view=rev
Log:
Bug61607 Add browse button in all beanshell elements to select beanshell script

Modified:
   
jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/BeanShellAssertionGui.java
    jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java
   
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/control/gui/BeanShellSamplerGui.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61607] Add browse button in all beanshell element

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61607

Antonio Gomes Rodrigues <ra...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
New Revision: 1815627

URL: http://svn.apache.org/viewvc?rev=1815627&view=rev
Log:
Bug 61607 : Fix Beanshel GUI bug

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java

Modified:
jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java?rev=1815627&r1=1815626&r2=1815627&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java
(original)
+++ jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java
Fri Nov 17 21:04:45 2017
@@ -51,13 +51,14 @@ public abstract class BeanShellBeanInfoS
         p = property("filename");
         p.setValue(NOT_UNDEFINED, Boolean.TRUE);
         p.setValue(DEFAULT, "");
+        p.setPropertyEditorClass(FileEditor.class);

         createPropertyGroup("filenameGroup", new String[] { "filename" });

         p = property("script");
         p.setValue(NOT_UNDEFINED, Boolean.TRUE);
         p.setValue(DEFAULT, "");
-        p.setPropertyEditorClass(FileEditor.class);
+        p.setPropertyEditorClass(TextAreaEditor.class);

         createPropertyGroup("scripting", new String[] { "script" });
     }

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61607] Add browse button in all beanshell element

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61607

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hi Antonio,
Although browse is nice there are big drawbacks when you variabilize this
field.

You need to select Edit in combo,
you enter something then save
Try then to update it and save, your data is deleted.

So UX is weird.

As I usually only variabilize those usung __P  it ends up being less ux
friendly than before particularly for CSV Dataset

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61607] Add browse button in all beanshell element

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61607

--- Comment #3 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
Hi Philippe,

I don't understand your problem

In my Linux machine I don't need to select Edit in combo to variabilize this
field

If I modify the field already variabilized, I just need to change of field or
push enter before save it to avoid the change of the modification

Antonio

-- 
You are receiving this mail because:
You are the assignee for the bug.