[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6410: Add unit tests in Kinesis consumer

[GitBox <gi...@apache.org>]

KKcorps commented on a change in pull request #6410:
URL: https://github.com/apache/incubator-pinot/pull/6410#discussion_r567994460



##########
File path: pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisStreamMetadataProvider.java
##########
@@ -83,7 +91,7 @@ public long fetchPartitionOffset(@Nonnull OffsetCriteria offsetCriteria, long ti
     List<PartitionGroupInfo> newPartitionGroupInfos = new ArrayList<>();
 
     Map<String, Shard> shardIdToShardMap =
-        _kinesisConnectionHandler.getShards().stream().collect(Collectors.toMap(Shard::shardId, s -> s));
+        _kinesisConnectionHandler.getShards().stream().collect(Collectors.toMap(Shard::shardId, s -> s, (s1, s2) -> s1));

Review comment:
       I also wasn't able to figure this out but while running a collision was definitely happening and error was being thrown. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org