You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/08/26 23:08:13 UTC
Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Joseph Wu, and Till Toenshoff.
Bugs: MESOS-3235
https://issues.apache.org/jira/browse/MESOS-3235
Repository: mesos
Description
-------
Dumps all involved task/executor sandbox contents in test tear down
only if a failure occurred.
Diffs
-----
src/tests/fetcher_cache_tests.cpp b709b1eedeb880bc815e0742dc604d93828e593f
Diff: https://reviews.apache.org/r/37813/diff/
Testing
-------
Thanks,
Bernd Mathiske
Re: Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
Posted by Bernd Mathiske <be...@mesosphere.io>.
> On Aug. 26, 2015, 4:03 p.m., Joseph Wu wrote:
> > src/tests/fetcher_cache_tests.cpp, line 458
> > <https://reviews.apache.org/r/37813/diff/1/?file=1055256#file1055256line458>
> >
> > Is it common knowledge that the sandbox holds the logs? (If not, a short comment would suffice.)
It kinda is, but it will be reasonable to state this here in a comment.
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/#review96607
-----------------------------------------------------------
On Aug. 26, 2015, 2:08 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37813/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 2:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Dumps all involved task/executor sandbox contents in test tear down
> only if a failure occurred.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp b709b1eedeb880bc815e0742dc604d93828e593f
>
> Diff: https://reviews.apache.org/r/37813/diff/
>
>
> Testing
> -------
>
> make check on OSX, where the bug showed up.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Aug. 26, 2015, 4:03 p.m., Joseph Wu wrote:
> > Looks good.
Any updates on this? (Haven't come across this test failure recently, but it's still nice to have.)
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/#review96607
-----------------------------------------------------------
On Aug. 26, 2015, 2:08 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37813/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 2:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Dumps all involved task/executor sandbox contents in test tear down
> only if a failure occurred.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp b709b1eedeb880bc815e0742dc604d93828e593f
>
> Diff: https://reviews.apache.org/r/37813/diff/
>
>
> Testing
> -------
>
> make check on OSX, where the bug showed up.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/#review96607
-----------------------------------------------------------
Ship it!
Looks good.
src/tests/fetcher_cache_tests.cpp (line 235)
<https://reviews.apache.org/r/37813/#comment152197>
Possibly want a comment explaining that this is meant for directories with logs. If it's mistakenly pointed to, say, a directory with a binary, the output could get messy.
src/tests/fetcher_cache_tests.cpp (line 458)
<https://reviews.apache.org/r/37813/#comment152198>
Is it common knowledge that the sandbox holds the logs? (If not, a short comment would suffice.)
- Joseph Wu
On Aug. 26, 2015, 2:08 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37813/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 2:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Dumps all involved task/executor sandbox contents in test tear down
> only if a failure occurred.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp b709b1eedeb880bc815e0742dc604d93828e593f
>
> Diff: https://reviews.apache.org/r/37813/diff/
>
>
> Testing
> -------
>
> make check on OSX, where the bug showed up.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/#review96606
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37813]
All tests passed.
- Mesos ReviewBot
On Aug. 26, 2015, 9:08 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37813/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 9:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Dumps all involved task/executor sandbox contents in test tear down
> only if a failure occurred.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp b709b1eedeb880bc815e0742dc604d93828e593f
>
> Diff: https://reviews.apache.org/r/37813/diff/
>
>
> Testing
> -------
>
> make check on OSX, where the bug showed up.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/#review102435
-----------------------------------------------------------
Ship it!
src/tests/fetcher_cache_tests.cpp (line 567)
<https://reviews.apache.org/r/37813/#comment160088>
To prevent further confusion, wouldn't it make sense to call this `sandboxPath` here and everywhere else instead - like you did before?
- Till Toenshoff
On Oct. 12, 2015, 4:25 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37813/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 4:25 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Dumps all involved task/executor sandbox contents in test tear down
> only if a failure occurred.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 7e194dc6e2b2d8b857e61d1a18d696545a86ce9f
>
> Diff: https://reviews.apache.org/r/37813/diff/
>
>
> Testing
> -------
>
> make check on OSX, where the bug showed up.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/#review102480
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37813]
All tests passed.
- Mesos ReviewBot
On Oct. 13, 2015, 4:27 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37813/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 4:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Dumps all involved task/executor sandbox contents in test tear down
> only if a failure occurred.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 7e194dc6e2b2d8b857e61d1a18d696545a86ce9f
>
> Diff: https://reviews.apache.org/r/37813/diff/
>
>
> Testing
> -------
>
> make check on OSX, where the bug showed up.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 9:27 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Joseph Wu, and Till Toenshoff.
Changes
-------
Now using HasFatalFailure() thanks to a tip from @bmahler, which simplifies the code a lot. Also addressed Till's issue.
Bugs: MESOS-3235
https://issues.apache.org/jira/browse/MESOS-3235
Repository: mesos
Description
-------
Dumps all involved task/executor sandbox contents in test tear down
only if a failure occurred.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp 7e194dc6e2b2d8b857e61d1a18d696545a86ce9f
Diff: https://reviews.apache.org/r/37813/diff/
Testing
-------
make check on OSX, where the bug showed up.
Thanks,
Bernd Mathiske
Re: Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/#review102278
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37813]
All tests passed.
- Mesos ReviewBot
On Oct. 12, 2015, 4:25 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37813/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 4:25 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Dumps all involved task/executor sandbox contents in test tear down
> only if a failure occurred.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 7e194dc6e2b2d8b857e61d1a18d696545a86ce9f
>
> Diff: https://reviews.apache.org/r/37813/diff/
>
>
> Testing
> -------
>
> make check on OSX, where the bug showed up.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/
-----------------------------------------------------------
(Updated Oct. 12, 2015, 9:25 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Joseph Wu, and Till Toenshoff.
Changes
-------
Followed Joseph's suggestions.
Bugs: MESOS-3235
https://issues.apache.org/jira/browse/MESOS-3235
Repository: mesos
Description
-------
Dumps all involved task/executor sandbox contents in test tear down
only if a failure occurred.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp 7e194dc6e2b2d8b857e61d1a18d696545a86ce9f
Diff: https://reviews.apache.org/r/37813/diff/
Testing
-------
make check on OSX, where the bug showed up.
Thanks,
Bernd Mathiske
Re: Review Request 37813: Added additional diagnostic output when a
fetcher cache test fails.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 2:08 p.m.)
Review request for mesos, Benjamin Hindman, Joseph Wu, and Till Toenshoff.
Changes
-------
testing description added
Bugs: MESOS-3235
https://issues.apache.org/jira/browse/MESOS-3235
Repository: mesos
Description
-------
Dumps all involved task/executor sandbox contents in test tear down
only if a failure occurred.
Diffs
-----
src/tests/fetcher_cache_tests.cpp b709b1eedeb880bc815e0742dc604d93828e593f
Diff: https://reviews.apache.org/r/37813/diff/
Testing (updated)
-------
make check on OSX, where the bug showed up.
Thanks,
Bernd Mathiske