You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/22 13:12:06 UTC
[GitHub] [inlong] liangyepianzhou opened a new pull request, #5186: [Improve][Manager] Optimize Warning info when compiling the Manager module
liangyepianzhou opened a new pull request, #5186:
URL: https://github.com/apache/inlong/pull/5186
Master [issue](https://github.com/apache/inlong/issues/5178)
### Motivation
Optimize Warning info when compiling the Manager module
### Modifications
Optimize Warning info when compiling the Manager module
### Verifying this change
- [x] This change is a trivial rework/code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #5186: [INLONG-5178][Manager] Optimize Warning info for the Manager module
Posted by GitBox <gi...@apache.org>.
healchow merged PR #5186:
URL: https://github.com/apache/inlong/pull/5186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liangyepianzhou commented on pull request #5186: [Improve][Manager] Optimize Warning info when compiling the Manager module
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on PR #5186:
URL: https://github.com/apache/inlong/pull/5186#issuecomment-1192567473
@dockerzhang Could you please take a look when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liangyepianzhou commented on pull request #5186: [INLONG-5178][Manager] Optimize Warning info for the Manager module
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on PR #5186:
URL: https://github.com/apache/inlong/pull/5186#issuecomment-1193273042
The `Builder.Default` is not appended into InlongPulsarInfo.
Because its method genRequest needs to copy properties. if it adds `@Builder.Default`, the variables will get null.
> @Override
> public InlongPulsarRequest genRequest() {
> return CommonBeanUtils.copyProperties(this, InlongPulsarRequest::new);
> }
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #5186: [INLONG-5178][Manager] Optimize Warning info for the Manager module
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #5186:
URL: https://github.com/apache/inlong/pull/5186#issuecomment-1193057148
@liangyepianzhou there are failed UTs. Please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liangyepianzhou commented on pull request #5186: [INLONG-5178][Manager] Optimize Warning info for the Manager module
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on PR #5186:
URL: https://github.com/apache/inlong/pull/5186#issuecomment-1194139163
> ```
> [INFO] Compiling 332 source files to /home/runner/work/inlong/inlong/inlong-manager/manager-common/target/classes
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[55,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[58,17] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[61,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[64,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[67,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[70,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[73,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[76,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[79,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[82,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[85,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
> ```
@dockerzhang
I have commented that the [inlongPulsarinfo](https://github.com/apache/inlong/pull/5186#issuecomment-1193273042) will not add @Builder.Default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #5186: [INLONG-5178][Manager] Optimize Warning info for the Manager module
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #5186:
URL: https://github.com/apache/inlong/pull/5186#issuecomment-1193786609
@liangyepianzhou there still are lots of warnings for `Builder.Default`. Please check the [workflow](https://github.com/apache/inlong/runs/7486656498?check_suite_focus=true) again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #5186: [INLONG-5178][Manager] Optimize Warning info for the Manager module
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #5186:
URL: https://github.com/apache/inlong/pull/5186#issuecomment-1194134381
```
[INFO] Compiling 332 source files to /home/runner/work/inlong/inlong/inlong-manager/manager-common/target/classes
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[55,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[58,17] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[61,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[64,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[67,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[70,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[73,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[76,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[79,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[82,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning: /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[85,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org