You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/27 16:31:00 UTC

[jira] [Commented] (OPENNLP-1393) Update DoccatDL tests for OPENNLP-1374

    [ https://issues.apache.org/jira/browse/OPENNLP-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625198#comment-17625198 ] 

ASF GitHub Bot commented on OPENNLP-1393:
-----------------------------------------

jzonthemtn opened a new pull request, #430:
URL: https://github.com/apache/opennlp/pull/430

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   




> Update DoccatDL tests for OPENNLP-1374
> --------------------------------------
>
>                 Key: OPENNLP-1393
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1393
>             Project: OpenNLP
>          Issue Type: Task
>          Components: Build, Packaging and Test, Deep Learning
>            Reporter: Jeff Zemerick
>            Assignee: Jeff Zemerick
>            Priority: Major
>
> In OPENNLP-1374, the doccat DL code was changed to split text when doing the inference to avoid the limitation of only working on short text.
> This change caused the expected Eval test results to also change and they were not updated at that time.
> Need to update the expected Eval test results.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)