You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/06 07:45:50 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #9730: DbApiHook: Support kwargs in get_pandas_df

turbaszek commented on a change in pull request #9730:
URL: https://github.com/apache/airflow/pull/9730#discussion_r466209472



##########
File path: airflow/hooks/dbapi_hook.py
##########
@@ -106,7 +106,7 @@ def get_sqlalchemy_engine(self, engine_kwargs=None):
             engine_kwargs = {}
         return create_engine(self.get_uri(), **engine_kwargs)
 
-    def get_pandas_df(self, sql, parameters=None):
+    def get_pandas_df(self, sql, parameters=None, **kwargs):

Review comment:
       Would you mind adding information to method docstring? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org