You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@yetus.apache.org by aw...@apache.org on 2022/05/04 17:15:35 UTC
[yetus] tag prehistory created (now fd0ce8db)
This is an automated email from the ASF dual-hosted git repository.
aw pushed a change to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
at fd0ce8db (commit)
This tag includes the following new commits:
new 299fb881 Create hadoop sub-project.
new 64f5a263 HADOOP-2939. Make the automated patch testing process an executable Ant target, test-patch. Contributed by Ramya and Nigel.
new 260a7262 HADOOP-2939. Make the automated patch testing process an executable Ant target, test-patch. Contributed by Ramya and Nigel.
new f7a70328 HADOOP-3142. Increases the number of open files during testing on Hudson.
new be9de904 HADOOP-3345. Enhance the hudson-test-patch target to cleanup messages, fix minor defects, and add eclipse plugin and python unit tests. Contributed by Nigel Daley.
new 76c330d4 HADOOP-3345. Enhance the hudson-test-patch target to cleanup messages, fix minor defects, and add eclipse plugin and python unit tests. Contributed by Nigel Daley.
new c8d3e108 HADOOP-3435. Remove the assuption in the scripts that bash is at /bin/bash and fix the test patch to require bash instead of sh. Contributed by Brice Arnould.
new 2e981605 HADOOP-3480. Need to update Eclipse template to reflect current trunk. Contributed by Brice Arnould.
new 7c5ccefd HADOOP-2325. Require Java 6.
new 1e8440cf HADOOP-3653. Fix test-patch target to properly account for Eclipse classpath jars. Contributed by Brice Arnould.
new a0edec78 Patch process shouldn't -1 documentation patch for not having any tests.
new a8e1b95f fix patch process to log a more coherent message when the eclipse jars are not right
new 79e321fe HDOOP-3966. Copy findbugs generated output files to PATCH_DIR while running test-patch. (contributed by Ramya R)
new d133273a HADOOP-4074. Commenting out release audit in patch testing process until it can be fixed.
new 2978856b HADOOP-4075. test-patch.sh now spits out ant commands that it runs. Contributed by Ramya R
new 541033a1 HADOOP-4200. Fix a bug in the test-patch.sh script. Contributed by Ramya R
new 34ff4786 HADOOP-3975. Change test-patch script to report working the dir modifications preventing the suite from being run. Contributed by Ramya R.
new bc86ebbe HADOOP-4244. Change test-patch.sh to check Eclipse classpath no matter it is run by Hudson or not. (szetszwo)
new b90fca3a HADOOP-4878. Fix eclipse plugin classpath file to point to ivy's resolved lib directory and added the same to test-patch.sh. Contributed by Giridharan Kesavan.
new faa37a5c HADOOP-4948. Add parameters java5.home and forrest.home to the ant commands in test-patch.sh. (Giridharan Kesavan via szetszwo)
new d17c67ea HADOOP-5088. Include releaseaudit target as part of developer test-patch target. Contributed by Giridharan Kesavan.
new c695d77b HADOOP-5279. Remove unnecessary targets from test-patch.sh. Contributed by Giridharan Kesavan.
new 1d402fb7 HADOOP-5232. Enable patch testing to occur on more than one host. Contributed by Giri Kesavan.
new fd0ce8db Hadoop-5800 - to fix incorrect cleanup of svn workspace
The 24 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[yetus] 18/24: HADOOP-4244. Change test-patch.sh to check Eclipse classpath no matter it is run by Hudson or not. (szetszwo)
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit bc86ebbecd5b98af7401682336debdc0019056db
Author: Tsz-wo Sze <sz...@apache.org>
AuthorDate: Wed Sep 24 20:38:08 2008 +0000
HADOOP-4244. Change test-patch.sh to check Eclipse classpath no matter it is run by Hudson or not. (szetszwo)
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@698721 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 31 ++++++++++++++++++++++++++++---
1 file changed, 28 insertions(+), 3 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 4da15267..32c4df7e 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -491,7 +491,7 @@ runCoreTests () {
###############################################################################
### Tests parts of contrib specific to the eclipse files
-runContribTestOnEclipseFiles () {
+checkJarFilesDeclaredInEclipse () {
export DECLARED_JARS=$(sed -n 's@.*kind="lib".*path="\(.*jar\)".*@\1@p' < .eclipse.templates/.classpath)
export PRESENT_JARS=$(find lib/ src/test/lib/ -name '*.jar' |sort)
# When run by Hudson, consider libs from ${SUPPORT_DIR} declared
@@ -515,6 +515,29 @@ FAILED: $dir is referenced in the Eclipse project although it doesn't exists any
return 0
}
+checkEclipse () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Running Eclipse classpath verification."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+
+ checkJarFilesDeclaredInEclipse
+ if [[ $? != 0 ]] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories."
+ return 1
+ fi
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ +1 Eclipse classpath. The patch retains Eclipse classpath integrity."
+ return 0
+}
###############################################################################
### Run the test-contrib target
runContribTests () {
@@ -531,8 +554,8 @@ runContribTests () {
### Kill any rogue build processes from the last attempt
$PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
- echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib && runContribTestOnEclipseFiles"
- $ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib && runContribTestOnEclipseFiles
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
@@ -650,6 +673,8 @@ checkStyle
(( RESULT = RESULT + $? ))
checkFindbugsWarnings
(( RESULT = RESULT + $? ))
+checkEclipse
+(( RESULT = RESULT + $? ))
### Do not call these when run by a developer
if [[ $HUDSON == "true" ]] ; then
### DISABLE RELEASE AUDIT UNTIL HADOOP-4074 IS FIXED
[yetus] 16/24: HADOOP-4200. Fix a bug in the test-patch.sh script. Contributed by Ramya R
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 541033a16c77dd33d759fec0264d35c9d856976e
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Thu Sep 18 16:58:12 2008 +0000
HADOOP-4200. Fix a bug in the test-patch.sh script. Contributed by Ramya R
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@696707 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 40 ++++++++++++++++++++--------------------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 2b3adfd4..abdc493f 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -159,17 +159,17 @@ setup () {
### DISABLE RELEASE AUDIT UNTIL HADOOP-4074 IS FIXED
### Do not call releaseaudit when run by a developer
### if [[ $HUDSON == "true" ]] ; then
- ### CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/trunkReleaseAuditWarnings.txt"
- ### echo $CMD ; $CMD
+ ### echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/trunkReleaseAuditWarnings.txt 2>&1"
+ ### $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/trunkReleaseAuditWarnings.txt 2>&1
### fi
- CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= clean tar &> $PATCH_DIR/trunkJavacWarnings.txt"
- echo $CMD ; $CMD
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1
if [[ $? != 0 ]] ; then
echo "Trunk compilation is broken?"
cleanupAndExit 1
fi
- CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs &> /dev/null"
- echo $CMD ; $CMD
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs > /dev/null 2>&1"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs > /dev/null 2>&1
if [[ $? != 0 ]] ; then
echo "Trunk findbugs is broken?"
cleanupAndExit 1
@@ -275,8 +275,8 @@ checkJavadocWarnings () {
echo "======================================================================"
echo ""
echo ""
- CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= clean javadoc | tee $PATCH_DIR/patchJavadocWarnings.txt"
- echo $CMD ; $CMD
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= clean javadoc | tee $PATCH_DIR/patchJavadocWarnings.txt"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= clean javadoc | tee $PATCH_DIR/patchJavadocWarnings.txt
javadocWarnings=`$GREP -c '\[javadoc\] [0-9]* warning' $PATCH_DIR/patchJavadocWarnings.txt`
echo ""
echo ""
@@ -305,8 +305,8 @@ checkJavacWarnings () {
echo "======================================================================"
echo ""
echo ""
- CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= tar &> $PATCH_DIR/patchJavacWarnings.txt"
- echo $CMD ; $CMD
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= tar > $PATCH_DIR/patchJavacWarnings.txt 2>&1"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= tar > $PATCH_DIR/patchJavacWarnings.txt 2>&1
### Compare trunk and patch javac warning numbers
if [[ -f $PATCH_DIR/patchJavacWarnings.txt ]] ; then
@@ -340,8 +340,8 @@ checkReleaseAuditWarnings () {
echo "======================================================================"
echo ""
echo ""
- CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/patchReleaseAuditWarnings.txt"
- echo $CMD ; $CMD
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/patchReleaseAuditWarnings.txt 2>&1"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/patchReleaseAuditWarnings.txt 2>&1
### Compare trunk and patch release audit warning numbers
if [[ -f $PATCH_DIR/patchReleaseAuditWarnings.txt ]] ; then
@@ -388,8 +388,8 @@ checkStyle () {
echo "THIS IS NOT IMPLEMENTED YET"
echo ""
echo ""
- CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= checkstyle"
- echo $CMD ; $CMD
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= checkstyle"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= checkstyle
JIRA_COMMENT_FOOTER="Checkstyle results: http://hudson.zones.apache.org/hudson/job/$JOB_NAME/$BUILD_NUMBER/artifact/trunk/build/test/checkstyle-errors.html
$JIRA_COMMENT_FOOTER"
### TODO: calculate actual patchStyleErrors
@@ -418,8 +418,8 @@ checkFindbugsWarnings () {
echo "======================================================================"
echo ""
echo ""
- CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs"
- echo $CMD ; $CMD
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs
if [ $? != 0 ] ; then
JIRA_COMMENT="$JIRA_COMMENT
@@ -473,8 +473,8 @@ runCoreTests () {
### Kill any rogue build processes from the last attempt
$PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
- CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME create-c++-configure docs tar test-core"
- echo $CMD ; $CMD
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME create-c++-configure docs tar test-core"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME create-c++-configure docs tar test-core
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
@@ -529,8 +529,8 @@ runContribTests () {
### Kill any rogue build processes from the last attempt
$PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
- CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib && runContribTestOnEclipseFiles"
- echo $CMD ; $CMD
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib && runContribTestOnEclipseFiles"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib && runContribTestOnEclipseFiles
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
[yetus] 02/24: HADOOP-2939. Make the automated patch testing process an executable Ant target, test-patch. Contributed by Ramya and Nigel.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 64f5a2635d480be9ba8d161587ad5d9c23dbf57b
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Tue Mar 18 06:16:41 2008 +0000
HADOOP-2939. Make the automated patch testing process an executable Ant target, test-patch. Contributed by Ramya and Nigel.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@638230 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 603 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 603 insertions(+)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
new file mode 100755
index 00000000..97325f1b
--- /dev/null
+++ b/src/test/bin/test-patch.sh
@@ -0,0 +1,603 @@
+#!/bin/bash
+
+#set -x
+
+### Setup some variables.
+### JOB_NAME, SVN_REVISION, and BUILD_NUMBER are set by Hudson if it is run by patch process
+
+###############################################################################
+parseArgs() {
+ case "$1" in
+ HUDSON)
+ ### Set HUDSON to true to indicate that this script is being run by Hudson
+ HUDSON=true
+ if [[ $# != 14 ]] ; then
+ echo "ERROR: usage $0 HUDSON <PATCH_DIR> <SUPPORT_DIR> <PS_CMD> <WGET_CMD> <JIRACLI> <SVN_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <WORKSPACE_BASEDIR> <TRIGGER_BUILD> <JIRA_PASSWD>"
+ cleanupAndExit 0
+ fi
+ PATCH_DIR=$2
+ SUPPORT_DIR=$3
+ PS=$4
+ WGET=$5
+ JIRACLI=$6
+ SVN=$7
+ GREP=$8
+ PATCH=$9
+ FINDBUGS_HOME=${10}
+ FORREST_HOME=${11}
+ BASEDIR=${12}
+ TRIGGER_BUILD_URL=${13}
+ JIRA_PASSWD=${14}
+ ### Retrieve the defect number
+ if [ ! -e $PATCH_DIR/defectNum ] ; then
+ echo "Could not determine the patch to test. Exiting."
+ cleanupAndExit 0
+ fi
+ defect=`cat $PATCH_DIR/defectNum`
+ if [ -z "$defect" ] ; then
+ echo "Could not determine the patch to test. Exiting."
+ cleanupAndExit 0
+ fi
+ ;;
+ DEVELOPER)
+ ### Set HUDSON to false to indicate that this script is being run by a developer
+ HUDSON=false
+ if [[ $# != 9 ]] ; then
+ echo "ERROR: usage $0 DEVELOPER <PATCH_FILE> <SCRATCH_DIR> <SVN_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <WORKSPACE_BASEDIR>"
+ cleanupAndExit 0
+ fi
+ ### PATCH_FILE contains the location of the patchfile
+ PATCH_FILE=$2
+ if [[ ! -e "$PATCH_FILE" ]] ; then
+ echo "Unable to locate the patch file $PATCH_FILE"
+ cleanupAndExit 0
+ fi
+ PATCH_DIR=$3
+ ### Check if $PATCH_DIR exists. If it does not exist, create a new directory
+ if [[ ! -e "$PATCH_DIR" ]] ; then
+ mkdir "$PATCH_DIR"
+ if [[ $? == 0 ]] ; then
+ echo "$PATCH_DIR has been created"
+ else
+ echo "Unable to create $PATCH_DIR"
+ cleanupAndExit 0
+ fi
+ fi
+ SVN=$4
+ GREP=$5
+ PATCH=$6
+ FINDBUGS_HOME=$7
+ FORREST_HOME=$8
+ BASEDIR=$9
+ ### Obtain the patch filename to append it to the version number
+ defect=`basename $PATCH_FILE`
+ ;;
+ *)
+ echo "ERROR: usage $0 HUDSON [args] | DEVELOPER [args]"
+ cleanupAndExit 0
+ ;;
+ esac
+}
+
+###############################################################################
+checkout () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Testing patch for ${defect}."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ ### When run by a developer, if the workspace contains modifications, do not continue
+ if [[ $HUDSON == "false" ]] ; then
+ if [[ `$SVN stat` != "" ]] ; then
+ echo "ERROR: can't run in a workspace that contains modifications"
+ # PENDING: Uncomment the following line
+ # cleanupAndExit 0
+ fi
+ else
+ cd $BASEDIR
+ $SVN revert -R .
+ rm -rf `$SVN status`
+ $SVN update
+ fi
+ return $?
+}
+
+###############################################################################
+setup () {
+ ### Download latest patch file (ignoring .htm and .html) when run from patch process
+ if [[ $HUDSON == "true" ]] ; then
+ $WGET -q -O $PATCH_DIR/jira http://issues.apache.org/jira/browse/$defect
+ if [[ `$GREP -c 'Patch Available' $PATCH_DIR/jira` == 0 ]] ; then
+ echo "$defect is not \"Patch Available\". Exiting."
+ cleanupAndExit 0
+ fi
+ relativePatchURL=`$GREP -o '"/jira/secure/attachment/[0-9]*/[^"]*' $PATCH_DIR/jira | $GREP -v -e 'htm[l]*$' | sort | tail -1 | $GREP -o '/jira/secure/attachment/[0-9]*/[^"]*'`
+ patchURL="http://issues.apache.org${relativePatchURL}"
+ patchNum=`echo $patchURL | $GREP -o '[0-9]*/' | $GREP -o '[0-9]*'`
+ echo "$defect patch is being downloaded at `date` from"
+ echo "$patchURL"
+ $WGET -q -O $PATCH_DIR/patch $patchURL
+ VERSION=${SVN_REVISION}_${defect}_PATCH-${patchNum}
+ JIRA_COMMENT="Here are the results of testing the latest attachment
+ $patchURL
+ against trunk revision ${SVN_REVISION}."
+
+ ### Copy in any supporting files needed by this process
+ cp -r $SUPPORT_DIR/lib/* ./lib
+ #PENDING: cp -f $SUPPORT_DIR/etc/checkstyle* ./src/test
+ ### Copy the patch file to $PATCH_DIR
+ else
+ VERSION=PATCH-${defect}
+ cp $PATCH_FILE $PATCH_DIR/patch
+ if [[ $? == 0 ]] ; then
+ echo "Patch file $PATCH_FILE copied to $PATCH_DIR"
+ else
+ echo "Could not copy $PATCH_FILE to $PATCH_DIR"
+ cleanupAndExit 0
+ fi
+ fi
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Pre-building trunk to determine trunk number"
+ echo " of release audit, javac, and Findbugs warnings."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ ### Do not call releaseaudit when run by a developer
+ if [[ $HUDSON == "true" ]] ; then
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/trunkReleaseAuditWarnings.txt
+ fi
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" -DHadoopPatchProcess= clean tar &> $PATCH_DIR/trunkJavacWarnings.txt
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs &> /dev/null
+ cp $BASEDIR/build/test/findbugs/*.xml $PATCH_DIR/trunkFindbugsWarnings.xml
+}
+
+###############################################################################
+### Check for @author tags in the patch
+checkAuthor () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Checking there are no @author tags in the patch."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ authorTags=`$GREP -c -i '@author' $PATCH_DIR/patch`
+ echo "There appear to be $authorTags @author tags in the patch."
+ if [[ $authorTags != 0 ]] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ @author -1. The patch appears to contain $authorTags @author tags which the Hadoop community has agreed to not allow in code contributions."
+ return 1
+ fi
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ @author +1. The patch does not contain any @author tags."
+ return 0
+}
+
+###############################################################################
+### Check for tests in the patch
+checkTests () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Checking there are new or changed tests in the patch."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ testReferences=`$GREP -c -i '/test' $PATCH_DIR/patch`
+ echo "There appear to be $testReferences test files referenced in the patch."
+ if [[ $testReferences == 0 ]] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ tests included -1. The patch doesn't appear to include any new or modified tests.
+ Please justify why no tests are needed for this patch."
+ return 1
+ fi
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ tests included +1. The patch appears to include $testReferences new or modified tests."
+ return 0
+}
+
+###############################################################################
+### Attempt to apply the patch
+applyPatch () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Applying patch."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ $PATCH -E -p0 < $PATCH_DIR/patch
+ if [[ $? != 0 ]] ; then
+ echo "PATCH APPLICATION FAILED"
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ patch -1. The patch command could not apply the patch."
+ return 1
+ fi
+ return 0
+}
+
+###############################################################################
+### Check there are no javadoc warnings
+checkJavadocWarnings () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Determining number of patched javadoc warnings."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= clean javadoc | tee $PATCH_DIR/patchJavadocWarnings.txt
+ javadocWarnings=`$GREP -c '\[javadoc\] [0-9]* warning' $PATCH_DIR/patchJavadocWarnings.txt`
+ echo ""
+ echo ""
+ echo "There appear to be $javadocWarnings javadoc warnings generated by the patched build."
+ if [[ $javadocWarnings != 0 ]] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ javadoc -1. The javadoc tool appears to have generated $javadocWarnings warning messages."
+ return 1
+ fi
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ javadoc +1. The javadoc tool did not generate any warning messages."
+return 0
+}
+
+###############################################################################
+### Check there are no changes in the number of Javac warnings
+checkJavacWarnings () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Determining number of patched javac warnings."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" -DHadoopPatchProcess= tar &> $PATCH_DIR/patchJavacWarnings.txt
+
+ ### Compare trunk and patch javac warning numbers
+ if [[ -f $PATCH_DIR/patchJavacWarnings.txt ]] ; then
+ trunkJavacWarnings=`$GREP -o '\[javac\] [0-9]* warning' $PATCH_DIR/trunkJavacWarnings.txt | awk '{total += $2} END {print total}'`
+ patchJavacWarnings=`$GREP -o '\[javac\] [0-9]* warning' $PATCH_DIR/patchJavacWarnings.txt | awk '{total += $2} END {print total}'`
+ echo "There appear to be $trunkJavacWarnings javac compiler warnings before the patch and $patchJavacWarnings javac compiler warnings after applying the patch."
+ if [[ $patchJavacWarnings != "" && $trunkJavacWarnings != "" ]] ; then
+ if [[ $patchJavacWarnings > $trunkJavacWarnings ]] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ javac -1. The applied patch generated $patchJavacWarnings javac compiler warnings (more than the trunk's current $trunkJavacWarnings warnings)."
+ return 1
+ fi
+ fi
+ fi
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ javac +1. The applied patch does not generate any new javac compiler warnings."
+ return 0
+}
+
+###############################################################################
+### Check there are no changes in the number of release audit (RAT) warnings
+checkReleaseAuditWarnings () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Determining number of patched release audit warnings."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/patchReleaseAuditWarnings.txt
+
+ ### Compare trunk and patch release audit warning numbers
+ if [[ -f $PATCH_DIR/patchReleaseAuditWarnings.txt ]] ; then
+ trunkReleaseAuditWarnings=`$GREP -c '\!?????' $PATCH_DIR/trunkReleaseAuditWarnings.txt`
+ patchReleaseAuditWarnings=`$GREP -c '\!?????' $PATCH_DIR/patchReleaseAuditWarnings.txt`
+ echo ""
+ echo ""
+ echo "There appear to be $trunkReleaseAuditWarnings release audit warnings before the patch and $patchReleaseAuditWarnings release audit warnings after applying the patch."
+ if [[ $patchReleaseAuditWarnings != "" && $trunkReleaseAuditWarnings != "" ]] ; then
+ if [[ $patchReleaseAuditWarnings > $trunkReleaseAuditWarnings ]] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ release audit -1. The applied patch generated $patchReleaseAuditWarnings release audit warnings (more than the trunk's current $trunkReleaseAuditWarnings warnings)."
+ $GREP '\!?????' $PATCH_DIR/patchReleaseAuditWarnings.txt > $PATCH_DIR/patchReleaseAuditProblems.txt
+ $GREP '\!?????' $PATCH_DIR/trunkReleaseAuditWarnings.txt > $PATCH_DIR/trunkReleaseAuditProblems.txt
+ echo "A diff of patched release audit warnings with trunk release audit warnings." > $PATCH_DIR/releaseAuditDiffWarnings.txt
+ echo "Lines that start with ????? in the release audit report indicate files that do not have an Apache license header." > $PATCH_DIR/releaseAuditDiffWarnings.txt
+ echo "" > $PATCH_DIR/releaseAuditDiffWarnings.txt
+ diff $PATCH_DIR/patchReleaseAuditProblems.txt $PATCH_DIR/trunkReleaseAuditProblems.txt >> $PATCH_DIR/releaseAuditDiffWarnings.txt
+ JIRA_COMMENT_FOOTER="Release audit warnings: http://hudson.zones.apache.org/hudson/job/$JOB_NAME/$BUILD_NUMBER/artifact/trunk/current/releaseAuditDiffWarnings.txt
+$JIRA_COMMENT_FOOTER"
+ return 1
+ fi
+ fi
+ fi
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ release audit +1. The applied patch does not generate any new release audit warnings."
+ return 0
+}
+
+###############################################################################
+### Check there are no changes in the number of Checkstyle warnings
+checkStyle () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Determining number of patched checkstyle warnings."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ echo "THIS IS NOT IMPLEMENTED YET"
+ echo ""
+ echo ""
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= checkstyle
+ JIRA_COMMENT_FOOTER="Checkstyle results: http://hudson.zones.apache.org/hudson/job/$JOB_NAME/$BUILD_NUMBER/artifact/trunk/build/test/checkstyle-errors.html
+$JIRA_COMMENT_FOOTER"
+ ### TODO: calculate actual patchStyleErrors
+# patchStyleErrors=0
+# if [[ $patchStyleErrors != 0 ]] ; then
+# JIRA_COMMENT="$JIRA_COMMENT
+#
+# checkstyle -1. The patch generated $patchStyleErrors code style errors."
+# return 1
+# fi
+# JIRA_COMMENT="$JIRA_COMMENT
+#
+# checkstyle +1. The patch generated 0 code style errors."
+ return 0
+}
+
+###############################################################################
+### Check there are no changes in the number of Findbugs warnings
+checkFindbugsWarnings () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Determining number of patched Findbugs warnings."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs
+ if [ $? != 0 ] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ findbugs -1. The patch appears to cause Findbugs to fail."
+ return 1
+ fi
+JIRA_COMMENT_FOOTER="Findbugs warnings: http://hudson.zones.apache.org/hudson/job/$JOB_NAME/$BUILD_NUMBER/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
+$JIRA_COMMENT_FOOTER"
+ cp $BASEDIR/build/test/findbugs/*.xml $PATCH_DIR/patchFindbugsWarnings.xml
+$FINDBUGS_HOME/bin/setBugDatabaseInfo -timestamp "01/01/1999" \
+ $PATCH_DIR/trunkFindbugsWarnings.xml \
+ $PATCH_DIR/trunkFindbugsWarnings.xml
+ $FINDBUGS_HOME/bin/setBugDatabaseInfo -timestamp "01/01/2000" \
+ $PATCH_DIR/patchFindbugsWarnings.xml \
+ $PATCH_DIR/patchFindbugsWarnings.xml
+ $FINDBUGS_HOME/bin/computeBugHistory -output $PATCH_DIR/findbugsMerge.xml \
+ $PATCH_DIR/trunkFindbugsWarnings.xml \
+ $PATCH_DIR/patchFindbugsWarnings.xml
+ findbugsWarnings=`$FINDBUGS_HOME/bin/filterBugs -first "01/01/2000" $PATCH_DIR/findbugsMerge.xml \
+ $BASEDIR/build/test/findbugs/newPatchFindbugsWarnings.xml | /usr/bin/awk '{print $1}'`
+ $FINDBUGS_HOME/bin/convertXmlToText -html \
+ $BASEDIR/build/test/findbugs/newPatchFindbugsWarnings.xml \
+ $BASEDIR/build/test/findbugs/newPatchFindbugsWarnings.html
+ if [[ $findbugsWarnings != 0 ]] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ findbugs -1. The patch appears to introduce $findbugsWarnings new Findbugs warnings."
+ return 1
+ fi
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ findbugs +1. The patch does not introduce any new Findbugs warnings."
+ return 0
+}
+
+###############################################################################
+### Run the test-core target
+runCoreTests () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Running core tests."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+
+ ### Kill any rogue build processes from the last attempt
+ $PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
+
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME create-c++-configure docs tar test-core
+ if [[ $? != 0 ]] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ core tests -1. The patch failed core unit tests."
+ return 1
+ fi
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ core tests +1. The patch passed core unit tests."
+ return 0
+}
+
+###############################################################################
+### Run the test-contrib target
+runContribTests () {
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Running contrib tests."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+
+ ### Kill any rogue build processes from the last attempt
+ $PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
+
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib
+ if [[ $? != 0 ]] ; then
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ contrib tests -1. The patch failed contrib unit tests."
+ return 1
+ fi
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ contrib tests +1. The patch passed contrib unit tests."
+ return 0
+}
+
+###############################################################################
+### Submit a comment to the defect's Jira
+submitJiraComment () {
+ local result=$1
+ ### Do not output the value of JIRA_COMMENT_FOOTER when run by a developer
+ if [[ $HUDSON == "false" ]] ; then
+ JIRA_COMMENT_FOOTER=""
+ fi
+ if [[ $result == 0 ]] ; then
+ comment="+1 overall. $JIRA_COMMENT
+
+$JIRA_COMMENT_FOOTER"
+ else
+ comment="-1 overall. $JIRA_COMMENT
+
+$JIRA_COMMENT_FOOTER"
+ fi
+ ### Output the test result to the console
+ echo "
+
+
+
+$comment"
+
+ if [[ $HUDSON == "true" ]] ; then
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Adding comment to Jira."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+
+ ### Update Jira with a comment
+ export USER=hudson
+ $JIRACLI -s issues.apache.org/jira login hadoopqa $JIRA_PASSWD
+ $JIRACLI -s issues.apache.org/jira comment $defect "$comment"
+ $JIRACLI -s issues.apache.org/jira logout
+ fi
+}
+
+###############################################################################
+### Cleanup files
+cleanupAndExit () {
+ local result=$1
+ if [[ $HUDSON == "true" ]] ; then
+ if [ -e "$PATCH_DIR" ] ; then
+ mv $PATCH_DIR $BASEDIR
+ fi
+ fi
+ echo ""
+ echo ""
+ echo "======================================================================"
+ echo "======================================================================"
+ echo " Finished build."
+ echo "======================================================================"
+ echo "======================================================================"
+ echo ""
+ echo ""
+ exit $result
+}
+
+###############################################################################
+###############################################################################
+###############################################################################
+
+JIRA_COMMENT=""
+JIRA_COMMENT_FOOTER="Console output: http://hudson.zones.apache.org/hudson/job/$JOB_NAME/$BUILD_NUMBER/console
+
+This message is automatically generated."
+
+### Check if arguments to the script have been specified properly or not
+parseArgs $@
+cd $BASEDIR
+
+checkout
+RESULT=$?
+if [[ $HUDSON == "true" ]] ; then
+ if [[ $RESULT != 0 ]] ; then
+ ### Resubmit build.
+ $WGET -q -O $PATCH_DIR/build $TRIGGER_BUILD_URL
+ exit 100
+ fi
+fi
+setup
+checkAuthor
+RESULT=$?
+
+checkTests
+(( RESULT = RESULT + $? ))
+applyPatch
+if [[ $? != 0 ]] ; then
+ submitJiraComment 1
+ cleanupAndExit $?
+fi
+checkJavadocWarnings
+(( RESULT = RESULT + $? ))
+checkJavacWarnings
+(( RESULT = RESULT + $? ))
+checkStyle
+(( RESULT = RESULT + $? ))
+checkFindbugsWarnings
+(( RESULT = RESULT + $? ))
+### Do not call these when run by a developer
+if [[ $HUDSON == "true" ]] ; then
+ checkReleaseAuditWarnings
+ (( RESULT = RESULT + $? ))
+ runCoreTests
+ (( RESULT = RESULT + $? ))
+ runContribTests
+ (( RESULT = RESULT + $? ))
+fi
+JIRA_COMMENT_FOOTER="Test results: http://hudson.zones.apache.org/hudson/job/$JOB_NAME/$BUILD_NUMBER/testReport/
+$JIRA_COMMENT_FOOTER"
+
+submitJiraComment $RESULT
+cleanupAndExit $RESULT
+
+
[yetus] 22/24: HADOOP-5279. Remove unnecessary targets from test-patch.sh. Contributed by Giridharan Kesavan.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit c695d77bf2ab97e5ea63f50142aaaf31faf7cb4c
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Thu Feb 19 17:23:12 2009 +0000
HADOOP-5279. Remove unnecessary targets from test-patch.sh. Contributed by Giridharan Kesavan.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@745934 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 947d1a37..7dc4953e 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -471,8 +471,8 @@ runCoreTests () {
### Kill any rogue build processes from the last attempt
$PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
- echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME create-c++-configure docs tar test-core"
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME create-c++-configure docs tar test-core
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME create-c++-configure test-core"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME create-c++-configure test-core
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
[yetus] 12/24: fix patch process to log a more coherent message when the eclipse jars are not right
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit a8e1b95fb07f1453993c0a531390061c6eb51f15
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Wed Aug 27 06:08:36 2008 +0000
fix patch process to log a more coherent message when the eclipse jars are not right
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@689363 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index c4ca7fec..7e121e56 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -488,11 +488,15 @@ runContribTestOnEclipseFiles () {
export ECLIPSE_DECLARED_SRC=$(sed -n 's@.*kind="src".*path="\(.*\)".*@\1@p' < .eclipse.templates/.classpath |sort)
if [ "${DECLARED_JARS}" != "${PRESENT_JARS}" ]; then
- echo "Some jars are not declared in the Eclipse project."
+ echo "
+FAILED. Some jars are not declared in the Eclipse project.
+ Declared jars: ${DECLARED_JARS}
+ Present jars: ${PRESENT_JARS}"
return 1
fi
for dir in $ECLIPSE_DECLARED_SRC; do
- [ '!' -d $dir ] && echo "$dir is referenced in the Eclipse project although it doesn't exists anymore." && return 1
+ [ '!' -d $dir ] && echo "
+FAILED: $dir is referenced in the Eclipse project although it doesn't exists anymore." && return 1
done
return 0
}
[yetus] 20/24: HADOOP-4948. Add parameters java5.home and forrest.home to the ant commands in test-patch.sh. (Giridharan Kesavan via szetszwo)
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit faa37a5c7dfb5e245d22b423b02afa6043944ce6
Author: Tsz-wo Sze <sz...@apache.org>
AuthorDate: Sun Dec 28 19:52:36 2008 +0000
HADOOP-4948. Add parameters java5.home and forrest.home to the ant commands in test-patch.sh. (Giridharan Kesavan via szetszwo)
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@729769 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 335c3465..bdaca71e 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -75,7 +75,7 @@ parseArgs() {
FINDBUGS_HOME=$7
FORREST_HOME=$8
BASEDIR=$9
- JAVA5_HOME=$10
+ JAVA5_HOME=${10}
### Obtain the patch filename to append it to the version number
defect=`basename $PATCH_FILE`
;;
@@ -164,14 +164,14 @@ setup () {
### echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/trunkReleaseAuditWarnings.txt 2>&1"
### $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/trunkReleaseAuditWarnings.txt 2>&1
### fi
- echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1"
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1
if [[ $? != 0 ]] ; then
echo "Trunk compilation is broken?"
cleanupAndExit 1
fi
- echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs > /dev/null 2>&1"
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs > /dev/null 2>&1
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= findbugs > /dev/null 2>&1"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= findbugs > /dev/null 2>&1
if [[ $? != 0 ]] ; then
echo "Trunk findbugs is broken?"
cleanupAndExit 1
@@ -307,8 +307,8 @@ checkJavacWarnings () {
echo "======================================================================"
echo ""
echo ""
- echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= tar > $PATCH_DIR/patchJavacWarnings.txt 2>&1"
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= tar > $PATCH_DIR/patchJavacWarnings.txt 2>&1
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= tar > $PATCH_DIR/patchJavacWarnings.txt 2>&1"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= tar > $PATCH_DIR/patchJavacWarnings.txt 2>&1
### Compare trunk and patch javac warning numbers
if [[ -f $PATCH_DIR/patchJavacWarnings.txt ]] ; then
@@ -420,8 +420,8 @@ checkFindbugsWarnings () {
echo "======================================================================"
echo ""
echo ""
- echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs"
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= findbugs"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= findbugs
if [ $? != 0 ] ; then
JIRA_COMMENT="$JIRA_COMMENT
[yetus] 14/24: HADOOP-4074. Commenting out release audit in patch testing process until it can be fixed.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit d133273a4a061a3626dd63f9ef310eb71c7ef949
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Thu Sep 4 22:05:15 2008 +0000
HADOOP-4074. Commenting out release audit in patch testing process until it can be fixed.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@692271 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 1f5856a0..34b9c39c 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -156,10 +156,11 @@ setup () {
echo "======================================================================"
echo ""
echo ""
+ ### DISABLE RELEASE AUDIT UNTIL HADOOP-4074 IS FIXED
### Do not call releaseaudit when run by a developer
- if [[ $HUDSON == "true" ]] ; then
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/trunkReleaseAuditWarnings.txt
- fi
+ ### if [[ $HUDSON == "true" ]] ; then
+ ### $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/trunkReleaseAuditWarnings.txt
+ ### fi
$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= clean tar &> $PATCH_DIR/trunkJavacWarnings.txt
if [[ $? != 0 ]] ; then
echo "Trunk compilation is broken?"
@@ -639,8 +640,9 @@ checkFindbugsWarnings
(( RESULT = RESULT + $? ))
### Do not call these when run by a developer
if [[ $HUDSON == "true" ]] ; then
- checkReleaseAuditWarnings
- (( RESULT = RESULT + $? ))
+ ### DISABLE RELEASE AUDIT UNTIL HADOOP-4074 IS FIXED
+ ### checkReleaseAuditWarnings
+ ### (( RESULT = RESULT + $? ))
runCoreTests
(( RESULT = RESULT + $? ))
runContribTests
[yetus] 05/24: HADOOP-3345. Enhance the hudson-test-patch target to cleanup messages, fix minor defects, and add eclipse plugin and python unit tests. Contributed by Nigel Daley.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit be9de904706ec7d35c2eeea841ca0c6a04914926
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Sun May 4 06:51:19 2008 +0000
HADOOP-3345. Enhance the hudson-test-patch target to cleanup messages, fix minor defects, and add eclipse plugin and python unit tests. Contributed by Nigel Daley.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@653184 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 73 +++++++++++++++++++++++++++-------------------
1 file changed, 43 insertions(+), 30 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 2794aacc..2d1538a4 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -12,8 +12,8 @@ parseArgs() {
HUDSON)
### Set HUDSON to true to indicate that this script is being run by Hudson
HUDSON=true
- if [[ $# != 14 ]] ; then
- echo "ERROR: usage $0 HUDSON <PATCH_DIR> <SUPPORT_DIR> <PS_CMD> <WGET_CMD> <JIRACLI> <SVN_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <WORKSPACE_BASEDIR> <TRIGGER_BUILD> <JIRA_PASSWD>"
+ if [[ $# != 16 ]] ; then
+ echo "ERROR: usage $0 HUDSON <PATCH_DIR> <SUPPORT_DIR> <PS_CMD> <WGET_CMD> <JIRACLI> <SVN_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <ECLIPSE_HOME> <PYTHON_HOME> <WORKSPACE_BASEDIR> <TRIGGER_BUILD> <JIRA_PASSWD>"
cleanupAndExit 0
fi
PATCH_DIR=$2
@@ -26,9 +26,11 @@ parseArgs() {
PATCH=$9
FINDBUGS_HOME=${10}
FORREST_HOME=${11}
- BASEDIR=${12}
- TRIGGER_BUILD_URL=${13}
- JIRA_PASSWD=${14}
+ ECLIPSE_HOME=${12}
+ PYTHON_HOME=${13}
+ BASEDIR=${14}
+ TRIGGER_BUILD_URL=${15}
+ JIRA_PASSWD=${16}
### Retrieve the defect number
if [ ! -e $PATCH_DIR/defectNum ] ; then
echo "Could not determine the patch to test. Exiting."
@@ -39,6 +41,8 @@ parseArgs() {
echo "Could not determine the patch to test. Exiting."
cleanupAndExit 0
fi
+ ECLIPSE_PROPERTY="-Declipse.home=$ECLIPSE_HOME"
+ PYTHON_PROPERTY="-Dpython.home=$PYTHON_HOME"
;;
DEVELOPER)
### Set HUDSON to false to indicate that this script is being run by a developer
@@ -154,8 +158,16 @@ setup () {
if [[ $HUDSON == "true" ]] ; then
$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/trunkReleaseAuditWarnings.txt
fi
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" -DHadoopPatchProcess= clean tar &> $PATCH_DIR/trunkJavacWarnings.txt
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= clean tar &> $PATCH_DIR/trunkJavacWarnings.txt
+ if [[ $? != 0 ]] ; then
+ echo "Trunk compilation is broken?"
+ cleanupAndExit 1
+ fi
$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs &> /dev/null
+ if [[ $? != 0 ]] ; then
+ echo "Trunk findbugs is broken?"
+ cleanupAndExit 1
+ fi
cp $BASEDIR/build/test/findbugs/*.xml $PATCH_DIR/trunkFindbugsWarnings.xml
}
@@ -176,12 +188,12 @@ checkAuthor () {
if [[ $authorTags != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
- @author -1. The patch appears to contain $authorTags @author tags which the Hadoop community has agreed to not allow in code contributions."
+ -1 @author. The patch appears to contain $authorTags @author tags which the Hadoop community has agreed to not allow in code contributions."
return 1
fi
JIRA_COMMENT="$JIRA_COMMENT
- @author +1. The patch does not contain any @author tags."
+ +1 @author. The patch does not contain any @author tags."
return 0
}
@@ -202,13 +214,13 @@ checkTests () {
if [[ $testReferences == 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
- tests included -1. The patch doesn't appear to include any new or modified tests.
+ -1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch."
return 1
fi
JIRA_COMMENT="$JIRA_COMMENT
- tests included +1. The patch appears to include $testReferences new or modified tests."
+ +1 tests included. The patch appears to include $testReferences new or modified tests."
return 0
}
@@ -229,7 +241,7 @@ applyPatch () {
echo "PATCH APPLICATION FAILED"
JIRA_COMMENT="$JIRA_COMMENT
- patch -1. The patch command could not apply the patch."
+ -1 patch. The patch command could not apply the patch."
return 1
fi
return 0
@@ -255,12 +267,12 @@ checkJavadocWarnings () {
if [[ $javadocWarnings != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
- javadoc -1. The javadoc tool appears to have generated $javadocWarnings warning messages."
+ -1 javadoc. The javadoc tool appears to have generated $javadocWarnings warning messages."
return 1
fi
JIRA_COMMENT="$JIRA_COMMENT
- javadoc +1. The javadoc tool did not generate any warning messages."
+ +1 javadoc. The javadoc tool did not generate any warning messages."
return 0
}
@@ -276,7 +288,7 @@ checkJavacWarnings () {
echo "======================================================================"
echo ""
echo ""
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" -DHadoopPatchProcess= tar &> $PATCH_DIR/patchJavacWarnings.txt
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= tar &> $PATCH_DIR/patchJavacWarnings.txt
### Compare trunk and patch javac warning numbers
if [[ -f $PATCH_DIR/patchJavacWarnings.txt ]] ; then
@@ -287,14 +299,14 @@ checkJavacWarnings () {
if [[ $patchJavacWarnings > $trunkJavacWarnings ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
- javac -1. The applied patch generated $patchJavacWarnings javac compiler warnings (more than the trunk's current $trunkJavacWarnings warnings)."
+ -1 javac. The applied patch generated $patchJavacWarnings javac compiler warnings (more than the trunk's current $trunkJavacWarnings warnings)."
return 1
fi
fi
fi
JIRA_COMMENT="$JIRA_COMMENT
- javac +1. The applied patch does not generate any new javac compiler warnings."
+ +1 javac. The applied patch does not increase the total number of javac compiler warnings."
return 0
}
@@ -323,7 +335,7 @@ checkReleaseAuditWarnings () {
if [[ $patchReleaseAuditWarnings > $trunkReleaseAuditWarnings ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
- release audit -1. The applied patch generated $patchReleaseAuditWarnings release audit warnings (more than the trunk's current $trunkReleaseAuditWarnings warnings)."
+ -1 release audit. The applied patch generated $patchReleaseAuditWarnings release audit warnings (more than the trunk's current $trunkReleaseAuditWarnings warnings)."
$GREP '\!?????' $PATCH_DIR/patchReleaseAuditWarnings.txt > $PATCH_DIR/patchReleaseAuditProblems.txt
$GREP '\!?????' $PATCH_DIR/trunkReleaseAuditWarnings.txt > $PATCH_DIR/trunkReleaseAuditProblems.txt
echo "A diff of patched release audit warnings with trunk release audit warnings." > $PATCH_DIR/releaseAuditDiffWarnings.txt
@@ -338,7 +350,7 @@ $JIRA_COMMENT_FOOTER"
fi
JIRA_COMMENT="$JIRA_COMMENT
- release audit +1. The applied patch does not generate any new release audit warnings."
+ +1 release audit. The applied patch does not increase the total number of release audit warnings."
return 0
}
@@ -365,12 +377,12 @@ $JIRA_COMMENT_FOOTER"
# if [[ $patchStyleErrors != 0 ]] ; then
# JIRA_COMMENT="$JIRA_COMMENT
#
-# checkstyle -1. The patch generated $patchStyleErrors code style errors."
+# -1 checkstyle. The patch generated $patchStyleErrors code style errors."
# return 1
# fi
# JIRA_COMMENT="$JIRA_COMMENT
#
-# checkstyle +1. The patch generated 0 code style errors."
+# +1 checkstyle. The patch generated 0 code style errors."
return 0
}
@@ -390,7 +402,7 @@ checkFindbugsWarnings () {
if [ $? != 0 ] ; then
JIRA_COMMENT="$JIRA_COMMENT
- findbugs -1. The patch appears to cause Findbugs to fail."
+ -1 findbugs. The patch appears to cause Findbugs to fail."
return 1
fi
JIRA_COMMENT_FOOTER="Findbugs warnings: http://hudson.zones.apache.org/hudson/job/$JOB_NAME/$BUILD_NUMBER/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
@@ -413,12 +425,12 @@ $FINDBUGS_HOME/bin/setBugDatabaseInfo -timestamp "01/01/1999" \
if [[ $findbugsWarnings != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
- findbugs -1. The patch appears to introduce $findbugsWarnings new Findbugs warnings."
+ -1 findbugs. The patch appears to introduce $findbugsWarnings new Findbugs warnings."
return 1
fi
JIRA_COMMENT="$JIRA_COMMENT
- findbugs +1. The patch does not introduce any new Findbugs warnings."
+ +1 findbugs. The patch does not introduce any new Findbugs warnings."
return 0
}
@@ -442,12 +454,12 @@ runCoreTests () {
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
- core tests -1. The patch failed core unit tests."
+ -1 core tests. The patch failed core unit tests."
return 1
fi
JIRA_COMMENT="$JIRA_COMMENT
- core tests +1. The patch passed core unit tests."
+ +1 core tests. The patch passed core unit tests."
return 0
}
@@ -467,16 +479,16 @@ runContribTests () {
### Kill any rogue build processes from the last attempt
$PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
- contrib tests -1. The patch failed contrib unit tests."
+ -1 contrib tests. The patch failed contrib unit tests."
return 1
fi
JIRA_COMMENT="$JIRA_COMMENT
- contrib tests +1. The patch passed contrib unit tests."
+ +1 contrib tests. The patch passed contrib unit tests."
return 0
}
@@ -573,9 +585,10 @@ RESULT=$?
checkTests
(( RESULT = RESULT + $? ))
applyPatch
-if [[ $? != 0 ]] ; then
+(( RESULT = RESULT + $? ))
+if [[ $RESULT != 0 ]] ; then
submitJiraComment 1
- cleanupAndExit $?
+ cleanupAndExit $RESULT
fi
checkJavadocWarnings
(( RESULT = RESULT + $? ))
[yetus] 21/24: HADOOP-5088. Include releaseaudit target as part of developer test-patch target. Contributed by Giridharan Kesavan.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit d17c67ea642116afb2be81dd080e06ebce54009b
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Fri Jan 30 06:02:06 2009 +0000
HADOOP-5088. Include releaseaudit target as part of developer test-patch target. Contributed by Giridharan Kesavan.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@739187 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index bdaca71e..947d1a37 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -158,12 +158,8 @@ setup () {
echo "======================================================================"
echo ""
echo ""
- ### DISABLE RELEASE AUDIT UNTIL HADOOP-4074 IS FIXED
- ### Do not call releaseaudit when run by a developer
- ### if [[ $HUDSON == "true" ]] ; then
- ### echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/trunkReleaseAuditWarnings.txt 2>&1"
- ### $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/trunkReleaseAuditWarnings.txt 2>&1
- ### fi
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/trunkReleaseAuditWarnings.txt 2>&1"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/trunkReleaseAuditWarnings.txt 2>&1
echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1"
$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1
if [[ $? != 0 ]] ; then
@@ -342,8 +338,8 @@ checkReleaseAuditWarnings () {
echo "======================================================================"
echo ""
echo ""
- echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/patchReleaseAuditWarnings.txt 2>&1"
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/patchReleaseAuditWarnings.txt 2>&1
+ echo "$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/patchReleaseAuditWarnings.txt 2>&1"
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} -DHadoopPatchProcess= releaseaudit > $PATCH_DIR/patchReleaseAuditWarnings.txt 2>&1
### Compare trunk and patch release audit warning numbers
if [[ -f $PATCH_DIR/patchReleaseAuditWarnings.txt ]] ; then
@@ -675,11 +671,10 @@ checkFindbugsWarnings
(( RESULT = RESULT + $? ))
checkEclipse
(( RESULT = RESULT + $? ))
+checkReleaseAuditWarnings
+(( RESULT = RESULT + $? ))
### Do not call these when run by a developer
if [[ $HUDSON == "true" ]] ; then
- ### DISABLE RELEASE AUDIT UNTIL HADOOP-4074 IS FIXED
- ### checkReleaseAuditWarnings
- ### (( RESULT = RESULT + $? ))
runCoreTests
(( RESULT = RESULT + $? ))
runContribTests
@@ -690,5 +685,3 @@ $JIRA_COMMENT_FOOTER"
submitJiraComment $RESULT
cleanupAndExit $RESULT
-
-
[yetus] 01/24: Create hadoop sub-project.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 299fb88129de131369f858cbbaf6cbfb735a49cf
Author: Doug Cutting <cu...@apache.org>
AuthorDate: Fri Jan 27 22:19:42 2006 +0000
Create hadoop sub-project.
git-svn-id: https://svn.apache.org/repos/asf/lucene/hadoop/trunk@373007 13f79535-47bb-0310-9956-ffa450edef68
[yetus] 07/24: HADOOP-3435. Remove the assuption in the scripts that bash is at /bin/bash and fix the test patch to require bash instead of sh. Contributed by Brice Arnould.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit c8d3e108f01691a8f0c80c1b8220a7dcf7a232d0
Author: Owen O'Malley <om...@apache.org>
AuthorDate: Mon Jun 2 20:48:29 2008 +0000
HADOOP-3435. Remove the assuption in the scripts that bash is at
/bin/bash and fix the test patch to require bash instead of sh.
Contributed by Brice Arnould.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@662557 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index b7681201..e3d5ba8f 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
#set -x
ulimit -n 1024
[yetus] 15/24: HADOOP-4075. test-patch.sh now spits out ant commands that it runs. Contributed by Ramya R
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 2978856bef7ad08df0f8bdb6f61aea7cc3e3a468
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Thu Sep 18 06:38:05 2008 +0000
HADOOP-4075. test-patch.sh now spits out ant commands that it runs. Contributed by Ramya R
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@696573 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 30 ++++++++++++++++++++----------
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 34b9c39c..2b3adfd4 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -159,14 +159,17 @@ setup () {
### DISABLE RELEASE AUDIT UNTIL HADOOP-4074 IS FIXED
### Do not call releaseaudit when run by a developer
### if [[ $HUDSON == "true" ]] ; then
- ### $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/trunkReleaseAuditWarnings.txt
+ ### CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/trunkReleaseAuditWarnings.txt"
+ ### echo $CMD ; $CMD
### fi
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= clean tar &> $PATCH_DIR/trunkJavacWarnings.txt
+ CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= clean tar &> $PATCH_DIR/trunkJavacWarnings.txt"
+ echo $CMD ; $CMD
if [[ $? != 0 ]] ; then
echo "Trunk compilation is broken?"
cleanupAndExit 1
fi
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs &> /dev/null
+ CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs &> /dev/null"
+ echo $CMD ; $CMD
if [[ $? != 0 ]] ; then
echo "Trunk findbugs is broken?"
cleanupAndExit 1
@@ -272,7 +275,8 @@ checkJavadocWarnings () {
echo "======================================================================"
echo ""
echo ""
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= clean javadoc | tee $PATCH_DIR/patchJavadocWarnings.txt
+ CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= clean javadoc | tee $PATCH_DIR/patchJavadocWarnings.txt"
+ echo $CMD ; $CMD
javadocWarnings=`$GREP -c '\[javadoc\] [0-9]* warning' $PATCH_DIR/patchJavadocWarnings.txt`
echo ""
echo ""
@@ -301,7 +305,8 @@ checkJavacWarnings () {
echo "======================================================================"
echo ""
echo ""
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= tar &> $PATCH_DIR/patchJavacWarnings.txt
+ CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -Djavac.args="-Xlint -Xmaxwarns 1000" $ECLIPSE_PROPERTY -DHadoopPatchProcess= tar &> $PATCH_DIR/patchJavacWarnings.txt"
+ echo $CMD ; $CMD
### Compare trunk and patch javac warning numbers
if [[ -f $PATCH_DIR/patchJavacWarnings.txt ]] ; then
@@ -335,7 +340,8 @@ checkReleaseAuditWarnings () {
echo "======================================================================"
echo ""
echo ""
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/patchReleaseAuditWarnings.txt
+ CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= releaseaudit &> $PATCH_DIR/patchReleaseAuditWarnings.txt"
+ echo $CMD ; $CMD
### Compare trunk and patch release audit warning numbers
if [[ -f $PATCH_DIR/patchReleaseAuditWarnings.txt ]] ; then
@@ -382,7 +388,8 @@ checkStyle () {
echo "THIS IS NOT IMPLEMENTED YET"
echo ""
echo ""
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= checkstyle
+ CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= checkstyle"
+ echo $CMD ; $CMD
JIRA_COMMENT_FOOTER="Checkstyle results: http://hudson.zones.apache.org/hudson/job/$JOB_NAME/$BUILD_NUMBER/artifact/trunk/build/test/checkstyle-errors.html
$JIRA_COMMENT_FOOTER"
### TODO: calculate actual patchStyleErrors
@@ -411,7 +418,8 @@ checkFindbugsWarnings () {
echo "======================================================================"
echo ""
echo ""
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs
+ CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -Dfindbugs.home=$FINDBUGS_HOME -DHadoopPatchProcess= findbugs"
+ echo $CMD ; $CMD
if [ $? != 0 ] ; then
JIRA_COMMENT="$JIRA_COMMENT
@@ -465,7 +473,8 @@ runCoreTests () {
### Kill any rogue build processes from the last attempt
$PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME create-c++-configure docs tar test-core
+ CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME create-c++-configure docs tar test-core"
+ echo $CMD ; $CMD
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
@@ -520,7 +529,8 @@ runContribTests () {
### Kill any rogue build processes from the last attempt
$PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
- $ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib && runContribTestOnEclipseFiles
+ CMD="$ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib && runContribTestOnEclipseFiles"
+ echo $CMD ; $CMD
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
[yetus] 08/24: HADOOP-3480. Need to update Eclipse template to reflect current trunk. Contributed by Brice Arnould.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 2e98160552f4cea1bccbaceab74e525569d18a93
Author: Thomas White <to...@apache.org>
AuthorDate: Wed Jun 25 14:31:03 2008 +0000
HADOOP-3480. Need to update Eclipse template to reflect current trunk. Contributed by Brice Arnould.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@671563 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index e3d5ba8f..8699fee6 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -463,6 +463,22 @@ runCoreTests () {
return 0
}
+###############################################################################
+### Tests parts of contrib specific to the eclipse files
+runContribTestOnEclipseFiles () {
+ export ECLIPSE_DECLARED_JARS=$(sed -n 's@.*kind="lib".*path="\(.*jar\)".*@\1@p' < .eclipse.templates/.classpath |sort)
+ export PRESENT_JARS=$(find lib/ -name '*.jar' |sort)
+ export ECLIPSE_DECLARED_SRC=$(sed -n 's@.*kind="src".*path="\(.*\)".*@\1@p' < .eclipse.templates/.classpath |sort)
+ if [ "${ECLIPSE_DECLARED_JARS}" != "${PRESENT_JARS}" ]; then
+ echo "Some jars are not declared in the Eclipse project."
+ return 1
+ fi
+ for dir in $ECLIPSE_DECLARED_SRC; do
+ [ '!' -d $dir ] && echo "$dir is referenced in the Eclipse project although it doesn't exists anymore." && return 1
+ done
+ return 0
+}
+
###############################################################################
### Run the test-contrib target
runContribTests () {
@@ -479,7 +495,7 @@ runContribTests () {
### Kill any rogue build processes from the last attempt
$PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
- $ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" $ECLIPSE_PROPERTY $PYTHON_PROPERTY -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib && runContribTestOnEclipseFiles
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
[yetus] 03/24: HADOOP-2939. Make the automated patch testing process an executable Ant target, test-patch. Contributed by Ramya and Nigel.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 260a726240bc39c505d6e752f4d5730238964749
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Tue Mar 18 06:17:49 2008 +0000
HADOOP-2939. Make the automated patch testing process an executable Ant target, test-patch. Contributed by Ramya and Nigel.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@638232 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 97325f1b..712e5dbf 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -94,8 +94,7 @@ checkout () {
if [[ $HUDSON == "false" ]] ; then
if [[ `$SVN stat` != "" ]] ; then
echo "ERROR: can't run in a workspace that contains modifications"
- # PENDING: Uncomment the following line
- # cleanupAndExit 0
+ cleanupAndExit 0
fi
else
cd $BASEDIR
[yetus] 04/24: HADOOP-3142. Increases the number of open files during testing on Hudson.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit f7a70328f272fe4807f7da6c1c8c5136ada155fb
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Tue Apr 1 05:17:27 2008 +0000
HADOOP-3142. Increases the number of open files during testing on Hudson.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@643283 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 712e5dbf..2794aacc 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -1,6 +1,7 @@
#!/bin/bash
#set -x
+ulimit -n 1024
### Setup some variables.
### JOB_NAME, SVN_REVISION, and BUILD_NUMBER are set by Hudson if it is run by patch process
[yetus] 23/24: HADOOP-5232. Enable patch testing to occur on more than one host. Contributed by Giri Kesavan.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 1d402fb78c6a3f623435c9ce4e7b2837f2bf6e9a
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Thu Feb 26 06:34:02 2009 +0000
HADOOP-5232. Enable patch testing to occur on more than one host. Contributed by Giri Kesavan.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@748036 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 7dc4953e..de2b057b 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -12,8 +12,8 @@ parseArgs() {
HUDSON)
### Set HUDSON to true to indicate that this script is being run by Hudson
HUDSON=true
- if [[ $# != 17 ]] ; then
- echo "ERROR: usage $0 HUDSON <PATCH_DIR> <SUPPORT_DIR> <PS_CMD> <WGET_CMD> <JIRACLI> <SVN_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <ECLIPSE_HOME> <PYTHON_HOME> <WORKSPACE_BASEDIR> <TRIGGER_BUILD> <JIRA_PASSWD> <JAVA5_HOME> "
+ if [[ $# != 19 ]] ; then
+ echo "ERROR: usage $0 HUDSON <PATCH_DIR> <SUPPORT_DIR> <PS_CMD> <WGET_CMD> <JIRACLI> <SVN_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <ECLIPSE_HOME> <PYTHON_HOME> <WORKSPACE_BASEDIR> <TRIGGER_BUILD> <JIRA_PASSWD> <JAVA5_HOME> <CURL_CMD> <DEFECT> "
cleanupAndExit 0
fi
PATCH_DIR=$2
@@ -32,16 +32,19 @@ parseArgs() {
TRIGGER_BUILD_URL=${15}
JIRA_PASSWD=${16}
JAVA5_HOME=${17}
+ CURL=${18}
+ defect=${19}
+
### Retrieve the defect number
- if [ ! -e $PATCH_DIR/defectNum ] ; then
- echo "Could not determine the patch to test. Exiting."
- cleanupAndExit 0
- fi
- defect=`cat $PATCH_DIR/defectNum`
if [ -z "$defect" ] ; then
echo "Could not determine the patch to test. Exiting."
cleanupAndExit 0
fi
+
+ if [ ! -e "$PATCH_DIR" ] ; then
+ mkdir -p $PATCH_DIR
+ fi
+
ECLIPSE_PROPERTY="-Declipse.home=$ECLIPSE_HOME"
PYTHON_PROPERTY="-Dpython.home=$PYTHON_HOME"
;;
@@ -615,6 +618,8 @@ cleanupAndExit () {
if [ -e "$PATCH_DIR" ] ; then
mv $PATCH_DIR $BASEDIR
fi
+ CALLER=`hostname`
+ $CURL $PATCH_ADMIN_URL'&CALLER='$CALLER
fi
echo ""
echo ""
@@ -646,7 +651,7 @@ RESULT=$?
if [[ $HUDSON == "true" ]] ; then
if [[ $RESULT != 0 ]] ; then
### Resubmit build.
- $WGET -q -O $PATCH_DIR/build $TRIGGER_BUILD_URL
+ $CURL $TRIGGER_BUILD_URL'&DEFECTNUM='$defect
exit 100
fi
fi
[yetus] 13/24: HDOOP-3966. Copy findbugs generated output files to PATCH_DIR while running test-patch. (contributed by Ramya R)
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 79e321fe13dd99d701c4f2dee94f02f7d66a3131
Author: Lohit Vijaya Renu <lo...@apache.org>
AuthorDate: Thu Aug 28 06:46:04 2008 +0000
HDOOP-3966. Copy findbugs generated output files to PATCH_DIR while running test-patch. (contributed by Ramya R)
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@689733 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 7e121e56..1f5856a0 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -434,6 +434,8 @@ $FINDBUGS_HOME/bin/setBugDatabaseInfo -timestamp "01/01/1999" \
$FINDBUGS_HOME/bin/convertXmlToText -html \
$BASEDIR/build/test/findbugs/newPatchFindbugsWarnings.xml \
$BASEDIR/build/test/findbugs/newPatchFindbugsWarnings.html
+ cp $BASEDIR/build/test/findbugs/newPatchFindbugsWarnings.html $PATCH_DIR/newPatchFindbugsWarnings.html
+ cp $BASEDIR/build/test/findbugs/newPatchFindbugsWarnings.xml $PATCH_DIR/newPatchFindbugsWarnings.xml
if [[ $findbugsWarnings != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
[yetus] 06/24: HADOOP-3345. Enhance the hudson-test-patch target to cleanup messages, fix minor defects, and add eclipse plugin and python unit tests. Contributed by Nigel Daley.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 76c330d43f8baacb71cf53a7cae41de1c7a80149
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Sun May 4 16:07:22 2008 +0000
HADOOP-3345. Enhance the hudson-test-patch target to cleanup messages, fix minor defects, and add eclipse plugin and python unit tests. Contributed by Nigel Daley.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@653239 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 2d1538a4..b7681201 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -585,10 +585,9 @@ RESULT=$?
checkTests
(( RESULT = RESULT + $? ))
applyPatch
-(( RESULT = RESULT + $? ))
-if [[ $RESULT != 0 ]] ; then
+if [[ $? != 0 ]] ; then
submitJiraComment 1
- cleanupAndExit $RESULT
+ cleanupAndExit 1
fi
checkJavadocWarnings
(( RESULT = RESULT + $? ))
[yetus] 24/24: Hadoop-5800 - to fix incorrect cleanup of svn workspace
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit fd0ce8db80c6f6c40d7c3447e02c6b2192879bae
Author: Giridharan Kesavan <gk...@apache.org>
AuthorDate: Tue May 12 05:38:26 2009 +0000
Hadoop-5800 - to fix incorrect cleanup of svn workspace
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@773790 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index de2b057b..dc61b887 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -111,7 +111,7 @@ checkout () {
else
cd $BASEDIR
$SVN revert -R .
- rm -rf `$SVN status`
+ rm -rf `$SVN status --no-ignore`
$SVN update
fi
return $?
[yetus] 09/24: HADOOP-2325. Require Java 6.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 7c5ccefd9080d0896f359506cd292f600e8a4c79
Author: Doug Cutting <cu...@apache.org>
AuthorDate: Mon Jul 7 20:42:49 2008 +0000
HADOOP-2325. Require Java 6.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@674626 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 8699fee6..66a25953 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -12,8 +12,8 @@ parseArgs() {
HUDSON)
### Set HUDSON to true to indicate that this script is being run by Hudson
HUDSON=true
- if [[ $# != 16 ]] ; then
- echo "ERROR: usage $0 HUDSON <PATCH_DIR> <SUPPORT_DIR> <PS_CMD> <WGET_CMD> <JIRACLI> <SVN_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <ECLIPSE_HOME> <PYTHON_HOME> <WORKSPACE_BASEDIR> <TRIGGER_BUILD> <JIRA_PASSWD>"
+ if [[ $# != 17 ]] ; then
+ echo "ERROR: usage $0 HUDSON <PATCH_DIR> <SUPPORT_DIR> <PS_CMD> <WGET_CMD> <JIRACLI> <SVN_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <ECLIPSE_HOME> <PYTHON_HOME> <WORKSPACE_BASEDIR> <TRIGGER_BUILD> <JIRA_PASSWD> <JAVA5_HOME> "
cleanupAndExit 0
fi
PATCH_DIR=$2
@@ -31,6 +31,7 @@ parseArgs() {
BASEDIR=${14}
TRIGGER_BUILD_URL=${15}
JIRA_PASSWD=${16}
+ JAVA5_HOME=${17}
### Retrieve the defect number
if [ ! -e $PATCH_DIR/defectNum ] ; then
echo "Could not determine the patch to test. Exiting."
@@ -47,8 +48,8 @@ parseArgs() {
DEVELOPER)
### Set HUDSON to false to indicate that this script is being run by a developer
HUDSON=false
- if [[ $# != 9 ]] ; then
- echo "ERROR: usage $0 DEVELOPER <PATCH_FILE> <SCRATCH_DIR> <SVN_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <WORKSPACE_BASEDIR>"
+ if [[ $# != 10 ]] ; then
+ echo "ERROR: usage $0 DEVELOPER <PATCH_FILE> <SCRATCH_DIR> <SVN_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <WORKSPACE_BASEDIR> <JAVA5_HOME>"
cleanupAndExit 0
fi
### PATCH_FILE contains the location of the patchfile
@@ -74,6 +75,7 @@ parseArgs() {
FINDBUGS_HOME=$7
FORREST_HOME=$8
BASEDIR=$9
+ JAVA5_HOME=$10
### Obtain the patch filename to append it to the version number
defect=`basename $PATCH_FILE`
;;
@@ -450,7 +452,7 @@ runCoreTests () {
### Kill any rogue build processes from the last attempt
$PS -auxwww | $GREP HadoopPatchProcess | /usr/bin/nawk '{print $2}' | /usr/bin/xargs -t -I {} /usr/bin/kill -9 {} > /dev/null
- $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME create-c++-configure docs tar test-core
+ $ANT_HOME/bin/ant -Dversion="${VERSION}" -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME create-c++-configure docs tar test-core
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
[yetus] 19/24: HADOOP-4878. Fix eclipse plugin classpath file to point to ivy's resolved lib directory and added the same to test-patch.sh. Contributed by Giridharan Kesavan.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit b90fca3a1ceaf7b72cffb0d73c8090df05cabf76
Author: Arun Murthy <ac...@apache.org>
AuthorDate: Wed Dec 17 03:15:16 2008 +0000
HADOOP-4878. Fix eclipse plugin classpath file to point to ivy's resolved lib directory and added the same to test-patch.sh. Contributed by Giridharan Kesavan.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@727255 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 32c4df7e..335c3465 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -493,7 +493,7 @@ runCoreTests () {
### Tests parts of contrib specific to the eclipse files
checkJarFilesDeclaredInEclipse () {
export DECLARED_JARS=$(sed -n 's@.*kind="lib".*path="\(.*jar\)".*@\1@p' < .eclipse.templates/.classpath)
- export PRESENT_JARS=$(find lib/ src/test/lib/ -name '*.jar' |sort)
+ export PRESENT_JARS=$(find build/ivy/lib/Hadoop/common/ lib/ src/test/lib/ -name '*.jar' |sort)
# When run by Hudson, consider libs from ${SUPPORT_DIR} declared
if [[ ${HUDSON} == "true" ]]; then
DECLARED_JARS="${DECLARED_JARS} $(cd "${SUPPORT_DIR}"; find lib -name '*.jar')"
[yetus] 17/24: HADOOP-3975. Change test-patch script to report working the dir modifications preventing the suite from being run. Contributed by Ramya R.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 34ff4786e728a961c41d90e07c2e4fdad427344d
Author: Christopher Douglas <cd...@apache.org>
AuthorDate: Fri Sep 19 19:05:18 2008 +0000
HADOOP-3975. Change test-patch script to report working the dir
modifications preventing the suite from being run. Contributed by Ramya R.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@697189 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index abdc493f..4da15267 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -98,10 +98,12 @@ checkout () {
echo ""
echo ""
### When run by a developer, if the workspace contains modifications, do not continue
+ status=`$SVN stat`
if [[ $HUDSON == "false" ]] ; then
- if [[ `$SVN stat` != "" ]] ; then
- echo "ERROR: can't run in a workspace that contains modifications"
- cleanupAndExit 0
+ if [[ "$status" != "" ]] ; then
+ echo "ERROR: can't run in a workspace that contains the following modifications"
+ echo "$status"
+ cleanupAndExit 1
fi
else
cd $BASEDIR
[yetus] 11/24: Patch process shouldn't -1 documentation patch for not having any tests.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit a0edec78758b9804d0b07dabde8f188380a54d4c
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Fri Jul 18 07:00:40 2008 +0000
Patch process shouldn't -1 documentation patch for not having any tests.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@677839 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 47af83cc..c4ca7fec 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -214,6 +214,16 @@ checkTests () {
testReferences=`$GREP -c -i '/test' $PATCH_DIR/patch`
echo "There appear to be $testReferences test files referenced in the patch."
if [[ $testReferences == 0 ]] ; then
+ if [[ $HUDSON == "true" ]] ; then
+ patchIsDoc=`$GREP -c -i 'title="documentation' $PATCH_DIR/jira`
+ if [[ $patchIsDoc != 0 ]] ; then
+ echo "The patch appears to be a documentation patch that doesn't require tests."
+ JIRA_COMMENT="$JIRA_COMMENT
+
+ +0 tests included. The patch appears to be a documentation patch that doesn't require tests."
+ return 0
+ fi
+ fi
JIRA_COMMENT="$JIRA_COMMENT
-1 tests included. The patch doesn't appear to include any new or modified tests.
[yetus] 10/24: HADOOP-3653. Fix test-patch target to properly account for Eclipse classpath jars. Contributed by Brice Arnould.
Posted by aw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aw pushed a commit to tag prehistory
in repository https://gitbox.apache.org/repos/asf/yetus.git
commit 1e8440cfca9029d37806b27fcb2f5aeb4658ef19
Author: Nigel Daley <ni...@apache.org>
AuthorDate: Tue Jul 8 05:08:57 2008 +0000
HADOOP-3653. Fix test-patch target to properly account for Eclipse classpath jars. Contributed by Brice Arnould.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/core/trunk@674720 13f79535-47bb-0310-9956-ffa450edef68
---
src/test/bin/test-patch.sh | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/test/bin/test-patch.sh b/src/test/bin/test-patch.sh
index 66a25953..47af83cc 100755
--- a/src/test/bin/test-patch.sh
+++ b/src/test/bin/test-patch.sh
@@ -468,10 +468,16 @@ runCoreTests () {
###############################################################################
### Tests parts of contrib specific to the eclipse files
runContribTestOnEclipseFiles () {
- export ECLIPSE_DECLARED_JARS=$(sed -n 's@.*kind="lib".*path="\(.*jar\)".*@\1@p' < .eclipse.templates/.classpath |sort)
- export PRESENT_JARS=$(find lib/ -name '*.jar' |sort)
+ export DECLARED_JARS=$(sed -n 's@.*kind="lib".*path="\(.*jar\)".*@\1@p' < .eclipse.templates/.classpath)
+ export PRESENT_JARS=$(find lib/ src/test/lib/ -name '*.jar' |sort)
+ # When run by Hudson, consider libs from ${SUPPORT_DIR} declared
+ if [[ ${HUDSON} == "true" ]]; then
+ DECLARED_JARS="${DECLARED_JARS} $(cd "${SUPPORT_DIR}"; find lib -name '*.jar')"
+ fi
+ DECLARED_JARS=$(sed 'y/ /\n/' <<< ${DECLARED_JARS} | sort)
export ECLIPSE_DECLARED_SRC=$(sed -n 's@.*kind="src".*path="\(.*\)".*@\1@p' < .eclipse.templates/.classpath |sort)
- if [ "${ECLIPSE_DECLARED_JARS}" != "${PRESENT_JARS}" ]; then
+
+ if [ "${DECLARED_JARS}" != "${PRESENT_JARS}" ]; then
echo "Some jars are not declared in the Eclipse project."
return 1
fi