You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/06 10:40:05 UTC
[GitHub] [flink] twalthr opened a new pull request #11646:
[FLINK-16988][table] Add core table source/sink interfaces
twalthr opened a new pull request #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646
## What is the purpose of the change
Adds the core set of interfaces described in FLIP-95. It also add the first ability interfaces to show the big picture.
## Brief change log
New interfaces and JavaDocs for all of them added.
## Verifying this change
No tests necessary yet.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#discussion_r404846631
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/AsyncTableFunctionProvider.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector.source;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.functions.AsyncTableFunction;
+
+/**
+ * Provider of a {@link AsyncTableFunction} instance as runtime implementation for {@link LookupTableSource}.
Review comment:
What about the other `a`? In `instance as **a** runtime implementation`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159075578",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "309875284774696c1a2a589b100f2b696debaef4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "309875284774696c1a2a589b100f2b696debaef4",
"triggerType" : "PUSH"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159075578",
"triggerID" : "610801475",
"triggerType" : "MANUAL"
}, {
"hash" : "df2cf46500a9e46201a380ee0178bb5de7c0011c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "df2cf46500a9e46201a380ee0178bb5de7c0011c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5b440945983dce4b844bc280f3180872c618d6a Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159075578) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165)
* 309875284774696c1a2a589b100f2b696debaef4 UNKNOWN
* df2cf46500a9e46201a380ee0178bb5de7c0011c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on a change in pull request #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#discussion_r404895197
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/AsyncTableFunctionProvider.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector.source;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.functions.AsyncTableFunction;
+
+/**
+ * Provider of a {@link AsyncTableFunction} instance as runtime implementation for {@link LookupTableSource}.
Review comment:
I hope I could fix all occurrences now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159075578",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "309875284774696c1a2a589b100f2b696debaef4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "309875284774696c1a2a589b100f2b696debaef4",
"triggerType" : "PUSH"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159075578",
"triggerID" : "610801475",
"triggerType" : "MANUAL"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165",
"triggerID" : "610801475",
"triggerType" : "MANUAL"
}, {
"hash" : "df2cf46500a9e46201a380ee0178bb5de7c0011c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7197",
"triggerID" : "df2cf46500a9e46201a380ee0178bb5de7c0011c",
"triggerType" : "PUSH"
}, {
"hash" : "df2cf46500a9e46201a380ee0178bb5de7c0011c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249851",
"triggerID" : "df2cf46500a9e46201a380ee0178bb5de7c0011c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5b440945983dce4b844bc280f3180872c618d6a Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159075578) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165)
* 309875284774696c1a2a589b100f2b696debaef4 UNKNOWN
* df2cf46500a9e46201a380ee0178bb5de7c0011c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159249851) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7197)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#discussion_r404619586
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/ChangelogMode.java
##########
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.types.RowKind;
+import org.apache.flink.util.Preconditions;
+
+import java.util.Collections;
+import java.util.EnumSet;
+import java.util.Objects;
+import java.util.Set;
+
+/**
+ * The set of changes contained in a changelog.
+ *
+ * @see RowKind
+ */
+@PublicEvolving
+public final class ChangelogMode {
+
+ private static final ChangelogMode INSERT_ONLY = ChangelogMode.newBuilder()
+ .addContainedKind(RowKind.INSERT)
+ .build();
+
+ private final Set<RowKind> kinds;
+
+ private ChangelogMode(Set<RowKind> kinds) {
+ Preconditions.checkArgument(
+ kinds.size() > 0,
+ "At least one kind of row should be contained in a changelog.");
+ this.kinds = Collections.unmodifiableSet(kinds);
+ }
+
+ /**
+ * Shortcut for a simple {@link RowKind#INSERT}-only changelog.
+ */
+ public static ChangelogMode insertOnly() {
+ return INSERT_ONLY;
+ }
+
+ /**
+ * Builder for configuring and creating instances of {@link ChangelogMode}.
+ */
+ public static Builder newBuilder() {
+ return new Builder();
+ }
+
+ public Set<RowKind> getContainedKinds() {
+ return kinds;
+ }
+
+ public boolean contains(RowKind kind) {
+ return kinds.contains(kind);
+ }
+
+ public boolean containsOnly(RowKind kind) {
+ return kinds.size() == 1 && kinds.contains(kind);
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ ChangelogMode that = (ChangelogMode) o;
+ return kinds.equals(that.kinds);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(kinds);
+ }
+
+ // --------------------------------------------------------------------------------------------
+
+ /**
+ * Builder for configuring and creating instances of {@link ChangelogMode}.
+ */
+ public static class Builder {
+
+ private final Set<RowKind> kinds = EnumSet.noneOf(RowKind.class);
+
+ public Builder() {
Review comment:
nit: Could it be private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce9feb4892fd0b679ee8a7da4fa48211939d72e6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158648593) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098)
* 7398eee91aa23eaacda1117abda8f375a49a66fd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on a change in pull request #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#discussion_r404845111
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsFilterPushDown.java
##########
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector.source.abilities;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.connector.source.ScanTableSource;
+import org.apache.flink.table.expressions.ExpressionVisitor;
+import org.apache.flink.table.expressions.ResolvedExpression;
+
+import java.util.List;
+
+/**
+ * Enables to push down filters into a {@link ScanTableSource}.
+ *
+ * <p>By default, if this interface is not implemented, filters are applied in a subsequent operation
+ * after the source.
+ *
+ * <p>For efficiency, a source can push predicates further down in order to be close to the actual data
Review comment:
Nice source. I also added it to my reading list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on a change in pull request #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#discussion_r404839668
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/AsyncTableFunctionProvider.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector.source;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.functions.AsyncTableFunction;
+
+/**
+ * Provider of a {@link AsyncTableFunction} instance as runtime implementation for {@link LookupTableSource}.
Review comment:
also not sure, rather `a` ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce9feb4892fd0b679ee8a7da4fa48211939d72e6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158648593) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#discussion_r404628911
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/AsyncTableFunctionProvider.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector.source;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.functions.AsyncTableFunction;
+
+/**
+ * Provider of a {@link AsyncTableFunction} instance as runtime implementation for {@link LookupTableSource}.
Review comment:
nit: Mostly to check myself. Shouldn't it be: `Provider of an {@link AsyncTableFunction} instance as a runtime implementation for {@link LookupTableSource}.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11646: [FLINK-16988][table]
Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce9feb4892fd0b679ee8a7da4fa48211939d72e6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7398eee91aa23eaacda1117abda8f375a49a66fd Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158790222) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7398eee91aa23eaacda1117abda8f375a49a66fd Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158790222) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114)
* b5b440945983dce4b844bc280f3180872c618d6a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159075578",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "309875284774696c1a2a589b100f2b696debaef4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "309875284774696c1a2a589b100f2b696debaef4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5b440945983dce4b844bc280f3180872c618d6a Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159075578) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165)
* 309875284774696c1a2a589b100f2b696debaef4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce9feb4892fd0b679ee8a7da4fa48211939d72e6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158648593) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on issue #11646: [FLINK-16988][table] Add
core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
twalthr commented on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609716523
CC @wuchong @dawidwys
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159075578",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "309875284774696c1a2a589b100f2b696debaef4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "309875284774696c1a2a589b100f2b696debaef4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5b440945983dce4b844bc280f3180872c618d6a Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159075578) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165)
* 309875284774696c1a2a589b100f2b696debaef4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159075578",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "309875284774696c1a2a589b100f2b696debaef4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "309875284774696c1a2a589b100f2b696debaef4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7398eee91aa23eaacda1117abda8f375a49a66fd Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158790222) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114)
* b5b440945983dce4b844bc280f3180872c618d6a Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159075578) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165)
* 309875284774696c1a2a589b100f2b696debaef4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11646: [FLINK-16988][table]
Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609717770
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ce9feb4892fd0b679ee8a7da4fa48211939d72e6 (Mon Apr 06 10:43:08 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr closed pull request #11646: [FLINK-16988][table]
Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#discussion_r404622090
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/DynamicTableSink.java
##########
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector.sink;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.connector.ChangelogMode;
+import org.apache.flink.table.connector.RuntimeConverter;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.types.Row;
+import org.apache.flink.types.RowKind;
+
+import javax.annotation.Nullable;
+
+import java.io.Serializable;
+
+/**
+ * Sink of a dynamic table to an external storage system.
+ *
+ * <p>Dynamic tables are the core concept of Flink's Table & SQL API for processing both bounded and
+ * unbounded data in a unified fashion. By definition, a dynamic table can change over time.
+ *
+ * <p>When writing a dynamic table, the content can either be considered as a changelog (finite or
+ * infinite) for which all changes are written out continuously until the changelog is exhausted. The
+ * given {@link ChangelogMode} indicates the set of changes that the sink accepts during runtime.
+ *
+ * <p>For regular batch scenarios, the sink can solely accept insert-only rows and write out bounded
+ * streams.
+ *
+ * <p>For regular streaming scenarios, the sink can solely accept insert-only rows and can write out
+ * unbounded streams.
+ *
+ * <p>For change data capture (CDC) scenarios, the sink can write out bounded or unbounded streams with
+ * insert, update, and delete rows. See also {@link RowKind}.
+ *
+ * <p>Instances of {@link DynamicTableSink} can be seen as factories that eventually produce concrete
+ * runtime implementation for writing the actual data.
+ *
+ * <p>Depending on the optionally declared abilities, the planner might apply changes to an instance
+ * and thus mutates the produced runtime implementation.
Review comment:
nit: `mutates` -> `mutate`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on issue #11646: [FLINK-16988][table] Add
core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
twalthr commented on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-610427527
Thanks for the feedback everyone. I will merge this once the build is green.
@flinkbot run travis
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159075578",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "309875284774696c1a2a589b100f2b696debaef4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "309875284774696c1a2a589b100f2b696debaef4",
"triggerType" : "PUSH"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159075578",
"triggerID" : "610801475",
"triggerType" : "MANUAL"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165",
"triggerID" : "610801475",
"triggerType" : "MANUAL"
}, {
"hash" : "df2cf46500a9e46201a380ee0178bb5de7c0011c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7197",
"triggerID" : "df2cf46500a9e46201a380ee0178bb5de7c0011c",
"triggerType" : "PUSH"
}, {
"hash" : "df2cf46500a9e46201a380ee0178bb5de7c0011c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249851",
"triggerID" : "df2cf46500a9e46201a380ee0178bb5de7c0011c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 309875284774696c1a2a589b100f2b696debaef4 UNKNOWN
* df2cf46500a9e46201a380ee0178bb5de7c0011c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159249851) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7197)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7398eee91aa23eaacda1117abda8f375a49a66fd Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158790222) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on issue #11646: [FLINK-16988][table] Add
core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
twalthr commented on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-610801475
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce9feb4892fd0b679ee8a7da4fa48211939d72e6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158648593) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159075578",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
}, {
"hash" : "b5b440945983dce4b844bc280f3180872c618d6a",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165",
"triggerID" : "b5b440945983dce4b844bc280f3180872c618d6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7398eee91aa23eaacda1117abda8f375a49a66fd Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158790222) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114)
* b5b440945983dce4b844bc280f3180872c618d6a Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159075578) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7165)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#discussion_r404646688
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsFilterPushDown.java
##########
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.connector.source.abilities;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.connector.source.ScanTableSource;
+import org.apache.flink.table.expressions.ExpressionVisitor;
+import org.apache.flink.table.expressions.ResolvedExpression;
+
+import java.util.List;
+
+/**
+ * Enables to push down filters into a {@link ScanTableSource}.
+ *
+ * <p>By default, if this interface is not implemented, filters are applied in a subsequent operation
+ * after the source.
+ *
+ * <p>For efficiency, a source can push predicates further down in order to be close to the actual data
Review comment:
nit: Can we stick to a single term? Either `predicates` or `filters`?
It's an advice from a course that I'm doing lately: https://developers.google.com/tech-writing/one/words#use_terms_consistently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11646:
[FLINK-16988][table] Add core table source/sink interfaces
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11646: [FLINK-16988][table] Add core table source/sink interfaces
URL: https://github.com/apache/flink/pull/11646#issuecomment-609722477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7098",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158648593",
"triggerID" : "ce9feb4892fd0b679ee8a7da4fa48211939d72e6",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"triggerType" : "PUSH"
}, {
"hash" : "7398eee91aa23eaacda1117abda8f375a49a66fd",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158790222",
"triggerID" : "610427527",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7398eee91aa23eaacda1117abda8f375a49a66fd Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158790222) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7114)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services