You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/22 08:33:16 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #6152: travis: Fix failing travis tests on main
Pearl1594 opened a new pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152
### Description
This PR addresses #6115
Prior fix:
```
$ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg -s -a tags=advanced --hypervisor=simulator test/integration/component/test_project_limits.py
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp/MarvinLogs/Mar_22_2022_12_45_24_WIEMY4. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_maxAccountNetworks | Status : EXCEPTION ===
=== TestName: test_maxAccountNetworks | Status : EXCEPTION ===
=== TestName: test_01_project_limits | Status : SUCCESS ===
=== TestName: test_02_project_limits_normal_user | Status : SUCCESS ===
=== TestName: test_03_vm_per_project | Status : SUCCESS ===
=== TestName: test_04_publicip_per_project | Status : FAILED ===
=== TestName: test_05_snapshots_per_project | Status : SUCCESS ===
=== TestName: test_06_volumes_per_project | Status : EXCEPTION ===
=== TestName: test_07_templates_per_project | Status : SUCCESS ===
=== TestName: test_07_templates_per_project | Status : EXCEPTION ===
===final results are now copied to: /tmp/MarvinLogs/test_project_limits_JSZASI===
[12:50:20] pearl@pearl-XPS-15-7590:~/lab/shapeblue/cloudstack$ vi /tmp/MarvinLogs/test_project_limits_JSZASI/results.txt
```
```
$ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg -s -a tags=advanced --hypervisor=simulator test/integration/component/test_resource_limits.py
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp/MarvinLogs/Mar_22_2022_13_09_38_XXJETC. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_maxAccountNetworks | Status : SUCCESS ===
=== TestName: test_01_vm_per_account | Status : SUCCESS ===
=== TestName: test_02_publicip_per_account | Status : FAILED ===
=== TestName: test_03_snapshots_per_account | Status : SUCCESS ===
=== TestName: test_04_volumes_per_account | Status : SUCCESS ===
=== TestName: test_05_templates_per_account | Status : SUCCESS ===
=== TestName: test_01_publicip_per_domain | Status : FAILED ===
=== TestName: test_01_vm_per_domain | Status : SUCCESS ===
=== TestName: test_03_snapshots_per_domain | Status : SUCCESS ===
=== TestName: test_04_volumes_per_domain | Status : SUCCESS ===
=== TestName: test_05_templates_per_domain | Status : SUCCESS ===
===final results are now copied to: /tmp/MarvinLogs/test_resource_limits_4GD1ST===
```
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
```
$ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg -s -a tags=advanced --hypervisor=simulator test/integration/component/test_project_limits.py
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp/MarvinLogs/Mar_22_2022_13_03_09_I9KF2Z. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_maxAccountNetworks | Status : SUCCESS ===
=== TestName: test_01_project_limits | Status : SUCCESS ===
=== TestName: test_02_project_limits_normal_user | Status : SUCCESS ===
=== TestName: test_03_vm_per_project | Status : SUCCESS ===
=== TestName: test_04_publicip_per_project | Status : SUCCESS ===
=== TestName: test_05_snapshots_per_project | Status : SUCCESS ===
=== TestName: test_06_volumes_per_project | Status : SUCCESS ===
=== TestName: test_07_templates_per_project | Status : SUCCESS ===
===final results are now copied to: /tmp/MarvinLogs/test_project_limits_HJ63QW===
```
```
$ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg -s -a tags=advanced --hypervisor=simulator test/integration/component/test_resource_limits.py
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp/MarvinLogs/Mar_22_2022_13_32_35_7B5VRA. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_maxAccountNetworks | Status : SUCCESS ===
=== TestName: test_01_vm_per_account | Status : SUCCESS ===
=== TestName: test_02_publicip_per_account | Status : SUCCESS ===
=== TestName: test_03_snapshots_per_account | Status : SUCCESS ===
=== TestName: test_04_volumes_per_account | Status : SUCCESS ===
=== TestName: test_05_templates_per_account | Status : SUCCESS ===
=== TestName: test_01_publicip_per_domain | Status : SUCCESS ===
=== TestName: test_01_vm_per_domain | Status : SUCCESS ===
=== TestName: test_03_snapshots_per_domain | Status : SUCCESS ===
=== TestName: test_04_volumes_per_domain | Status : SUCCESS ===
=== TestName: test_05_templates_per_domain | Status : SUCCESS ===
===final results are now copied to: /tmp/MarvinLogs/test_resource_limits_X5R7SR===
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#issuecomment-1075087917
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#issuecomment-1076311975
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#issuecomment-1076277361
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#issuecomment-1075079819
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#discussion_r832107987
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -845,7 +835,6 @@ def test_06_volumes_per_project(self):
account=self.account.name,
domainid=self.account.domainid
)
- self.cleanup.append(self.project_1)
Review comment:
It is cleaned @DaanHoogland but at a later stage, as first the networks need to be cleaned up. As the tests failed with such errors - `Can't delete the project yet because it has 1 Network to clean up`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#issuecomment-1076275539
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#discussion_r832092152
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -1020,7 +1026,7 @@ def setUpClass(cls):
def tearDownClass(cls):
try:
#Cleanup resources used
- cleanup_resources(cls.api_client, cls._cleanup)
+ cleanup_resources(cls.api_client, reversed(cls._cleanup))
Review comment:
You can consider `super(TestProjectLimits, cls).tearDownClass()`
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -1040,7 +1046,7 @@ def setUp(self):
def tearDown(self):
try:
#Clean up, terminate the created network offerings
- cleanup_resources(self.apiclient, self.cleanup)
+ cleanup_resources(self.apiclient, reversed(self.cleanup))
Review comment:
You can consider `super(TestProjectLimits, self).tearDown()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#discussion_r832131270
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -845,7 +835,6 @@ def test_06_volumes_per_project(self):
account=self.account.name,
domainid=self.account.domainid
)
- self.cleanup.append(self.project_1)
Review comment:
the errors are because the list isn't processed in reverse. the call to super takes care of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#discussion_r832140683
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -845,7 +835,6 @@ def test_06_volumes_per_project(self):
account=self.account.name,
domainid=self.account.domainid
)
- self.cleanup.append(self.project_1)
Review comment:
Thanks @DaanHoogland , I'll update the tests with @weizhouapache 's suggestion of using super.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#discussion_r832195532
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -736,16 +736,6 @@ def test_04_publicip_per_project(self):
True,
"Check Public IP state is allocated or not"
)
-
- # Exception should be raised for second Public IP
- with self.assertRaises(Exception):
- PublicIPAddress.create(
- self.apiclient,
- zoneid=virtual_machine_1.zoneid,
- services=self.services["server"],
- networkid=network.id,
- projectid=self.project.id
- )
Review comment:
ok, wonder why this assertion is in there than. If it is supposed to succeed, we are fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#discussion_r832100107
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -736,16 +736,6 @@ def test_04_publicip_per_project(self):
True,
"Check Public IP state is allocated or not"
)
-
- # Exception should be raised for second Public IP
- with self.assertRaises(Exception):
- PublicIPAddress.create(
- self.apiclient,
- zoneid=virtual_machine_1.zoneid,
- services=self.services["server"],
- networkid=network.id,
- projectid=self.project.id
- )
Review comment:
aren't those part of the test purpose; that it throws an exception when trying to create a public IP?
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -845,7 +835,6 @@ def test_06_volumes_per_project(self):
account=self.account.name,
domainid=self.account.domainid
)
- self.cleanup.append(self.project_1)
Review comment:
why shouldn't the project be cleaned?
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -872,7 +861,16 @@ def test_06_volumes_per_project(self):
'Running',
"Check VM state is Running or not"
)
+ self.cleanup.append(virtual_machine_1)
+ networks = Network.list(
+ self.apiclient,
+ projectid=self.project_1.id,
+ listall=True
+ )
+ for network in networks:
+ self.cleanup.append(Network(network.__dict__))
+ self.cleanup.append(self.project_1)
Review comment:
it shouldn't be added to cleanup with so much posibilities of exceptions in between.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#discussion_r832105664
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -736,16 +736,6 @@ def test_04_publicip_per_project(self):
True,
"Check Public IP state is allocated or not"
)
-
- # Exception should be raised for second Public IP
- with self.assertRaises(Exception):
- PublicIPAddress.create(
- self.apiclient,
- zoneid=virtual_machine_1.zoneid,
- services=self.services["server"],
- networkid=network.id,
- projectid=self.project.id
- )
Review comment:
it constantly fails with an Assertion Error stating - no exception raised @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6152: travis: Fix failing travis tests on main
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#discussion_r832130161
##########
File path: test/integration/component/test_project_limits.py
##########
@@ -845,7 +835,6 @@ def test_06_volumes_per_project(self):
account=self.account.name,
domainid=self.account.domainid
)
- self.cleanup.append(self.project_1)
Review comment:
it shouldn't be added to the clean list with other statements inbtween. This means exceptions can occur before it is added. It must be added immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org