You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "0yukali0 (via GitHub)" <gi...@apache.org> on 2023/04/11 15:30:45 UTC
[GitHub] [yunikorn-site] 0yukali0 opened a new pull request, #286: [YUNIKORN-1527] Add website build to PR workflow
0yukali0 opened a new pull request, #286:
URL: https://github.com/apache/yunikorn-site/pull/286
### What is this PR for?
A task in workflow run the building image step.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1527
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on pull request #286: [YUNIKORN-1527] Add website build to PR workflow
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #286:
URL: https://github.com/apache/yunikorn-site/pull/286#issuecomment-1504452717
Merged #285, kicked off the checks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] 0yukali0 commented on a diff in pull request #286: [YUNIKORN-1527] Add website build to PR workflow
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on code in PR #286:
URL: https://github.com/apache/yunikorn-site/pull/286#discussion_r1169421774
##########
.github/workflows/pre-commit.yml:
##########
@@ -30,3 +30,5 @@ jobs:
fetch-depth: 2
- name: Check license
run: ./check_license.sh
+ - name: Build the site image
+ run: docker build -t yunikorn/yunikorn-website:2.0.0 . --build-arg NODE_VERSION=16.14
Review Comment:
Understood
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s closed pull request #286: [YUNIKORN-1527] Add website build to PR workflow
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #286: [YUNIKORN-1527] Add website build to PR workflow
URL: https://github.com/apache/yunikorn-site/pull/286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on a diff in pull request #286: [YUNIKORN-1527] Add website build to PR workflow
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #286:
URL: https://github.com/apache/yunikorn-site/pull/286#discussion_r1168980347
##########
.github/workflows/pre-commit.yml:
##########
@@ -30,3 +30,5 @@ jobs:
fetch-depth: 2
- name: Check license
run: ./check_license.sh
+ - name: Build the site image
+ run: docker build -t yunikorn/yunikorn-website:2.0.0 . --build-arg NODE_VERSION=16.14
Review Comment:
We should use the same construct for building as we do in the push build. We read the node version from the `.nvmrc` file. See the push flow lines 34 and 36 on the how and what.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org