You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/07/26 12:17:57 UTC
[GitHub] couchdb-fauxton pull request #753: react port: remove unused code
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/753
react port: remove unused code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton de-jqueryism-typeahead
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/753.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #753
----
commit a278bb98e6cbb8613e1d4be5113c8c35a9ed763e
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-07-26T12:16:44Z
react port: remove unused code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #753: react port: use react-select for database page
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/753
This is awesome. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #753: react port: use react-select for database...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/753#discussion_r72574868
--- Diff: app/addons/databases/stores.js ---
@@ -72,13 +72,19 @@ var DatabasesStore = FauxtonAPI.Store.extend({
},
getDatabaseNames: function () {
- if (this._backboneCollection) {
- return _.map(this._backboneCollection.toJSON(), function (item, key) {
- return item.name;
- });
- } else {
+ if (!this._backboneCollection || !this._backboneCollection.length) {
--- End diff --
It would be kind of nice to remove the backbone collection as well and just have a json list of databases. But maybe we do that in the next step.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #753: react port: use react-select for database page
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/753
oh it was
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #753: react port: use react-select for database...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/753#discussion_r74586359
--- Diff: app/addons/databases/stores.js ---
@@ -72,13 +72,19 @@ var DatabasesStore = FauxtonAPI.Store.extend({
},
getDatabaseNames: function () {
- if (this._backboneCollection) {
- return _.map(this._backboneCollection.toJSON(), function (item, key) {
- return item.name;
- });
- } else {
+ if (!this._backboneCollection || !this._backboneCollection.length) {
--- End diff --
yes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #753: react port: use react-select for database...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/753
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #753: react port: use react-select for database page
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/753
@robertkowalski I've merged this PR. You can close this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---