[GitHub] tvielgouarin edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer

[GitBox <gi...@apache.org>]

tvielgouarin edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer
URL: https://github.com/apache/flink/pull/7405#issuecomment-456391275
 
 
   hi @pnowojski , @yanghua ,
   I come from @cjolif 's team and I am currently working on the implementation of the Migration test in order to accelerate the merge of this PR. I came here with several questions in mind. I do understand that it needs to implement:
   
   - migration tests of `FlinkKafkaProducer011` between Flink versions
   - migration tests of universal `FlinkKafkaProducer` between Flink versions
   - migration test from `FlinkKafkaProducer011` to universal `FlinkKafkaProducer`
   
   However what should be the validation conditions ( producerConfig stay the same .... (?) ) 
   
   Furthermore I've worked on a simple implementation of Migration test for `FlinkKafkaProducer`: 
   https://github.com/tvielgouarin/flink/commit/973756430c226a0cd5011fedc1eab1345a27cc2a
   
   Most of the time the test fail with `The producer attempted to use a producer id which is not currently assigned to its transactional id`. I'm not sure, but I guess it's because there is a different KafkaServer's instance between the snapshot version and the test, and the transactional Id assignations are lost (?). If so, do you have and idea of the the best work around ? 
   
   Anyway if you can have a look at what I've done and criticize it, it would be much appreciated. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services