You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Marcel Reutegger (Jira)" <ji...@apache.org> on 2022/08/05 15:31:00 UTC

[jira] [Commented] (OAK-9826) Flaky test: DataStoreBlobStoreStatsTest

    [ https://issues.apache.org/jira/browse/OAK-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575910#comment-17575910 ] 

Marcel Reutegger commented on OAK-9826:
---------------------------------------

The timing requirements may be a bit too aggressive with this test. Statistics are updated once per second and the test waits up to one second for the expected value. Depending on the system clock resolution and timing of the scheduled tasks, this may not be enough.

Proposed PR https://github.com/apache/jackrabbit-oak/pull/655 gives the assertion 1.5 seconds to see the expected value.

> Flaky test: DataStoreBlobStoreStatsTest
> ---------------------------------------
>
>                 Key: OAK-9826
>                 URL: https://issues.apache.org/jira/browse/OAK-9826
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: blob-plugins
>    Affects Versions: 1.44.0
>            Reporter: Joerg Hoh
>            Assignee: Marcel Reutegger
>            Priority: Major
>
> [Failed integration test|https://ci-builds.apache.org/job/Jackrabbit/job/oak-trunk-pr/job/PR-605/4/testReport/junit/org.apache.jackrabbit.oak.plugins.blob.datastore/DataStoreBlobStoreStatsTest/oak_blob_plugins___testDSBSGetAllMetaRecsErrorStats/?cloudbees-analytics-link=scm-reporting%2Ftests%2Ffailed] 
> oak-blob-plugins / org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStoreStatsTest.testDSBSGetAllMetaRecsErrorStats (branch: trunk)
> {noformat}
> java.lang.AssertionError: expected:<1> but was:<0>
> 	at org.junit.Assert.fail(Assert.java:89)
> 	at org.junit.Assert.failNotEquals(Assert.java:835)
> 	at org.junit.Assert.assertEquals(Assert.java:647)
> 	at org.junit.Assert.assertEquals(Assert.java:633)
> 	at org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStoreStatsTest.testDSBSGetAllMetaRecsErrorStats(DataStoreBlobStoreStatsTest.java:711)
> {noformat}
> See also other test failures for the same class reported in OAK-8897 and OAK-8952.
> {noformat}
> [ERROR] testDSBSReadBlobStats(org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStoreStatsTest)  Time elapsed: 1.047 s  <<< FAILURE!
> java.lang.AssertionError: expected:<2> but was:<1>
>         at org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStoreStatsTest.testDSBSReadBlobStats(DataStoreBlobStoreStatsTest.java:99)
> {noformat}
> {noformat}
> [ERROR] testDSBSGetRecordErrorStats(org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStoreStatsTest)  Time elapsed: 1.093 s  <<< FAILURE!
> java.lang.AssertionError: expected:<1> but was:<0>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:834)
> 	at org.junit.Assert.assertEquals(Assert.java:645)
> 	at org.junit.Assert.assertEquals(Assert.java:631)
> 	at org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStoreStatsTest.testDSBSGetRecordErrorStats(DataStoreBlobStoreStatsTest.java:306)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)