You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/06 12:23:40 UTC
[GitHub] [spark] wangyum opened a new pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
wangyum opened a new pull request #31067:
URL: https://github.com/apache/spark/pull/31067
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31067:
URL: https://github.com/apache/spark/pull/31067
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755325062
**[Test build #133749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133749/testReport)** for PR 31067 at commit [`fbd837d`](https://github.com/apache/spark/commit/fbd837d526fcdb89cdab528f1f0a7bcf47b0b434).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755454295
**[Test build #133740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133740/testReport)** for PR 31067 at commit [`3ceffeb`](https://github.com/apache/spark/commit/3ceffeb42a69365ec811cf09119f995eabe68954).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31067:
URL: https://github.com/apache/spark/pull/31067#discussion_r552562270
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalsInPredicate.scala
##########
@@ -64,12 +64,8 @@ object SimplifyConditionalsInPredicate extends Rule[LogicalPlan] {
And(cond, trueValue)
case CaseWhen(Seq((cond, trueValue)), Some(TrueLiteral)) =>
Or(Not(cond), trueValue)
- case CaseWhen(Seq((_, FalseLiteral)), Some(FalseLiteral) | None) =>
- FalseLiteral
case CaseWhen(Seq((cond, FalseLiteral)), Some(elseValue)) =>
And(Not(cond), elseValue)
- case CaseWhen(Seq((cond, TrueLiteral)), Some(FalseLiteral) | None) =>
- cond
Review comment:
This case has handled by https://github.com/apache/spark/blob/3ceffeb42a69365ec811cf09119f995eabe68954/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalsInPredicate.scala#L62-L64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31067:
URL: https://github.com/apache/spark/pull/31067#discussion_r552561079
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalsInPredicateSuite.scala
##########
@@ -158,6 +158,15 @@ class SimplifyConditionalsInPredicateSuite extends PlanTest {
testProjection(originalCond, expectedExpr = originalCond)
}
+ test("CASE WHEN non-deterministic-cond THEN false END") {
+ val originalCond =
+ CaseWhen(Seq((UnresolvedAttribute("i") > Rand(0), FalseLiteral)))
+ val expectedCond = And(UnresolvedAttribute("i") > Rand(0), FalseLiteral)
+ // nondeterministic expressions are only allowed in Project, Filter, Aggregate or Window,
+ testFilter(originalCond, expectedCond = FalseLiteral)
Review comment:
`expectedCond = FalseLiteral` cause by https://github.com/apache/spark/blob/26d8df300a1a57e220b1a0f9814795f68101f28b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala#L295-L298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755465230
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133740/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755325062
**[Test build #133749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133749/testReport)** for PR 31067 at commit [`fbd837d`](https://github.com/apache/spark/commit/fbd837d526fcdb89cdab528f1f0a7bcf47b0b434).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755353209
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38328/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31067:
URL: https://github.com/apache/spark/pull/31067#discussion_r552630004
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalsInPredicate.scala
##########
@@ -64,12 +64,8 @@ object SimplifyConditionalsInPredicate extends Rule[LogicalPlan] {
And(cond, trueValue)
case CaseWhen(Seq((cond, trueValue)), Some(TrueLiteral)) =>
Or(Not(cond), trueValue)
- case CaseWhen(Seq((_, FalseLiteral)), Some(FalseLiteral) | None) =>
Review comment:
can we update the classdoc of this rule?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755465230
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133740/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31067:
URL: https://github.com/apache/spark/pull/31067#discussion_r552562156
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalsInPredicate.scala
##########
@@ -64,12 +64,8 @@ object SimplifyConditionalsInPredicate extends Rule[LogicalPlan] {
And(cond, trueValue)
case CaseWhen(Seq((cond, trueValue)), Some(TrueLiteral)) =>
Or(Not(cond), trueValue)
- case CaseWhen(Seq((_, FalseLiteral)), Some(FalseLiteral) | None) =>
- FalseLiteral
case CaseWhen(Seq((cond, FalseLiteral)), Some(elseValue)) =>
Review comment:
This case has handled by https://github.com/apache/spark/blob/3ceffeb42a69365ec811cf09119f995eabe68954/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalsInPredicate.scala#L62-L64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755334064
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38328/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755289304
**[Test build #133740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133740/testReport)** for PR 31067 at commit [`3ceffeb`](https://github.com/apache/spark/commit/3ceffeb42a69365ec811cf09119f995eabe68954).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755353209
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38328/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755374064
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38337/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755289304
**[Test build #133740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133740/testReport)** for PR 31067 at commit [`3ceffeb`](https://github.com/apache/spark/commit/3ceffeb42a69365ec811cf09119f995eabe68954).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755317055
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38328/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755369160
**[Test build #133749 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133749/testReport)** for PR 31067 at commit [`fbd837d`](https://github.com/apache/spark/commit/fbd837d526fcdb89cdab528f1f0a7bcf47b0b434).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755354249
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38337/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755391398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755893633
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31067: [SPARK-33861][SQL][FOLLOWUP] Simplify conditional in predicate should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31067:
URL: https://github.com/apache/spark/pull/31067#issuecomment-755391395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org