You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/03/02 16:15:40 UTC

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #921: various small fixes (mesh, host, controller)

andrzej-kaczmarek commented on a change in pull request #921:
URL: https://github.com/apache/mynewt-nimble/pull/921#discussion_r585704247



##########
File path: nimble/controller/src/ble_ll_scan.c
##########
@@ -3081,7 +3081,7 @@ ble_ll_scan_rx_pkt_in_on_aux(uint8_t pdu_type, struct os_mbuf *om,
     if (!BLE_MBUF_HDR_CRC_OK(hdr) ||
         BLE_MBUF_HDR_IGNORED(hdr) ||
         BLE_MBUF_HDR_AUX_INVALID(hdr) ||
-        (aux_data->flags_ll & BLE_LL_AUX_FLAG_SCAN_ERROR) ||
+        (aux_data && aux_data->flags_ll & BLE_LL_AUX_FLAG_SCAN_ERROR) ||

Review comment:
       aux_data cannot be null here, see comment at line 3075.
   also please do not mix fixes for LL and host in single PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org