[GitHub] [iceberg] Fokko commented on a diff in pull request #4728: Python: Remove mypy error

[GitBox <gi...@apache.org>]

Fokko commented on code in PR #4728:
URL: https://github.com/apache/iceberg/pull/4728#discussion_r867723268


##########
python/src/iceberg/transforms.py:
##########
@@ -120,9 +120,6 @@ def hash(self, value: S) -> int:
         raise NotImplementedError()
 
     def apply(self, value: S) -> Optional[int]:
-        if value is None:

Review Comment:
   Okay, looking at the tests, we _might_ expect a `None` there. I've changed the code the other way around.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org