[GitHub] [accumulo] keith-turner commented on pull request #3230: Stop upgrade process if invalid table locks are found.

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on PR #3230:
URL: https://github.com/apache/accumulo/pull/3230#issuecomment-1538856316

   > The pre-upgrade stage was added to support code / checks that are likely independent of a specific version.
   
   Yeah if the data is the same across the two versions then we do not need to push anything to the Upgrader.  I was thinking we had changed how lock data is stored in ZK.  That may be between 2.0 and 2.1 though, not for 2.1 to 3.0.
   
   > The ability to communicate with a tserver seems to also fit within this category. Before anything happens that is dependent on version, this check would establish a baseline of "at least I can talk to all of the registered tservers" before any version dependent code would have a chance to run.
   
    We could also possibly add something to ServiceLockData that could be used to check if a lock on ZK is associated with something running an older code version.  That could be done in addition to or instead of attempting to make a RPC.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org