You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/22 17:35:07 UTC

[GitHub] [maven] rfscholte commented on a change in pull request #288: [MNG-6773] Slow extension key creation in DefaultExtensionRealmCache under lock

rfscholte commented on a change in pull request #288:
URL: https://github.com/apache/maven/pull/288#discussion_r429372782



##########
File path: maven-core/src/main/java/org/apache/maven/plugin/DefaultExtensionRealmCache.java
##########
@@ -41,41 +42,97 @@
 public class DefaultExtensionRealmCache
     implements ExtensionRealmCache, Disposable
 {
+
     /**
-     * CacheKey
+     * Control flag to restore legacy filesystem behaviour in case issues.
      */
-    protected static class CacheKey
+    private final boolean useFsKey = Boolean.getBoolean( "maven.extensions.fskey" );

Review comment:
       I don't see the need for this. It will only make it harder to maintain.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org