You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/26 19:32:25 UTC

[GitHub] mmuru commented on issue #5387: Visualization Unicode bug fix

mmuru commented on issue #5387: Visualization Unicode bug fix
URL: https://github.com/apache/incubator-superset/pull/5387#issuecomment-408210094
 
 
   @JamshedRahman:  Please, can you add the following change into your PR. The issue #5479 has more details
   ``
   Line 753 in superset/models/core.py 
   sqls = [str(s).strip().strip(';') for s in sqlparse.parse(sql)] 
   should change to 
   sqls = [six.text_type(s).strip().strip(';') for s in sqlparse.parse(sql)]
   ``
   I tested this change and worked. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org