You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Eric Hubert (JIRA)" <ji...@apache.org> on 2009/04/26 23:15:30 UTC
[jira] Created: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Possibility to put server in maintenance mode and reload synapse configuration via JMX
--------------------------------------------------------------------------------------
Key: SYNAPSE-537
URL: https://issues.apache.org/jira/browse/SYNAPSE-537
Project: Synapse
Issue Type: New Feature
Components: Core
Affects Versions: NIGHTLY
Reporter: Eric Hubert
Fix For: 1.3
Attachments: ServerManager.patch
Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
So what about moving the following classes:
Axis2SynapseController
JmxAdapter
ServerConfigurationInformation
ServerConfigurationInformationFactory
ServerContextInformation
ServerManager
ServerState
ServerStateDetectionStrategy
SynapseController
SynapseControllerFactory
SynapseServer
to
synapse.server
and
ServerManagerView
ServerManagerViewMBean
to
synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702968#action_12702968 ]
Asankha C. Perera commented on SYNAPSE-537:
-------------------------------------------
Hi Eric
I am still having problems importing your patch :(... is it possible to try it from a Linux machine? BTW, the related issue is SYNAPSE-239 as I remember..
cheers
asankha
> Possibility to put server in maintenance mode and reload synapse configuration via JMX
> --------------------------------------------------------------------------------------
>
> Key: SYNAPSE-537
> URL: https://issues.apache.org/jira/browse/SYNAPSE-537
> Project: Synapse
> Issue Type: New Feature
> Components: Core
> Affects Versions: NIGHTLY
> Reporter: Eric Hubert
> Fix For: 1.3
>
> Attachments: ServerManager.patch
>
>
> Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
> All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
> While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
> So what about moving the following classes:
> Axis2SynapseController
> JmxAdapter
> ServerConfigurationInformation
> ServerConfigurationInformationFactory
> ServerContextInformation
> ServerManager
> ServerState
> ServerStateDetectionStrategy
> SynapseController
> SynapseControllerFactory
> SynapseServer
> to
> synapse.server
> and
> ServerManagerView
> ServerManagerViewMBean
> to
> synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Posted by "Eric Hubert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702988#action_12702988 ]
Eric Hubert commented on SYNAPSE-537:
-------------------------------------
Sorry for this! I checked out trunk and applied the patch, and run the build without problems. I'll try to setup svn on some Linux box and will test with patch -p0 -i before resubmitting a new patch.
> Possibility to put server in maintenance mode and reload synapse configuration via JMX
> --------------------------------------------------------------------------------------
>
> Key: SYNAPSE-537
> URL: https://issues.apache.org/jira/browse/SYNAPSE-537
> Project: Synapse
> Issue Type: New Feature
> Components: Core
> Affects Versions: NIGHTLY
> Reporter: Eric Hubert
> Fix For: 1.3
>
> Attachments: ServerManager.patch
>
>
> Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
> All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
> While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
> So what about moving the following classes:
> Axis2SynapseController
> JmxAdapter
> ServerConfigurationInformation
> ServerConfigurationInformationFactory
> ServerContextInformation
> ServerManager
> ServerState
> ServerStateDetectionStrategy
> SynapseController
> SynapseControllerFactory
> SynapseServer
> to
> synapse.server
> and
> ServerManagerView
> ServerManagerViewMBean
> to
> synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Assigned: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruwan Linton reassigned SYNAPSE-537:
------------------------------------
Assignee: Ruwan Linton
> Possibility to put server in maintenance mode and reload synapse configuration via JMX
> --------------------------------------------------------------------------------------
>
> Key: SYNAPSE-537
> URL: https://issues.apache.org/jira/browse/SYNAPSE-537
> Project: Synapse
> Issue Type: New Feature
> Components: Core
> Affects Versions: NIGHTLY
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Fix For: 1.3
>
> Attachments: ServerManager.patch
>
>
> Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
> All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
> While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
> So what about moving the following classes:
> Axis2SynapseController
> JmxAdapter
> ServerConfigurationInformation
> ServerConfigurationInformationFactory
> ServerContextInformation
> ServerManager
> ServerState
> ServerStateDetectionStrategy
> SynapseController
> SynapseControllerFactory
> SynapseServer
> to
> synapse.server
> and
> ServerManagerView
> ServerManagerViewMBean
> to
> synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Resolved: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruwan Linton resolved SYNAPSE-537.
----------------------------------
Resolution: Fixed
Committed the patch with small modifications
> Possibility to put server in maintenance mode and reload synapse configuration via JMX
> --------------------------------------------------------------------------------------
>
> Key: SYNAPSE-537
> URL: https://issues.apache.org/jira/browse/SYNAPSE-537
> Project: Synapse
> Issue Type: New Feature
> Components: Core
> Affects Versions: NIGHTLY
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Fix For: 1.3
>
> Attachments: ServerManager.patch
>
>
> Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
> All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
> While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
> So what about moving the following classes:
> Axis2SynapseController
> JmxAdapter
> ServerConfigurationInformation
> ServerConfigurationInformationFactory
> ServerContextInformation
> ServerManager
> ServerState
> ServerStateDetectionStrategy
> SynapseController
> SynapseControllerFactory
> SynapseServer
> to
> synapse.server
> and
> ServerManagerView
> ServerManagerViewMBean
> to
> synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705049#action_12705049 ]
Ruwan Linton commented on SYNAPSE-537:
--------------------------------------
With few other changes I have committed the patch. I must say this is a great improvement and this also fixes the shutdown issue.
Thanks a lot Eric.
Ruwan
> Possibility to put server in maintenance mode and reload synapse configuration via JMX
> --------------------------------------------------------------------------------------
>
> Key: SYNAPSE-537
> URL: https://issues.apache.org/jira/browse/SYNAPSE-537
> Project: Synapse
> Issue Type: New Feature
> Components: Core
> Affects Versions: NIGHTLY
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Fix For: 1.3
>
> Attachments: ServerManager.patch
>
>
> Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
> All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
> While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
> So what about moving the following classes:
> Axis2SynapseController
> JmxAdapter
> ServerConfigurationInformation
> ServerConfigurationInformationFactory
> ServerContextInformation
> ServerManager
> ServerState
> ServerStateDetectionStrategy
> SynapseController
> SynapseControllerFactory
> SynapseServer
> to
> synapse.server
> and
> ServerManagerView
> ServerManagerViewMBean
> to
> synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Posted by "Eric Hubert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705015#action_12705015 ]
Eric Hubert commented on SYNAPSE-537:
-------------------------------------
Ruwan, you are correct in all of the above.
Sorry for a), I need to tweak my settings of my specific Synapse workspace regarding line length. I'm used to 120 chars, so this slipped through.
Regarding b) I changed the class and forgot to remove the private constructor. It is indeed now useless.
Same applies to the method stopGraceful. I removed it from the interface, but forgot to remove it from the implementation. I first started to delegate the whole functionality to the controller, but realized, that statemanagement ist in ServerManager. So I splitted the operations of switching to maintanence mode and stopping the server and combine it only in the ServerManager. So you are right this method can and should safely be removed.
Thanks for the review so far!
> Possibility to put server in maintenance mode and reload synapse configuration via JMX
> --------------------------------------------------------------------------------------
>
> Key: SYNAPSE-537
> URL: https://issues.apache.org/jira/browse/SYNAPSE-537
> Project: Synapse
> Issue Type: New Feature
> Components: Core
> Affects Versions: NIGHTLY
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Fix For: 1.3
>
> Attachments: ServerManager.patch
>
>
> Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
> All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
> While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
> So what about moving the following classes:
> Axis2SynapseController
> JmxAdapter
> ServerConfigurationInformation
> ServerConfigurationInformationFactory
> ServerContextInformation
> ServerManager
> ServerState
> ServerStateDetectionStrategy
> SynapseController
> SynapseControllerFactory
> SynapseServer
> to
> synapse.server
> and
> ServerManagerView
> ServerManagerViewMBean
> to
> synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Updated: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Posted by "Eric Hubert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hubert updated SYNAPSE-537:
--------------------------------
Attachment: (was: ServerManager.patch)
> Possibility to put server in maintenance mode and reload synapse configuration via JMX
> --------------------------------------------------------------------------------------
>
> Key: SYNAPSE-537
> URL: https://issues.apache.org/jira/browse/SYNAPSE-537
> Project: Synapse
> Issue Type: New Feature
> Components: Core
> Affects Versions: NIGHTLY
> Reporter: Eric Hubert
> Fix For: 1.3
>
>
> Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
> All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
> While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
> So what about moving the following classes:
> Axis2SynapseController
> JmxAdapter
> ServerConfigurationInformation
> ServerConfigurationInformationFactory
> ServerContextInformation
> ServerManager
> ServerState
> ServerStateDetectionStrategy
> SynapseController
> SynapseControllerFactory
> SynapseServer
> to
> synapse.server
> and
> ServerManagerView
> ServerManagerViewMBean
> to
> synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Updated: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Posted by "Eric Hubert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hubert updated SYNAPSE-537:
--------------------------------
Attachment: ServerManager.patch
> Possibility to put server in maintenance mode and reload synapse configuration via JMX
> --------------------------------------------------------------------------------------
>
> Key: SYNAPSE-537
> URL: https://issues.apache.org/jira/browse/SYNAPSE-537
> Project: Synapse
> Issue Type: New Feature
> Components: Core
> Affects Versions: NIGHTLY
> Reporter: Eric Hubert
> Fix For: 1.3
>
> Attachments: ServerManager.patch
>
>
> Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
> All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
> While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
> So what about moving the following classes:
> Axis2SynapseController
> JmxAdapter
> ServerConfigurationInformation
> ServerConfigurationInformationFactory
> ServerContextInformation
> ServerManager
> ServerState
> ServerStateDetectionStrategy
> SynapseController
> SynapseControllerFactory
> SynapseServer
> to
> synapse.server
> and
> ServerManagerView
> ServerManagerViewMBean
> to
> synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
Setting line endings for patches.. / SVN
Posted by "Asankha C. Perera" <as...@apache.org>.
Hi Eric
> PS:
> While having a closer look at the diffs I noticed different line endings in the files. Some classes are using Windows line endings, others are using Unix line endings. Maybe it would make sense to use a unified format across a files.
>
http://cwiki.apache.org/synapse/developer-guidelines.html
Once you set your svn config as mentioned in that link, the line endings
should be correctly set. i.e. when someone checks out a .java file into
a Windows machine, it will use the native line ending used in Windows,
and the same file checked out into Linux would be in the native Linux
line ending format. We keep almost all files at native, except .bat and
.sh files to the respective line endings they require
cheers
asankha
--
Asankha C. Perera
AdroitLogic, http://adroitlogic.org
http://esbmagic.blogspot.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Updated: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Posted by "Eric Hubert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hubert updated SYNAPSE-537:
--------------------------------
Attachment: ServerManager.patch
Ok, this one is created and tested on a Linux box.
PS:
While having a closer look at the diffs I noticed different line endings in the files. Some classes are using Windows line endings, others are using Unix line endings. Maybe it would make sense to use a unified format across a files.
> Possibility to put server in maintenance mode and reload synapse configuration via JMX
> --------------------------------------------------------------------------------------
>
> Key: SYNAPSE-537
> URL: https://issues.apache.org/jira/browse/SYNAPSE-537
> Project: Synapse
> Issue Type: New Feature
> Components: Core
> Affects Versions: NIGHTLY
> Reporter: Eric Hubert
> Fix For: 1.3
>
> Attachments: ServerManager.patch
>
>
> Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
> All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
> While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
> So what about moving the following classes:
> Axis2SynapseController
> JmxAdapter
> ServerConfigurationInformation
> ServerConfigurationInformationFactory
> ServerContextInformation
> ServerManager
> ServerState
> ServerStateDetectionStrategy
> SynapseController
> SynapseControllerFactory
> SynapseServer
> to
> synapse.server
> and
> ServerManagerView
> ServerManagerViewMBean
> to
> synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-537) Possibility to put server in
maintenance mode and reload synapse configuration via JMX
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705010#action_12705010 ]
Ruwan Linton commented on SYNAPSE-537:
--------------------------------------
Few comments while I am reviewing the patch,
* Some of the classes has exceeded the 100 character limit :-)
* Axis2TransportHelper class has a private constructor, since it has a public constructor with one argument AFAIK, the private constructor is of no use
* Axis2SynapseController has an unused method called stopGracefully
I am still reviewing the patch, please correct me if I am wrong in the 3rd comment. I already fixed the first two.
Thanks,
Ruwan
> Possibility to put server in maintenance mode and reload synapse configuration via JMX
> --------------------------------------------------------------------------------------
>
> Key: SYNAPSE-537
> URL: https://issues.apache.org/jira/browse/SYNAPSE-537
> Project: Synapse
> Issue Type: New Feature
> Components: Core
> Affects Versions: NIGHTLY
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Fix For: 1.3
>
> Attachments: ServerManager.patch
>
>
> Unfortunately I did not find the old issue we had for this, so I created a new one. The provided patch extends the existing server states with a maintenance state. While entering the maintenance mode all transports supporting a pause operation are paused. So no new requests will be accepted. Once all requests in progress are finished the server can be safely restarted to load a changed configuration. If running in a clustered environment behind a loadbalancer this allows dynamic configuration updates.
> All server state changes can be triggered via JMX using an extended ServerManagerMBean which can also be used to query the current server state.
> While working on this patch I thought about moving some of the classes in the synapse top level package to a new server subpackage. I actually did not perform this change to ease the review, but I still think it would be a good idea.
> So what about moving the following classes:
> Axis2SynapseController
> JmxAdapter
> ServerConfigurationInformation
> ServerConfigurationInformationFactory
> ServerContextInformation
> ServerManager
> ServerState
> ServerStateDetectionStrategy
> SynapseController
> SynapseControllerFactory
> SynapseServer
> to
> synapse.server
> and
> ServerManagerView
> ServerManagerViewMBean
> to
> synapse.server.mbean (maybe also renaming them to ServerManagerControl and ServerManagerControlMBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org