You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2024/03/24 02:08:35 UTC

[PR] ci: bump license header formatter [opendal]

tisonkun opened a new pull request, #4390:
URL: https://github.com/apache/opendal/pull/4390

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: bump license header formatter [opendal]

Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE merged PR #4390:
URL: https://github.com/apache/opendal/pull/4390


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: bump license header formatter [opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #4390:
URL: https://github.com/apache/opendal/pull/4390#discussion_r1536737760


##########
bindings/go/go.mod:
##########
@@ -1,3 +1,22 @@
+/*

Review Comment:
   Fixed now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: bump license header formatter [opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #4390:
URL: https://github.com/apache/opendal/pull/4390#discussion_r1536722547


##########
bindings/go/go.mod:
##########
@@ -1,3 +1,22 @@
+/*

Review Comment:
   It's discussed on general@incubator.a.o that go.mod is like Maven's pom.xml and deserves a license header.
   
   Anyway, it's added in the new version on request (https://github.com/korandoru/hawkeye/commit/d5c0bcfcf96ced5fee7a00949893add762e4787c) 🤣. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: bump license header formatter [opendal]

Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on code in PR #4390:
URL: https://github.com/apache/opendal/pull/4390#discussion_r1536732256


##########
bindings/go/go.mod:
##########
@@ -1,3 +1,22 @@
+/*

Review Comment:
   `mod files must use // comments` :sob: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: bump license header formatter [opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #4390:
URL: https://github.com/apache/opendal/pull/4390#discussion_r1536733646


##########
bindings/go/go.mod:
##########
@@ -1,3 +1,22 @@
+/*

Review Comment:
   OK. Let me fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org