You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Florian Holeczek (JIRA)" <ji...@apache.org> on 2008/08/19 09:37:44 UTC
[jira] Created: (JSPWIKI-350) comment isn't saved completely
comment isn't saved completely
------------------------------
Key: JSPWIKI-350
URL: https://issues.apache.org/jira/browse/JSPWIKI-350
Project: JSPWiki
Issue Type: Bug
Affects Versions: 2.7.x
Environment: v2.7.0-alpha-21
Reporter: Florian Holeczek
Priority: Minor
When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-350) page comment completely does not
work
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623817#action_12623817 ]
Dirk Frederickx commented on JSPWIKI-350:
-----------------------------------------
Finally seen the issue, which is a side effect of the section-editing. (it's only happening when setion-editing user-pref is off)
Will fix in the next commit.
dirk
> page comment completely does not work
> -------------------------------------
>
> Key: JSPWIKI-350
> URL: https://issues.apache.org/jira/browse/JSPWIKI-350
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.7.x
> Environment: v2.7.0-alpha-21
> Reporter: Florian Holeczek
> Fix For: 2.8
>
>
> When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-350) page comment completely does not
work
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623793#action_12623793 ]
Janne Jalkanen commented on JSPWIKI-350:
----------------------------------------
Disabling editor javascript functionality by commenting out
<code>
//window.addEvent('load', EditTools.onPageLoad.bind(EditTools) ); //edit only
</code>
Seems to fix commenting as well.
> page comment completely does not work
> -------------------------------------
>
> Key: JSPWIKI-350
> URL: https://issues.apache.org/jira/browse/JSPWIKI-350
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.7.x
> Environment: v2.7.0-alpha-21
> Reporter: Florian Holeczek
> Fix For: 2.8
>
>
> When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-350) page comment completely does not
work
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623716#action_12623716 ]
Florian Holeczek commented on JSPWIKI-350:
------------------------------------------
Harry - I think the current sandbox instance has just run into the error I've described on the list under "weird access rights issue"... try deleting these comments or - in general - editing pages. The pages seem to be saved, but in fact nothing has changed.
> page comment completely does not work
> -------------------------------------
>
> Key: JSPWIKI-350
> URL: https://issues.apache.org/jira/browse/JSPWIKI-350
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.7.x
> Environment: v2.7.0-alpha-21
> Reporter: Florian Holeczek
>
> When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-350) page comment completely does not
work
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623787#action_12623787 ]
Janne Jalkanen commented on JSPWIKI-350:
----------------------------------------
Um. Half of the comments on sandbox don't have content, including your own.
The original Comment.jsp did not have a changenote, but the editor seems to have sprung it. It should either be removed or the changenote should be added...
> page comment completely does not work
> -------------------------------------
>
> Key: JSPWIKI-350
> URL: https://issues.apache.org/jira/browse/JSPWIKI-350
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.7.x
> Environment: v2.7.0-alpha-21
> Reporter: Florian Holeczek
> Fix For: 2.8
>
>
> When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-350) page comment completely does not
work
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623813#action_12623813 ]
Dirk Frederickx commented on JSPWIKI-350:
-----------------------------------------
Things to fix :
-- the change-note box should only be present with the RequestContext==edit (impact plain.jsp)
-- the section-editing functionality should only be active with the RequestContext==edit (impact jpswiki-edit.js)
-- need to localize the "Comment by ..." string in Comment.jsp (but probably some other dead code needs to be removed as well)
dirk
> page comment completely does not work
> -------------------------------------
>
> Key: JSPWIKI-350
> URL: https://issues.apache.org/jira/browse/JSPWIKI-350
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.7.x
> Environment: v2.7.0-alpha-21
> Reporter: Florian Holeczek
> Fix For: 2.8
>
>
> When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-350) page comment completely does not work
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen updated JSPWIKI-350:
-----------------------------------
Fix Version/s: 2.8
Confirmed, commenting does not work at all. Must fix for 2.8.
> page comment completely does not work
> -------------------------------------
>
> Key: JSPWIKI-350
> URL: https://issues.apache.org/jira/browse/JSPWIKI-350
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.7.x
> Environment: v2.7.0-alpha-21
> Reporter: Florian Holeczek
> Fix For: 2.8
>
>
> When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-350) page comment completely does not
work
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623792#action_12623792 ]
Dirk Frederickx commented on JSPWIKI-350:
-----------------------------------------
Janne,
I added one comment with 'comment-text' which is ok.
But I also added one comment without 'comment-text' which shows indeed an 'empty' comment.
May be the latter case (empty comment) should not be allowed by Comment.jsp : if no comment-body-text is entered, then no comment/signature should be added, cause it is confusing.
The current handling of the changenote in Comment.jsp looks strange to me, cause it overwrites the attribute with a fixed text and doesn't handle the received changenote attribute at all.
dirk
> page comment completely does not work
> -------------------------------------
>
> Key: JSPWIKI-350
> URL: https://issues.apache.org/jira/browse/JSPWIKI-350
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.7.x
> Environment: v2.7.0-alpha-21
> Reporter: Florian Holeczek
> Fix For: 2.8
>
>
> When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-350) page comment completely does not work
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske updated JSPWIKI-350:
---------------------------------
Priority: Major (was: Minor)
Summary: page comment completely does not work (was: comment isn't saved completely)
What I see when commenting on a page is that at the end of the page, only a horizontal line (----) is added and your signature, not the text you entered.
The change note you enter is also ignored, and replaced by "Comment by DirtyHarry".
So it looks like Page Comments don't work at all.
I just also tested on the Sandbox (v2.7.0-alpha-13 at the moment).
> page comment completely does not work
> -------------------------------------
>
> Key: JSPWIKI-350
> URL: https://issues.apache.org/jira/browse/JSPWIKI-350
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.7.x
> Environment: v2.7.0-alpha-21
> Reporter: Florian Holeczek
>
> When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-350) page comment completely does not
work
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dirk Frederickx resolved JSPWIKI-350.
-------------------------------------
Resolution: Fixed
Resolved in v2.7.0-alpha-25. Please check.
> page comment completely does not work
> -------------------------------------
>
> Key: JSPWIKI-350
> URL: https://issues.apache.org/jira/browse/JSPWIKI-350
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.7.x
> Environment: v2.7.0-alpha-21
> Reporter: Florian Holeczek
> Assignee: Dirk Frederickx
> Fix For: 2.8
>
>
> When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-350) page comment completely does not
work
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623782#action_12623782 ]
Dirk Frederickx commented on JSPWIKI-350:
-----------------------------------------
Mmm, seems ok to me.
Comment text is correctly appended to the page, as well as the signature.
The Change-note should probably be suppressed from the comment page, cause jspwiki saves a standard change-note "Comment by ...."
This text is also not localised. (see top-level Comment.jsp with some funny handling of the changenote parameter)
dirk
> page comment completely does not work
> -------------------------------------
>
> Key: JSPWIKI-350
> URL: https://issues.apache.org/jira/browse/JSPWIKI-350
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.7.x
> Environment: v2.7.0-alpha-21
> Reporter: Florian Holeczek
> Fix For: 2.8
>
>
> When adding a comment, the comment for the comment isn't saved. Instead, only a standard comment for the comment is saved ("Comment By ...").
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.