You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/01/18 22:23:21 UTC
Review Request 42471: Multiple Disk: Adjusted resource arithmetic for
'DiskInfo.Source'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-4380
https://issues.apache.org/jira/browse/MESOS-4380
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
include/mesos/v1/values.hpp 03a19ee44b3d7f801f7ca2a61f1d42d51e0c144b
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/42471/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/#review115324
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 20, 2016, 2:29 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42471/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 2:29 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4380
> https://issues.apache.org/jira/browse/MESOS-4380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
> include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/#review115987
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 23, 2016, 10:47 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42471/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2016, 10:47 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4380
> https://issues.apache.org/jira/browse/MESOS-4380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
> include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/
-----------------------------------------------------------
(Updated Jan. 23, 2016, 10:47 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
Fixed subtractable
Bugs: MESOS-4380
https://issues.apache.org/jira/browse/MESOS-4380
Repository: mesos
Description
-------
Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
Diffs (updated)
-----
include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/42471/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 22, 2016, 5:03 p.m., Jie Yu wrote:
> > src/common/resources.cpp, line 314
> > <https://reviews.apache.org/r/42471/diff/4/?file=1205493#file1205493line314>
> >
> > This is not correct. You've already checked left.disk() == right.disk(), why do you need this? Instead, you should check if left != right:
> >
> > ```
> > if (left.disk().has_source() &&
> > left.disk().source().type() == MOUNT &&
> > left != right) {
> > return false;
> > }
> > ```
Also, could you please add a test case for this?
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/#review115863
-----------------------------------------------------------
On Jan. 22, 2016, 9:27 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42471/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 9:27 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4380
> https://issues.apache.org/jira/browse/MESOS-4380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
> include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Jan. 22, 2016, 5:03 p.m., Jie Yu wrote:
> > src/common/resources.cpp, line 314
> > <https://reviews.apache.org/r/42471/diff/4/?file=1205493#file1205493line314>
> >
> > This is not correct. You've already checked left.disk() == right.disk(), why do you need this? Instead, you should check if left != right:
> >
> > ```
> > if (left.disk().has_source() &&
> > left.disk().source().type() == MOUNT &&
> > left != right) {
> > return false;
> > }
> > ```
>
> Jie Yu wrote:
> Also, could you please add a test case for this?
Added test cases in https://reviews.apache.org/r/42683/
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/#review115863
-----------------------------------------------------------
On Jan. 23, 2016, 10:47 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42471/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2016, 10:47 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4380
> https://issues.apache.org/jira/browse/MESOS-4380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
> include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/#review115863
-----------------------------------------------------------
src/common/resources.cpp (line 310)
<https://reviews.apache.org/r/42471/#comment176923>
This is not correct. You've already checked left.disk() == right.disk(), why do you need this? Instead, you should check if left != right:
```
if (left.disk().has_source() &&
left.disk().source().type() == MOUNT &&
left != right) {
return false;
}
```
src/v1/resources.cpp (lines 308 - 310)
<https://reviews.apache.org/r/42471/#comment176924>
Ditto.
- Jie Yu
On Jan. 22, 2016, 9:27 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42471/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 9:27 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4380
> https://issues.apache.org/jira/browse/MESOS-4380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
> include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 9:27 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
Addressed comments.
Bugs: MESOS-4380
https://issues.apache.org/jira/browse/MESOS-4380
Repository: mesos
Description
-------
Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
Diffs (updated)
-----
include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/42471/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/#review115648
-----------------------------------------------------------
src/common/resources.cpp (lines 102 - 108)
<https://reviews.apache.org/r/42471/#comment176646>
Can you do the following to be more consistent with others
```
if (left.has_path() && left.path() != right.path()) {
return false;
}
if (left.has_mount() && left.mount() != right.mount()) {
return false;
}
```
src/common/resources.cpp (lines 251 - 255)
<https://reviews.apache.org/r/42471/#comment176642>
I'd prefer removing this CHECK here since it's on the critical path of resource calculation.
src/common/resources.cpp (lines 309 - 328)
<https://reviews.apache.org/r/42471/#comment176643>
Ditto on merge them into a single if clause.
src/common/resources.cpp (lines 315 - 317)
<https://reviews.apache.org/r/42471/#comment176644>
Ditto on removing this CHECK.
src/common/resources.cpp (lines 319 - 322)
<https://reviews.apache.org/r/42471/#comment176645>
This does not look correct. Two identical MOUNT disk resource should be subtractable.
src/v1/resources.cpp (lines 102 - 104)
<https://reviews.apache.org/r/42471/#comment176636>
Can you do the following to be consistent with others:
```
if (left.has_path() && left.path() != right.path()) {
return false;
}
if (left.has_mount() && left.mount() != right.mount()) {
return false;
}
return true;
```
src/v1/resources.cpp (lines 247 - 268)
<https://reviews.apache.org/r/42471/#comment176638>
We should merge those check under the same `has_disk` if clause:
```
if (left.has_disk()) {
// Check if disk() are equal
// MOUNT check
// persistence check
}
```
src/v1/resources.cpp (lines 253 - 255)
<https://reviews.apache.org/r/42471/#comment176647>
Ditto on removing it.
src/v1/resources.cpp (lines 315 - 317)
<https://reviews.apache.org/r/42471/#comment176648>
Ditto on removing it.
src/v1/resources.cpp (lines 319 - 322)
<https://reviews.apache.org/r/42471/#comment176649>
Ditto. Please adjust the logics here according to my comments above.
- Jie Yu
On Jan. 21, 2016, 7:36 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42471/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 7:36 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4380
> https://issues.apache.org/jira/browse/MESOS-4380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
> include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 7:36 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
Added logic for `Mount` type.
Bugs: MESOS-4380
https://issues.apache.org/jira/browse/MESOS-4380
Repository: mesos
Description
-------
Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
Diffs (updated)
-----
include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/42471/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 2:29 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-4380
https://issues.apache.org/jira/browse/MESOS-4380
Repository: mesos
Description (updated)
-------
Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.
Diffs (updated)
-----
include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/42471/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Jan. 19, 2016, 10:50 p.m., Jie Yu wrote:
> > include/mesos/v1/values.hpp, line 22
> > <https://reviews.apache.org/r/42471/diff/1/?file=1200689#file1200689line22>
> >
> > Why this change?
It was due to a cyclical include between `values.hpp` and `mesos.hpp`; however, since I moved the operators it's not necessary anymore.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/#review115260
-----------------------------------------------------------
On Jan. 18, 2016, 9:23 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42471/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 9:23 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4380
> https://issues.apache.org/jira/browse/MESOS-4380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
> include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
> include/mesos/v1/values.hpp 03a19ee44b3d7f801f7ca2a61f1d42d51e0c144b
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Jan. 19, 2016, 10:50 p.m., Jie Yu wrote:
> > include/mesos/type_utils.hpp, line 29
> > <https://reviews.apache.org/r/42471/diff/1/?file=1200687#file1200687line29>
> >
> > Do you need this?
Not after we get rid of `total_size`. I needed it for the scalar comparison.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/#review115260
-----------------------------------------------------------
On Jan. 18, 2016, 9:23 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42471/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 9:23 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4380
> https://issues.apache.org/jira/browse/MESOS-4380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
> include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
> include/mesos/v1/values.hpp 03a19ee44b3d7f801f7ca2a61f1d42d51e0c144b
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic
for 'DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42471/#review115260
-----------------------------------------------------------
Do we want to expose == and != for DiskInfo::Source yet? We don't even have == and != exposed for DiskInfo yet (same for ReservationInfo, etc.). Maybe make them file local helpers in src/common/resources.cpp for now.
include/mesos/type_utils.hpp (line 29)
<https://reviews.apache.org/r/42471/#comment176201>
Do you need this?
include/mesos/type_utils.hpp (lines 64 - 74)
<https://reviews.apache.org/r/42471/#comment176190>
Not yours. I wish we could sort them according to lexical order as we did before.
include/mesos/type_utils.hpp (lines 167 - 175)
<https://reviews.apache.org/r/42471/#comment176200>
Can you move this above `operator==(const SlaveID&`
include/mesos/type_utils.hpp (line 171)
<https://reviews.apache.org/r/42471/#comment176202>
Can you move non trivial impl. to common/type_utils.cpp?
include/mesos/type_utils.hpp (lines 179 - 187)
<https://reviews.apache.org/r/42471/#comment176203>
Ditto. Move non trivial impl. to cpp file.
include/mesos/type_utils.hpp (lines 242 - 255)
<https://reviews.apache.org/r/42471/#comment176197>
Not yours, can you put these above SlaveID.
include/mesos/v1/mesos.hpp (line 30)
<https://reviews.apache.org/r/42471/#comment176204>
No you need this?
include/mesos/v1/values.hpp (line 22)
<https://reviews.apache.org/r/42471/#comment176205>
Why this change?
src/common/resources.cpp (lines 93 - 99)
<https://reviews.apache.org/r/42471/#comment176208>
I prefer to check 'source' first. Can we move this up above the persistence checks.
src/v1/resources.cpp (lines 93 - 99)
<https://reviews.apache.org/r/42471/#comment176209>
Ditto.
- Jie Yu
On Jan. 18, 2016, 9:23 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42471/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 9:23 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4380
> https://issues.apache.org/jira/browse/MESOS-4380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a
> include/mesos/v1/mesos.hpp 961042d8e4944a475076b829966020d62175d726
> include/mesos/v1/values.hpp 03a19ee44b3d7f801f7ca2a61f1d42d51e0c144b
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>