You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2018/02/23 20:38:52 UTC
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9434
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
For large secure clusters, it was empirically found by Michael Ho
that the default negotiation timeout of 300000 ms and using 64
negotiation threads works best.
Future patches may attempt to improve negitation times at which point
we can revisit bringing down the defaults.
Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
---
M be/src/rpc/authentication.cc
M be/src/rpc/rpc-mgr.cc
2 files changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/9434/1
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
Patch Set 3: Code-Review+2
Rebase, carry +2.
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Feb 2018 00:10:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2007/
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Feb 2018 00:11:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2029/
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Feb 2018 17:44:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
For large secure clusters, it was empirically found by Michael Ho
that the default negotiation timeout of 300000 ms and using 64
negotiation threads works best.
Future patches may attempt to improve negitation times at which point
we can revisit bringing down the defaults.
Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
---
M be/src/rpc/authentication.cc
M be/src/rpc/rpc-mgr.cc
2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/9434/2
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
For large secure clusters, it was empirically found by Michael Ho
that the default negotiation timeout of 300000 ms and using 64
negotiation threads works best.
Future patches may attempt to improve negitation times at which point
we can revisit bringing down the defaults.
Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Reviewed-on: http://gerrit.cloudera.org:8080/9434
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/rpc/authentication.cc
M be/src/rpc/rpc-mgr.cc
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Sailesh Mukil: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 4
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Feb 2018 21:28:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
+1 for now as I did the experiment so I may be biased. Please have someone else chime in too to see if they may have different opinion.
http://gerrit.cloudera.org:8080/#/c/9434/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9434/2//COMMIT_MSG@14
PS2, Line 14: bringing down the defaults.
What's the benefit tradeoff for using larger default values ?
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 20:45:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
Patch Set 2: Code-Review+1
Seems okay to do this.
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 22:36:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9434/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9434/2//COMMIT_MSG@14
PS2, Line 14: bringing down the defaults.
> What's the benefit tradeoff for using larger default values ?
In certain cases, if we have larger values we might end up waiting longer to timeout for things like unreachable hosts due to network partitions or due to it being switched off, etc.
But I think if there are no network or hardware issues, then the downside isn't too much.
Also, if there are network or hardware issues, we'd find it through other means anyway.
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 21:26:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 23:43:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 )
Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters
......................................................................
Patch Set 3:
Just saw the mail about holding off builds. Will restart after builds are fixed.
--
To view, visit http://gerrit.cloudera.org:8080/9434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3198ceae82ac92f37c981e75134ce948fc4e72
Gerrit-Change-Number: 9434
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Feb 2018 00:12:34 +0000
Gerrit-HasComments: No