You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/25 16:54:58 UTC

[GitHub] [beam] pabloem commented on a change in pull request #15328: [BEAM-11987] Python Datastore - Implement IO Request Count metric

pabloem commented on a change in pull request #15328:
URL: https://github.com/apache/beam/pull/15328#discussion_r695938489



##########
File path: sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py
##########
@@ -26,20 +26,27 @@
 import logging
 import time
 
+from google.api_core.exceptions import ClientError

Review comment:
       we allow users to install Google Cloud dependencies optionally (thus the `pip install apache-beam[gcp]`). The way in which we support this is with the try/catch imports that we have here : )




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org