You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/05 13:51:20 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4373: creates /var/run/cloud folder for creation of lock file
Pearl1594 opened a new pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373
## Description
modifyvxlan.sh script fails run as it isn't able to find the /var/run/cloud directory to create the lock file
Fixes: https://github.com/apache/cloudstack/issues/4350
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
- Deployed an Advanced zone with VXLAN as isolation method
- deployed a VM in an isolated network
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-704193945
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-704169158
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-704230752
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#discussion_r500158127
##########
File path: scripts/vm/network/vnet/modifyvxlan.sh
##########
@@ -131,6 +131,9 @@ fi
LOCKFILE=/var/run/cloud/vxlan.lock
+# ensures that parent directories exists and prepares the lock file
+mkdir -p "${LOCKFILE%/*}" && touch "$LOCKFILE"
Review comment:
we do not need the touch right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-704169597
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-708305995
Manually tested the logic on bash, LGTM. Merging based on travis tests and lgtms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] levindecaro commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
levindecaro commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-722108509
@DaanHoogland
I would like to report #4350 fixed create directory issue. thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-704196170
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-707069804
@rhtyd /var/run is a tmpfs on many systems nowadays, so the package can't fix this.
I just wonder why we (PCextreme) never run into this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-707068190
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-707031679
Ideally this must be created on pkg installation.
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#discussion_r500188009
##########
File path: scripts/vm/network/vnet/modifyvxlan.sh
##########
@@ -131,6 +131,9 @@ fi
LOCKFILE=/var/run/cloud/vxlan.lock
+# ensures that parent directories exists and prepares the lock file
+mkdir -p "${LOCKFILE%/*}" && touch "$LOCKFILE"
Review comment:
Wouldn't actually require the file creation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-704196424
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-707032599
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-704227815
Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2126
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4373:
URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-704250683
The big question: Why doesn't this exist?
I have never seen these issues with Ubuntu systems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org