You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/27 23:41:05 UTC

[GitHub] [skywalking-infra-e2e] Superskyyy commented on a diff in pull request #87: Add .exe suffix to windows build artifact

Superskyyy commented on code in PR #87:
URL: https://github.com/apache/skywalking-infra-e2e/pull/87#discussion_r1007463063


##########
Makefile:
##########
@@ -33,6 +33,10 @@ GO_BUILD_LDFLAGS = -X github.com/apache/skywalking-$(PROJECT)/commands.version=$
 PLATFORMS := windows linux darwin
 os = $(word 1, $@)
 
+artifact_linux := $(PROJECT)
+artifact_darwin := $(PROJECT)
+artifact_windows := $(PROJECT).exe

Review Comment:
   Ha, much more elegant, I'm gonna change to this, don't merge.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org