You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2023/03/16 13:57:53 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #1323: Introduce TBB to refactor task runners
PragmaTwice opened a new pull request, #1323:
URL: https://github.com/apache/incubator-kvrocks/pull/1323
We refactor the TaskRunner class using blocking queues (tbb::concurrent_bounded_queue) in oneTBB.
oneTBB provides more utilities about threads can be used in kvrocks, like spin locks, rw mutex (more efficient), concurrent map, set, vector, and queue, concurrent algorithms, task arena, task groups (which has some difference than task runners), and task graphs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1323: Introduce TBB to refactor task runners
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1323:
URL: https://github.com/apache/incubator-kvrocks/pull/1323#discussion_r1138728170
##########
.github/workflows/kvrocks.yaml:
##########
@@ -35,7 +35,7 @@ concurrency:
jobs:
check-and-lint:
name: Lint and check code
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-22.04
Review Comment:
We need newer clang-tidy (version 12 -> 14) so that a bug (false report) in the old version (clang-tidy 12) will be fixed, and does not fail the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1323: Introduce TBB to refactor task runners
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #1323:
URL: https://github.com/apache/incubator-kvrocks/pull/1323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1323: Introduce TBB to refactor task runners
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1323:
URL: https://github.com/apache/incubator-kvrocks/pull/1323#discussion_r1138728170
##########
.github/workflows/kvrocks.yaml:
##########
@@ -35,7 +35,7 @@ concurrency:
jobs:
check-and-lint:
name: Lint and check code
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-22.04
Review Comment:
We need newer clang-tidy (version 12 -> 14) so that a bug (false report) in old version will be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1323: Introduce TBB to refactor task runners
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1323:
URL: https://github.com/apache/incubator-kvrocks/pull/1323#issuecomment-1473341818
> Do we plan to optimize more places with TBB in the future?
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1323: Introduce TBB to refactor task runners
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1323:
URL: https://github.com/apache/incubator-kvrocks/pull/1323#issuecomment-1473493652
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1323: Introduce TBB to refactor task runners
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1323:
URL: https://github.com/apache/incubator-kvrocks/pull/1323#discussion_r1138728170
##########
.github/workflows/kvrocks.yaml:
##########
@@ -35,7 +35,7 @@ concurrency:
jobs:
check-and-lint:
name: Lint and check code
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-22.04
Review Comment:
We need newer clang-tidy (version 12 -> 14) so that a bug (false report) in the old version (clang-tidy 12) will be fixed.
##########
.github/workflows/kvrocks.yaml:
##########
@@ -35,7 +35,7 @@ concurrency:
jobs:
check-and-lint:
name: Lint and check code
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-22.04
Review Comment:
We need newer clang-tidy (version 12 -> 14) so that a bug (false report) in the old version (clang-tidy 12) will be fixed, and do not fail the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] caipengbo commented on pull request #1323: Introduce TBB to refactor task runners
Posted by "caipengbo (via GitHub)" <gi...@apache.org>.
caipengbo commented on PR #1323:
URL: https://github.com/apache/incubator-kvrocks/pull/1323#issuecomment-1473310994
Do we plan to optimize more places with TBB in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org