[GitHub] [superset] jinghua-qa commented on pull request #18215: feat(explore): Keep or reset chart config after datasource change

[GitBox <gi...@apache.org>]

jinghua-qa commented on pull request #18215:
URL: https://github.com/apache/superset/pull/18215#issuecomment-1026166189


   I have found 3 issues in the PR when i testing in the ephemeral env
   1,  On the dataset name filed, the dataset name showed without the schema (master has <schema>.<dataset_name>, is that expected?
   <img width="300" alt="Screen Shot 2022-01-31 at 11 21 57 AM" src="https://user-images.githubusercontent.com/81597121/151858682-62ff1a5b-dab6-4583-b1ed-aae1bf12232c.png">
   2, seems like when the warning msg is shown, it is not auto pop to the msg and if user is at the bottom of the panel, user may not able to see the warning msg until user scroll up
   
   https://user-images.githubusercontent.com/81597121/151865156-c77dad31-8187-4f69-9013-3d1bb0d1f6db.mov
   
   3, After the i change dataset, if i also change the viz type, the explore page will become blank
   
   
   
   https://user-images.githubusercontent.com/81597121/151865290-3d5e29cf-3428-4ae3-8704-e7634302abee.mov
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org