[GitHub] [bookkeeper] lhotari commented on a change in pull request #3108: Issue #3105: Optimize OrderedExecutor performance by using GrowableArrayBlockingQueue

[GitBox <gi...@apache.org>]

lhotari commented on a change in pull request #3108:
URL: https://github.com/apache/bookkeeper/pull/3108#discussion_r825729833



##########
File path: bookkeeper-common/src/main/java/org/apache/bookkeeper/common/collections/GrowableArrayBlockingQueue.java
##########
@@ -83,6 +82,7 @@ public T poll() {
         try {
             if (SIZE_UPDATER.get(this) > 0) {
                 T item = data[headIndex.value];
+                data[headIndex.value] = null;

Review comment:
       Pulsar contains GrowableArrayBlockingQueue too, https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/util/collections/GrowableArrayBlockingQueue.java . I picked this fix to the BK version of GrowableArrayBlockingQueue when comparing the classes. 
   
   I didn't see an explicit test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org