You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rawwar (via GitHub)" <gi...@apache.org> on 2024/10/11 06:11:05 UTC
[PR] fix: HttpSensorTrigger to include `method` when serializing [airflow]
rawwar opened a new pull request, #42925:
URL: https://github.com/apache/airflow/pull/42925
As of now, the method passed via HttpOperator in deferrable mode is not being serialized. Hence, during the deferrable mode, HttpSensor ends up always making GET requests instead of the method originally intended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: HttpSensorTrigger to include `method` when serializing [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #42925:
URL: https://github.com/apache/airflow/pull/42925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: HttpSensorTrigger to include `method` when serializing [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #42925:
URL: https://github.com/apache/airflow/pull/42925#issuecomment-2406625708
Overall, looks good. Let's change the `TEST_METHOD` in unit tests to non POST method and create one unit test that does not pass method into `__init__`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: HttpSensorTrigger to include `method` when serializing [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on PR #42925:
URL: https://github.com/apache/airflow/pull/42925#issuecomment-2406653365
> Overall, looks good. Let's change the `TEST_METHOD` in unit tests to non POST method and create one unit test that does not pass method into `__init__`
Added a test that does pass POST and checks if POST is being returned by serializer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org