[GitHub] [lucene-solr] dsmiley edited a comment on issue #953: LUCENE-9006: WDGF catenateAll should come before parts

[GitBox <gi...@apache.org>]

dsmiley edited a comment on issue #953: LUCENE-9006: WDGF catenateAll should come before parts
URL: https://github.com/apache/lucene-solr/pull/953#issuecomment-545111987
 
 
   Thanks for the approval.
   
   Is there a simple test somewhere that illustrates that the graph is incorrect?  Or if you were to write one that does, maybe `org.apache.lucene.analysis.BaseTokenStreamTestCase#getGraphStrings(org.apache.lucene.analysis.TokenStream)` would show the problem for "8-input"?    I edited testCatenateAllEmittedBeforeParts with this code:
   
   ```
   Set<String> graphStrings = getGraphStrings(a, "8-input");
   System.out.println(graphStrings.toString());
   ```
   
   which produced: [input, 8-input, 8input]
   which looks correct; no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org