You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zz...@apache.org on 2020/09/07 03:01:32 UTC

[trafficserver] branch master updated: Fix #7164 Chaning Warning to Debug and creating a stat for inserting duplicates to pending dns (#7166)

This is an automated email from the ASF dual-hosted git repository.

zzz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new decc63c  Fix #7164 Chaning Warning to Debug and creating a stat for inserting duplicates to pending dns (#7166)
decc63c is described below

commit decc63c20b981e50f8a11149f4e7816b974e303e
Author: Zizhong Zhang <zi...@linkedin.com>
AuthorDate: Sun Sep 6 20:01:21 2020 -0700

    Fix #7164 Chaning Warning to Debug and creating a stat for inserting duplicates to pending dns (#7166)
---
 iocore/hostdb/HostDB.cc           | 6 +++++-
 iocore/hostdb/P_HostDBProcessor.h | 1 +
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/iocore/hostdb/HostDB.cc b/iocore/hostdb/HostDB.cc
index 75ad469..ede43d0 100644
--- a/iocore/hostdb/HostDB.cc
+++ b/iocore/hostdb/HostDB.cc
@@ -1587,7 +1587,8 @@ HostDBContinuation::set_check_pending_dns()
   Queue<HostDBContinuation> &q = hostDB.pending_dns_for_hash(hash.hash);
   this->setThreadAffinity(this_ethread());
   if (q.in(this)) {
-    Warning("Skip the insertion of the same continuation to pending dns");
+    HOSTDB_INCREMENT_DYN_STAT(hostdb_insert_duplicate_to_pending_dns_stat);
+    Debug("hostdb", "Skip the insertion of the same continuation to pending dns");
     return false;
   }
   HostDBContinuation *c = q.head;
@@ -2159,6 +2160,9 @@ ink_hostdb_init(ts::ModuleVersion v)
   RecRegisterRawStat(hostdb_rsb, RECT_PROCESS, "proxy.process.hostdb.re_dns_on_reload", RECD_INT, RECP_PERSISTENT,
                      (int)hostdb_re_dns_on_reload_stat, RecRawStatSyncSum);
 
+  RecRegisterRawStat(hostdb_rsb, RECT_PROCESS, "proxy.process.hostdb.insert_duplicate_to_pending_dns", RECD_INT, RECP_PERSISTENT,
+                     (int)hostdb_insert_duplicate_to_pending_dns_stat, RecRawStatSyncSum);
+
   ts_host_res_global_init();
 }
 
diff --git a/iocore/hostdb/P_HostDBProcessor.h b/iocore/hostdb/P_HostDBProcessor.h
index b903049..ba0b207 100644
--- a/iocore/hostdb/P_HostDBProcessor.h
+++ b/iocore/hostdb/P_HostDBProcessor.h
@@ -140,6 +140,7 @@ enum HostDB_Stats {
   hostdb_ttl_stat,         // D average TTL
   hostdb_ttl_expires_stat, // D == TTL Expires
   hostdb_re_dns_on_reload_stat,
+  hostdb_insert_duplicate_to_pending_dns_stat,
   HostDB_Stat_Count
 };