You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/06/13 20:51:50 UTC

[commons-numbers] 01/06: NUMBERS-100: Remove duplicate test

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 3e6277cb9c077a0ed0ac54fea84fb1219c3c4ae1
Author: Schamschi <he...@gmx.at>
AuthorDate: Sun Jun 9 21:21:36 2019 +0200

    NUMBERS-100: Remove duplicate test
    
    Remove a duplicate test in the method org.apache.commons.numbers.fraction.FractionTest.testAdd()
---
 .../java/org/apache/commons/numbers/fraction/FractionTest.java | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
index 10c3a20..0ab3cef 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
@@ -379,12 +379,6 @@ public class FractionTest {
             Assert.fail("expecting ArithmeticException");
         } catch (ArithmeticException ex) {}
 
-        try {
-            f= Fraction.of(-Integer.MAX_VALUE, 1);
-            f = f.add(f);
-            Assert.fail("expecting ArithmeticException");
-        } catch (ArithmeticException ex) {}
-
         f1 = Fraction.of(3,327680);
         f2 = Fraction.of(2,59049);
         try {
@@ -627,7 +621,7 @@ public class FractionTest {
             Assert.assertEquals(fraction, TestUtils.serializeAndRecover(fraction));
         }
     }
-    
+
     @Test
     public void testParse() {
         String[] validExpressions = new String[] {
@@ -641,7 +635,7 @@ public class FractionTest {
         };
         int inc = 0;
         for (Fraction fraction: fractions) {
-            Assert.assertEquals(fraction, 
+            Assert.assertEquals(fraction,
                     Fraction.parse(validExpressions[inc]));
             inc++;
         }