You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/08/16 00:30:17 UTC

[GitHub] pritidesai opened a new issue #330: rename Set* to set* in manifestreader.go

pritidesai opened a new issue #330: rename Set* to set* in manifestreader.go
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/330
 
 
   There are few set methods in [manifestreader.go](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/deployers/manifestreader.go) which only have single usage inside the same manifestreader.go file. There is no need to export following methods outside of deployer package. Rename them to set* to mark it as unexported.
   
   SetDependencies to setDependencies
   SetPackage to setPackage
   SetActions to setActions
   SetSequences to setSequences
   SetTriggers to setTriggers
   SetRules to setRules
   SetApis to setApis
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services