You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by jo...@apache.org on 2008/10/30 19:33:35 UTC

svn commit: r709221 - /poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java

Author: josh
Date: Thu Oct 30 11:33:35 2008
New Revision: 709221

URL: http://svn.apache.org/viewvc?rev=709221&view=rev
Log:
Optimised slow test case (after reviewing original purpose)

Modified:
    poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java?rev=709221&r1=709220&r2=709221&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java Thu Oct 30 11:33:35 2008
@@ -493,14 +493,16 @@
     }
 
 
-    public void testManyRows() {
+    /**
+     * Test for row indexes beyond {@link Short#MAX_VALUE}.
+     * This bug was first fixed in svn r352609.
+     */
+    public void testRowIndexesBeyond32768() {
         HSSFWorkbook workbook = new HSSFWorkbook();
         HSSFSheet sheet = workbook.createSheet();
         HSSFRow row;
         HSSFCell cell;
-        int i, j;
-        for ( i = 0, j = 32771; j > 0; i++, j-- )
-        {
+        for (int i = 32700; i < 32771; i++) {
             row = sheet.createRow(i);
             cell = row.createCell(0);
             cell.setCellValue(i);



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org