You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@solr.apache.org by Jan Høydahl <ja...@cominvent.com> on 2022/03/30 18:53:19 UTC
[VOTE] Release Solr 9.0.0 RC2
Please vote for release candidate 2 for Solr 9.0.0
The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
You can run the smoke tester directly with this command:
python3 -u dev-tools/scripts/smokeTestRelease.py \
https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
You are encouraged to do an extra thorough test and manual inspection beyond
running the smoketester, since this is a major release.
You can build a release-candidate of the official docker image using the following command:
DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
--build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
-t solr-rc:9.0.0-2
The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00 UTC.
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Here is my +1
SUCCESS! [0:53:16.741542]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: [VOTE][FAILED] Release Solr 9.0.0 RC2
Posted by Jan Høydahl <ja...@cominvent.com>.
This VOTE has failed due to https://issues.apache.org/jira/browse/SOLR-16131 <https://issues.apache.org/jira/browse/SOLR-16131>
Will re-spin once that is resolved.
Appreciate if someone is able to test the other new modules in "real life" settings too, to see if we have other similar issues.
- HDFS, Hadoop-Auth, Scripting and JWT-Auth
Jan
> 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <ja...@cominvent.com>:
>
> Please vote for release candidate 2 for Solr 9.0.0
>
> The artifacts can be downloaded from:
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py \
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>
> You are encouraged to do an extra thorough test and manual inspection beyond
> running the smoketester, since this is a major release.
>
> You can build a release-candidate of the official docker image using the following command:
>
> DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
> docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
> --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
> -t solr-rc:9.0.0-2
>
> The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00 UTC.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Here is my +1
>
> SUCCESS! [0:53:16.741542]
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Mike Drob <md...@mdrob.com>.
Anshum and I are both seeing the smoke tester leak GPG agents, filed
https://issues.apache.org/jira/browse/SOLR-16132 for it.
On Thu, Mar 31, 2022 at 9:06 AM Ishan Chattopadhyaya <
ichattopadhyaya@gmail.com> wrote:
> Sure, I'll take a stab at it. But, no need to wait for me to get to it, I
> might be able to do this in 1-2 days.
> Even if it doesn't make it to Solr 9.0, we can use Lucene 9.1 for a Solr
> 9.1 for sure :-)
>
> On Thu, Mar 31, 2022 at 7:13 PM Jan Høydahl <ja...@cominvent.com> wrote:
>
>> You make it seem dead smiple and risk free, but there are a ton of
>> changes that may trigger Solr changes, with another round of testing and
>> stabilization. But hey, won't stop you from whipping up a JIRA and a PR,
>> and then the PR review along with passing tests can shed more light on the
>> benefit, cost, risk and eta :)
>>
>> Jan
>>
>> 31. mar. 2022 kl. 15:23 skrev Ishan Chattopadhyaya <
>> ichattopadhyaya@gmail.com>:
>>
>>
>> https://lucene.apache.org/core/9_1_0/changes/Changes.html#v9.1.0.optimizations
>>
>> On Thu, Mar 31, 2022 at 6:52 PM Ishan Chattopadhyaya <
>> ichattopadhyaya@gmail.com> wrote:
>>
>>> > Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade?
>>> I'm not able to judge before I know.
>>>
>>> I can see lots of performance optimizations in Lucene 9.1, and can't see
>>> any significant risk (judging by changelog).
>>>
>>> On Thu, Mar 31, 2022 at 6:34 PM Jan Høydahl <ja...@cominvent.com>
>>> wrote:
>>>
>>>> Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade?
>>>> I'm not able to judge before I know.
>>>>
>>>> Yea, RC2 will likely fail due to SQL. But it is valuable for people to
>>>> continue testing RC2 and potentially find other bugs, so we avoid too many
>>>> RCs... So I'll leave the vote open a bit longer, to collect more -1's :)
>>>>
>>>> Jan
>>>>
>>>> 31. mar. 2022 kl. 14:35 skrev Ishan Chattopadhyaya <
>>>> ichattopadhyaya@gmail.com>:
>>>>
>>>> If this vote is going to fail, can we re-spin based on Lucene 9.1?
>>>>
>>>> On Thu, Mar 31, 2022 at 5:55 PM Joel Bernstein <jo...@gmail.com>
>>>> wrote:
>>>>
>>>>> Here is the jira https://issues.apache.org/jira/browse/SOLR-16131.
>>>>>
>>>>> My official vote for the RC:
>>>>>
>>>>> -1
>>>>>
>>>>>
>>>>> Joel Bernstein
>>>>> http://joelsolr.blogspot.com/
>>>>>
>>>>>
>>>>> On Thu, Mar 31, 2022 at 4:15 AM Jan Høydahl <ja...@cominvent.com>
>>>>> wrote:
>>>>>
>>>>>> Joel,
>>>>>>
>>>>>> I could reproduce the error
>>>>>> > Failed to load JDBC driver for
>>>>>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>>>>>
>>>>>> And I see that JDBCStream uses a plain
>>>>>> Class.forName(driverClassName); to fail early if the driver is wrong.
>>>>>>
>>>>>> The sql module is loaded:
>>>>>> > o.a.s.c.NodeConfig Added module sql.
>>>>>> libPath=...solr-9.0.0/solr/packaging/build/solr-9.0.0/modules/sql/lib with
>>>>>> 9 libs
>>>>>>
>>>>>> I wonder if we need to use SolrResourceLoader to load the class in
>>>>>> order to find classes in sharedLib. But JDBCStream is in solrj while
>>>>>> ResourceLoader is in core... Hmm
>>>>>>
>>>>>> Please file an issue for this, and cast your formal vote.
>>>>>>
>>>>>> Jan
>>>>>>
>>>>>> 31. mar. 2022 kl. 02:57 skrev Joel Bernstein <jo...@gmail.com>:
>>>>>>
>>>>>> I tried adding the module in the solr.in.sh and it can't find the
>>>>>> SQLHandler after starting up. So the sql module appears to not be working.
>>>>>>
>>>>>> "error":{
>>>>>> "metadata":[
>>>>>> "error-class","org.apache.solr.common.SolrException",
>>>>>> "root-error-class","java.lang.ClassNotFoundException"],
>>>>>> "msg":" Error loading class 'solr.SQLHandler'",
>>>>>>
>>>>>>
>>>>>>
>>>>>> Joel Bernstein
>>>>>> http://joelsolr.blogspot.com/
>>>>>>
>>>>>>
>>>>>> On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <jo...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> I tried loading the sql module but ran into this error when running
>>>>>>> a sql query:
>>>>>>>
>>>>>>> Failed to load JDBC driver for
>>>>>>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>>>>>>
>>>>>>> I loaded the module using system prop from startup command line:
>>>>>>>
>>>>>>> bin/solr start -c -Dsolr.modules=sql
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Joel Bernstein
>>>>>>> http://joelsolr.blogspot.com/
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <ja...@cominvent.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> I found a minor glitch.
>>>>>>>>
>>>>>>>> In solr-exporter, the default config solr-exporter-config.xml still
>>>>>>>> uses solr_metrics_core_replication_master as key for the
>>>>>>>> REPLICATION./replication.isLeader metric.
>>>>>>>>
>>>>>>>> In 8.x the metrics was named REPLICATION./replication.isMaster and
>>>>>>>> REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in
>>>>>>>> 9.0.
>>>>>>>> The prometheus key for follower is correctly renamed as
>>>>>>>> solr_metrics_core_replication_follower already.
>>>>>>>> I think the master -> leader should also have been done.
>>>>>>>>
>>>>>>>> However I cannot see it being referenced in Grafana dashboard or
>>>>>>>> elsewhere, so probably not worth a respin, we can do it in 9.1.
>>>>>>>>
>>>>>>>> Jan
>>>>>>>>
>>>>>>>> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <jan.asf@cominvent.com
>>>>>>>> >:
>>>>>>>> >
>>>>>>>> > Please vote for release candidate 2 for Solr 9.0.0
>>>>>>>> >
>>>>>>>> > The artifacts can be downloaded from:
>>>>>>>> >
>>>>>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>>>>>> >
>>>>>>>> > You can run the smoke tester directly with this command:
>>>>>>>> >
>>>>>>>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>>>>>> >
>>>>>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>>>>>> >
>>>>>>>> > You are encouraged to do an extra thorough test and manual
>>>>>>>> inspection beyond
>>>>>>>> > running the smoketester, since this is a major release.
>>>>>>>> >
>>>>>>>> > You can build a release-candidate of the official docker image
>>>>>>>> using the following command:
>>>>>>>> >
>>>>>>>> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
>>>>>>>> >
>>>>>>>> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
>>>>>>>> > docker build
>>>>>>>> $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
>>>>>>>> > --build-arg
>>>>>>>> SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
>>>>>>>> > -t solr-rc:9.0.0-2
>>>>>>>> >
>>>>>>>> > The vote will be open for at least 72 hours i.e. until 2022-04-02
>>>>>>>> 19:00 UTC.
>>>>>>>> >
>>>>>>>> > [ ] +1 approve
>>>>>>>> > [ ] +0 no opinion
>>>>>>>> > [ ] -1 disapprove (and reason why)
>>>>>>>> >
>>>>>>>> > Here is my +1
>>>>>>>> >
>>>>>>>> > SUCCESS! [0:53:16.741542]
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@solr.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>
>>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
Sure, I'll take a stab at it. But, no need to wait for me to get to it, I
might be able to do this in 1-2 days.
Even if it doesn't make it to Solr 9.0, we can use Lucene 9.1 for a Solr
9.1 for sure :-)
On Thu, Mar 31, 2022 at 7:13 PM Jan Høydahl <ja...@cominvent.com> wrote:
> You make it seem dead smiple and risk free, but there are a ton of changes
> that may trigger Solr changes, with another round of testing and
> stabilization. But hey, won't stop you from whipping up a JIRA and a PR,
> and then the PR review along with passing tests can shed more light on the
> benefit, cost, risk and eta :)
>
> Jan
>
> 31. mar. 2022 kl. 15:23 skrev Ishan Chattopadhyaya <
> ichattopadhyaya@gmail.com>:
>
>
> https://lucene.apache.org/core/9_1_0/changes/Changes.html#v9.1.0.optimizations
>
> On Thu, Mar 31, 2022 at 6:52 PM Ishan Chattopadhyaya <
> ichattopadhyaya@gmail.com> wrote:
>
>> > Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade?
>> I'm not able to judge before I know.
>>
>> I can see lots of performance optimizations in Lucene 9.1, and can't see
>> any significant risk (judging by changelog).
>>
>> On Thu, Mar 31, 2022 at 6:34 PM Jan Høydahl <ja...@cominvent.com>
>> wrote:
>>
>>> Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade?
>>> I'm not able to judge before I know.
>>>
>>> Yea, RC2 will likely fail due to SQL. But it is valuable for people to
>>> continue testing RC2 and potentially find other bugs, so we avoid too many
>>> RCs... So I'll leave the vote open a bit longer, to collect more -1's :)
>>>
>>> Jan
>>>
>>> 31. mar. 2022 kl. 14:35 skrev Ishan Chattopadhyaya <
>>> ichattopadhyaya@gmail.com>:
>>>
>>> If this vote is going to fail, can we re-spin based on Lucene 9.1?
>>>
>>> On Thu, Mar 31, 2022 at 5:55 PM Joel Bernstein <jo...@gmail.com>
>>> wrote:
>>>
>>>> Here is the jira https://issues.apache.org/jira/browse/SOLR-16131.
>>>>
>>>> My official vote for the RC:
>>>>
>>>> -1
>>>>
>>>>
>>>> Joel Bernstein
>>>> http://joelsolr.blogspot.com/
>>>>
>>>>
>>>> On Thu, Mar 31, 2022 at 4:15 AM Jan Høydahl <ja...@cominvent.com>
>>>> wrote:
>>>>
>>>>> Joel,
>>>>>
>>>>> I could reproduce the error
>>>>> > Failed to load JDBC driver for
>>>>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>>>>
>>>>> And I see that JDBCStream uses a plain Class.forName(driverClassName);
>>>>> to fail early if the driver is wrong.
>>>>>
>>>>> The sql module is loaded:
>>>>> > o.a.s.c.NodeConfig Added module sql.
>>>>> libPath=...solr-9.0.0/solr/packaging/build/solr-9.0.0/modules/sql/lib with
>>>>> 9 libs
>>>>>
>>>>> I wonder if we need to use SolrResourceLoader to load the class in
>>>>> order to find classes in sharedLib. But JDBCStream is in solrj while
>>>>> ResourceLoader is in core... Hmm
>>>>>
>>>>> Please file an issue for this, and cast your formal vote.
>>>>>
>>>>> Jan
>>>>>
>>>>> 31. mar. 2022 kl. 02:57 skrev Joel Bernstein <jo...@gmail.com>:
>>>>>
>>>>> I tried adding the module in the solr.in.sh and it can't find the
>>>>> SQLHandler after starting up. So the sql module appears to not be working.
>>>>>
>>>>> "error":{
>>>>> "metadata":[
>>>>> "error-class","org.apache.solr.common.SolrException",
>>>>> "root-error-class","java.lang.ClassNotFoundException"],
>>>>> "msg":" Error loading class 'solr.SQLHandler'",
>>>>>
>>>>>
>>>>>
>>>>> Joel Bernstein
>>>>> http://joelsolr.blogspot.com/
>>>>>
>>>>>
>>>>> On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <jo...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> I tried loading the sql module but ran into this error when running a
>>>>>> sql query:
>>>>>>
>>>>>> Failed to load JDBC driver for
>>>>>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>>>>>
>>>>>> I loaded the module using system prop from startup command line:
>>>>>>
>>>>>> bin/solr start -c -Dsolr.modules=sql
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> Joel Bernstein
>>>>>> http://joelsolr.blogspot.com/
>>>>>>
>>>>>>
>>>>>> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <ja...@cominvent.com>
>>>>>> wrote:
>>>>>>
>>>>>>> I found a minor glitch.
>>>>>>>
>>>>>>> In solr-exporter, the default config solr-exporter-config.xml still
>>>>>>> uses solr_metrics_core_replication_master as key for the
>>>>>>> REPLICATION./replication.isLeader metric.
>>>>>>>
>>>>>>> In 8.x the metrics was named REPLICATION./replication.isMaster and
>>>>>>> REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in
>>>>>>> 9.0.
>>>>>>> The prometheus key for follower is correctly renamed as
>>>>>>> solr_metrics_core_replication_follower already.
>>>>>>> I think the master -> leader should also have been done.
>>>>>>>
>>>>>>> However I cannot see it being referenced in Grafana dashboard or
>>>>>>> elsewhere, so probably not worth a respin, we can do it in 9.1.
>>>>>>>
>>>>>>> Jan
>>>>>>>
>>>>>>> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <ja...@cominvent.com>:
>>>>>>> >
>>>>>>> > Please vote for release candidate 2 for Solr 9.0.0
>>>>>>> >
>>>>>>> > The artifacts can be downloaded from:
>>>>>>> >
>>>>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>>>>> >
>>>>>>> > You can run the smoke tester directly with this command:
>>>>>>> >
>>>>>>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>>>>> >
>>>>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>>>>> >
>>>>>>> > You are encouraged to do an extra thorough test and manual
>>>>>>> inspection beyond
>>>>>>> > running the smoketester, since this is a major release.
>>>>>>> >
>>>>>>> > You can build a release-candidate of the official docker image
>>>>>>> using the following command:
>>>>>>> >
>>>>>>> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
>>>>>>> >
>>>>>>> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
>>>>>>> > docker build
>>>>>>> $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
>>>>>>> > --build-arg
>>>>>>> SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
>>>>>>> > -t solr-rc:9.0.0-2
>>>>>>> >
>>>>>>> > The vote will be open for at least 72 hours i.e. until 2022-04-02
>>>>>>> 19:00 UTC.
>>>>>>> >
>>>>>>> > [ ] +1 approve
>>>>>>> > [ ] +0 no opinion
>>>>>>> > [ ] -1 disapprove (and reason why)
>>>>>>> >
>>>>>>> > Here is my +1
>>>>>>> >
>>>>>>> > SUCCESS! [0:53:16.741542]
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>>>>>>> For additional commands, e-mail: dev-help@solr.apache.org
>>>>>>>
>>>>>>>
>>>>>
>>>
>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
+1, agree with Mark. Let's not rush.
On Thu, 31 Mar, 2022, 11:38 pm Mark Miller, <ma...@gmail.com> wrote:
> Just going to throw this out there, but I don’t think you have to know
> much of anything about the likely quality and impact of changes from Lucene
> 9.1 to say that raising the king dependency for a software project by a
> full dot release is def not “respin and another quick round of smokes
> material” even if this wasn’t an abnormal major release train.
>
> I can’t imagine how you wouldn’t want to add some meaningful breathing
> room gap even with the best of confidence in those changes and all the ways
> they might interact with Solr.
>
> Maybe that breathing room shows up anyway due to unrelated issues along
> the lines of SQL support, but seems to me the total potential impact gamble
> pretty easily says you’d want to bake that time into your vote to pull that
> trigger regardless.
>
>
>
> Mark
>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Mark Miller <ma...@gmail.com>.
Just going to throw this out there, but I don’t think you have to know much
of anything about the likely quality and impact of changes from Lucene 9.1
to say that raising the king dependency for a software project by a full
dot release is def not “respin and another quick round of smokes material”
even if this wasn’t an abnormal major release train.
I can’t imagine how you wouldn’t want to add some meaningful breathing room
gap even with the best of confidence in those changes and all the ways they
might interact with Solr.
Maybe that breathing room shows up anyway due to unrelated issues along the
lines of SQL support, but seems to me the total potential impact gamble
pretty easily says you’d want to bake that time into your vote to pull that
trigger regardless.
Mark
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Jan Høydahl <ja...@cominvent.com>.
You make it seem dead smiple and risk free, but there are a ton of changes that may trigger Solr changes, with another round of testing and stabilization. But hey, won't stop you from whipping up a JIRA and a PR, and then the PR review along with passing tests can shed more light on the benefit, cost, risk and eta :)
Jan
> 31. mar. 2022 kl. 15:23 skrev Ishan Chattopadhyaya <ic...@gmail.com>:
>
> https://lucene.apache.org/core/9_1_0/changes/Changes.html#v9.1.0.optimizations <https://lucene.apache.org/core/9_1_0/changes/Changes.html#v9.1.0.optimizations>
> On Thu, Mar 31, 2022 at 6:52 PM Ishan Chattopadhyaya <ichattopadhyaya@gmail.com <ma...@gmail.com>> wrote:
> > Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade? I'm not able to judge before I know.
>
> I can see lots of performance optimizations in Lucene 9.1, and can't see any significant risk (judging by changelog).
>
> On Thu, Mar 31, 2022 at 6:34 PM Jan Høydahl <jan.asf@cominvent.com <ma...@cominvent.com>> wrote:
> Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade? I'm not able to judge before I know.
>
> Yea, RC2 will likely fail due to SQL. But it is valuable for people to continue testing RC2 and potentially find other bugs, so we avoid too many RCs... So I'll leave the vote open a bit longer, to collect more -1's :)
>
> Jan
>
>> 31. mar. 2022 kl. 14:35 skrev Ishan Chattopadhyaya <ichattopadhyaya@gmail.com <ma...@gmail.com>>:
>>
>> If this vote is going to fail, can we re-spin based on Lucene 9.1?
>>
>> On Thu, Mar 31, 2022 at 5:55 PM Joel Bernstein <joelsolr@gmail.com <ma...@gmail.com>> wrote:
>> Here is the jira https://issues.apache.org/jira/browse/SOLR-16131 <https://issues.apache.org/jira/browse/SOLR-16131>.
>>
>> My official vote for the RC:
>>
>> -1
>>
>>
>> Joel Bernstein
>> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/>
>>
>>
>> On Thu, Mar 31, 2022 at 4:15 AM Jan Høydahl <jan.asf@cominvent.com <ma...@cominvent.com>> wrote:
>> Joel,
>>
>> I could reproduce the error
>> > Failed to load JDBC driver for 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>
>> And I see that JDBCStream uses a plain Class.forName(driverClassName); to fail early if the driver is wrong.
>>
>> The sql module is loaded:
>> > o.a.s.c.NodeConfig Added module sql. libPath=...solr-9.0.0/solr/packaging/build/solr-9.0.0/modules/sql/lib with 9 libs
>>
>> I wonder if we need to use SolrResourceLoader to load the class in order to find classes in sharedLib. But JDBCStream is in solrj while ResourceLoader is in core... Hmm
>>
>> Please file an issue for this, and cast your formal vote.
>>
>> Jan
>>
>>> 31. mar. 2022 kl. 02:57 skrev Joel Bernstein <joelsolr@gmail.com <ma...@gmail.com>>:
>>>
>>> I tried adding the module in the solr.in.sh <http://solr.in.sh/> and it can't find the SQLHandler after starting up. So the sql module appears to not be working.
>>>
>>> "error":{
>>> "metadata":[
>>> "error-class","org.apache.solr.common.SolrException",
>>> "root-error-class","java.lang.ClassNotFoundException"],
>>> "msg":" Error loading class 'solr.SQLHandler'",
>>>
>>>
>>> Joel Bernstein
>>> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/>
>>>
>>>
>>> On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <joelsolr@gmail.com <ma...@gmail.com>> wrote:
>>> I tried loading the sql module but ran into this error when running a sql query:
>>>
>>> Failed to load JDBC driver for 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>>
>>> I loaded the module using system prop from startup command line:
>>>
>>> bin/solr start -c -Dsolr.modules=sql
>>>
>>>
>>>
>>>
>>>
>>> Joel Bernstein
>>> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/>
>>>
>>>
>>> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <jan.asf@cominvent.com <ma...@cominvent.com>> wrote:
>>> I found a minor glitch.
>>>
>>> In solr-exporter, the default config solr-exporter-config.xml still uses solr_metrics_core_replication_master as key for the REPLICATION./replication.isLeader metric.
>>>
>>> In 8.x the metrics was named REPLICATION./replication.isMaster and REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in 9.0.
>>> The prometheus key for follower is correctly renamed as solr_metrics_core_replication_follower already.
>>> I think the master -> leader should also have been done.
>>>
>>> However I cannot see it being referenced in Grafana dashboard or elsewhere, so probably not worth a respin, we can do it in 9.1.
>>>
>>> Jan
>>>
>>> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <jan.asf@cominvent.com <ma...@cominvent.com>>:
>>> >
>>> > Please vote for release candidate 2 for Solr 9.0.0
>>> >
>>> > The artifacts can be downloaded from:
>>> > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2>
>>> >
>>> > You can run the smoke tester directly with this command:
>>> >
>>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>>> > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2>
>>> >
>>> > You are encouraged to do an extra thorough test and manual inspection beyond
>>> > running the smoketester, since this is a major release.
>>> >
>>> > You can build a release-candidate of the official docker image using the following command:
>>> >
>>> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr <https://dist.apache.org/repos/dist/dev/solr> && \
>>> > RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
>>> > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
>>> > --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
>>> > -t solr-rc:9.0.0-2
>>> >
>>> > The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00 UTC.
>>> >
>>> > [ ] +1 approve
>>> > [ ] +0 no opinion
>>> > [ ] -1 disapprove (and reason why)
>>> >
>>> > Here is my +1
>>> >
>>> > SUCCESS! [0:53:16.741542]
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org <ma...@solr.apache.org>
>>> For additional commands, e-mail: dev-help@solr.apache.org <ma...@solr.apache.org>
>>>
>>
>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
https://lucene.apache.org/core/9_1_0/changes/Changes.html#v9.1.0.optimizations
On Thu, Mar 31, 2022 at 6:52 PM Ishan Chattopadhyaya <
ichattopadhyaya@gmail.com> wrote:
> > Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade?
> I'm not able to judge before I know.
>
> I can see lots of performance optimizations in Lucene 9.1, and can't see
> any significant risk (judging by changelog).
>
> On Thu, Mar 31, 2022 at 6:34 PM Jan Høydahl <ja...@cominvent.com> wrote:
>
>> Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade?
>> I'm not able to judge before I know.
>>
>> Yea, RC2 will likely fail due to SQL. But it is valuable for people to
>> continue testing RC2 and potentially find other bugs, so we avoid too many
>> RCs... So I'll leave the vote open a bit longer, to collect more -1's :)
>>
>> Jan
>>
>> 31. mar. 2022 kl. 14:35 skrev Ishan Chattopadhyaya <
>> ichattopadhyaya@gmail.com>:
>>
>> If this vote is going to fail, can we re-spin based on Lucene 9.1?
>>
>> On Thu, Mar 31, 2022 at 5:55 PM Joel Bernstein <jo...@gmail.com>
>> wrote:
>>
>>> Here is the jira https://issues.apache.org/jira/browse/SOLR-16131.
>>>
>>> My official vote for the RC:
>>>
>>> -1
>>>
>>>
>>> Joel Bernstein
>>> http://joelsolr.blogspot.com/
>>>
>>>
>>> On Thu, Mar 31, 2022 at 4:15 AM Jan Høydahl <ja...@cominvent.com>
>>> wrote:
>>>
>>>> Joel,
>>>>
>>>> I could reproduce the error
>>>> > Failed to load JDBC driver for
>>>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>>>
>>>> And I see that JDBCStream uses a plain Class.forName(driverClassName);
>>>> to fail early if the driver is wrong.
>>>>
>>>> The sql module is loaded:
>>>> > o.a.s.c.NodeConfig Added module sql.
>>>> libPath=...solr-9.0.0/solr/packaging/build/solr-9.0.0/modules/sql/lib with
>>>> 9 libs
>>>>
>>>> I wonder if we need to use SolrResourceLoader to load the class in
>>>> order to find classes in sharedLib. But JDBCStream is in solrj while
>>>> ResourceLoader is in core... Hmm
>>>>
>>>> Please file an issue for this, and cast your formal vote.
>>>>
>>>> Jan
>>>>
>>>> 31. mar. 2022 kl. 02:57 skrev Joel Bernstein <jo...@gmail.com>:
>>>>
>>>> I tried adding the module in the solr.in.sh and it can't find the
>>>> SQLHandler after starting up. So the sql module appears to not be working.
>>>>
>>>> "error":{
>>>> "metadata":[
>>>> "error-class","org.apache.solr.common.SolrException",
>>>> "root-error-class","java.lang.ClassNotFoundException"],
>>>> "msg":" Error loading class 'solr.SQLHandler'",
>>>>
>>>>
>>>>
>>>> Joel Bernstein
>>>> http://joelsolr.blogspot.com/
>>>>
>>>>
>>>> On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <jo...@gmail.com>
>>>> wrote:
>>>>
>>>>> I tried loading the sql module but ran into this error when running a
>>>>> sql query:
>>>>>
>>>>> Failed to load JDBC driver for
>>>>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>>>>
>>>>> I loaded the module using system prop from startup command line:
>>>>>
>>>>> bin/solr start -c -Dsolr.modules=sql
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Joel Bernstein
>>>>> http://joelsolr.blogspot.com/
>>>>>
>>>>>
>>>>> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <ja...@cominvent.com>
>>>>> wrote:
>>>>>
>>>>>> I found a minor glitch.
>>>>>>
>>>>>> In solr-exporter, the default config solr-exporter-config.xml still
>>>>>> uses solr_metrics_core_replication_master as key for the
>>>>>> REPLICATION./replication.isLeader metric.
>>>>>>
>>>>>> In 8.x the metrics was named REPLICATION./replication.isMaster and
>>>>>> REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in
>>>>>> 9.0.
>>>>>> The prometheus key for follower is correctly renamed as
>>>>>> solr_metrics_core_replication_follower already.
>>>>>> I think the master -> leader should also have been done.
>>>>>>
>>>>>> However I cannot see it being referenced in Grafana dashboard or
>>>>>> elsewhere, so probably not worth a respin, we can do it in 9.1.
>>>>>>
>>>>>> Jan
>>>>>>
>>>>>> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <ja...@cominvent.com>:
>>>>>> >
>>>>>> > Please vote for release candidate 2 for Solr 9.0.0
>>>>>> >
>>>>>> > The artifacts can be downloaded from:
>>>>>> >
>>>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>>>> >
>>>>>> > You can run the smoke tester directly with this command:
>>>>>> >
>>>>>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>>>> >
>>>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>>>> >
>>>>>> > You are encouraged to do an extra thorough test and manual
>>>>>> inspection beyond
>>>>>> > running the smoketester, since this is a major release.
>>>>>> >
>>>>>> > You can build a release-candidate of the official docker image
>>>>>> using the following command:
>>>>>> >
>>>>>> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
>>>>>> >
>>>>>> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
>>>>>> > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official
>>>>>> \
>>>>>> > --build-arg
>>>>>> SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
>>>>>> > -t solr-rc:9.0.0-2
>>>>>> >
>>>>>> > The vote will be open for at least 72 hours i.e. until 2022-04-02
>>>>>> 19:00 UTC.
>>>>>> >
>>>>>> > [ ] +1 approve
>>>>>> > [ ] +0 no opinion
>>>>>> > [ ] -1 disapprove (and reason why)
>>>>>> >
>>>>>> > Here is my +1
>>>>>> >
>>>>>> > SUCCESS! [0:53:16.741542]
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>>>>>> For additional commands, e-mail: dev-help@solr.apache.org
>>>>>>
>>>>>>
>>>>
>>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
> Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade?
I'm not able to judge before I know.
I can see lots of performance optimizations in Lucene 9.1, and can't see
any significant risk (judging by changelog).
On Thu, Mar 31, 2022 at 6:34 PM Jan Høydahl <ja...@cominvent.com> wrote:
> Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade? I'm
> not able to judge before I know.
>
> Yea, RC2 will likely fail due to SQL. But it is valuable for people to
> continue testing RC2 and potentially find other bugs, so we avoid too many
> RCs... So I'll leave the vote open a bit longer, to collect more -1's :)
>
> Jan
>
> 31. mar. 2022 kl. 14:35 skrev Ishan Chattopadhyaya <
> ichattopadhyaya@gmail.com>:
>
> If this vote is going to fail, can we re-spin based on Lucene 9.1?
>
> On Thu, Mar 31, 2022 at 5:55 PM Joel Bernstein <jo...@gmail.com> wrote:
>
>> Here is the jira https://issues.apache.org/jira/browse/SOLR-16131.
>>
>> My official vote for the RC:
>>
>> -1
>>
>>
>> Joel Bernstein
>> http://joelsolr.blogspot.com/
>>
>>
>> On Thu, Mar 31, 2022 at 4:15 AM Jan Høydahl <ja...@cominvent.com>
>> wrote:
>>
>>> Joel,
>>>
>>> I could reproduce the error
>>> > Failed to load JDBC driver for
>>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>>
>>> And I see that JDBCStream uses a plain Class.forName(driverClassName);
>>> to fail early if the driver is wrong.
>>>
>>> The sql module is loaded:
>>> > o.a.s.c.NodeConfig Added module sql.
>>> libPath=...solr-9.0.0/solr/packaging/build/solr-9.0.0/modules/sql/lib with
>>> 9 libs
>>>
>>> I wonder if we need to use SolrResourceLoader to load the class in order
>>> to find classes in sharedLib. But JDBCStream is in solrj while
>>> ResourceLoader is in core... Hmm
>>>
>>> Please file an issue for this, and cast your formal vote.
>>>
>>> Jan
>>>
>>> 31. mar. 2022 kl. 02:57 skrev Joel Bernstein <jo...@gmail.com>:
>>>
>>> I tried adding the module in the solr.in.sh and it can't find the
>>> SQLHandler after starting up. So the sql module appears to not be working.
>>>
>>> "error":{
>>> "metadata":[
>>> "error-class","org.apache.solr.common.SolrException",
>>> "root-error-class","java.lang.ClassNotFoundException"],
>>> "msg":" Error loading class 'solr.SQLHandler'",
>>>
>>>
>>>
>>> Joel Bernstein
>>> http://joelsolr.blogspot.com/
>>>
>>>
>>> On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <jo...@gmail.com>
>>> wrote:
>>>
>>>> I tried loading the sql module but ran into this error when running a
>>>> sql query:
>>>>
>>>> Failed to load JDBC driver for
>>>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>>>
>>>> I loaded the module using system prop from startup command line:
>>>>
>>>> bin/solr start -c -Dsolr.modules=sql
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> Joel Bernstein
>>>> http://joelsolr.blogspot.com/
>>>>
>>>>
>>>> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <ja...@cominvent.com>
>>>> wrote:
>>>>
>>>>> I found a minor glitch.
>>>>>
>>>>> In solr-exporter, the default config solr-exporter-config.xml still
>>>>> uses solr_metrics_core_replication_master as key for the
>>>>> REPLICATION./replication.isLeader metric.
>>>>>
>>>>> In 8.x the metrics was named REPLICATION./replication.isMaster and
>>>>> REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in
>>>>> 9.0.
>>>>> The prometheus key for follower is correctly renamed as
>>>>> solr_metrics_core_replication_follower already.
>>>>> I think the master -> leader should also have been done.
>>>>>
>>>>> However I cannot see it being referenced in Grafana dashboard or
>>>>> elsewhere, so probably not worth a respin, we can do it in 9.1.
>>>>>
>>>>> Jan
>>>>>
>>>>> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <ja...@cominvent.com>:
>>>>> >
>>>>> > Please vote for release candidate 2 for Solr 9.0.0
>>>>> >
>>>>> > The artifacts can be downloaded from:
>>>>> >
>>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>>> >
>>>>> > You can run the smoke tester directly with this command:
>>>>> >
>>>>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>>> >
>>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>>> >
>>>>> > You are encouraged to do an extra thorough test and manual
>>>>> inspection beyond
>>>>> > running the smoketester, since this is a major release.
>>>>> >
>>>>> > You can build a release-candidate of the official docker image using
>>>>> the following command:
>>>>> >
>>>>> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
>>>>> >
>>>>> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
>>>>> > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
>>>>> > --build-arg
>>>>> SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
>>>>> > -t solr-rc:9.0.0-2
>>>>> >
>>>>> > The vote will be open for at least 72 hours i.e. until 2022-04-02
>>>>> 19:00 UTC.
>>>>> >
>>>>> > [ ] +1 approve
>>>>> > [ ] +0 no opinion
>>>>> > [ ] -1 disapprove (and reason why)
>>>>> >
>>>>> > Here is my +1
>>>>> >
>>>>> > SUCCESS! [0:53:16.741542]
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>>>>> For additional commands, e-mail: dev-help@solr.apache.org
>>>>>
>>>>>
>>>
>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Jan Høydahl <ja...@cominvent.com>.
Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade? I'm not able to judge before I know.
Yea, RC2 will likely fail due to SQL. But it is valuable for people to continue testing RC2 and potentially find other bugs, so we avoid too many RCs... So I'll leave the vote open a bit longer, to collect more -1's :)
Jan
> 31. mar. 2022 kl. 14:35 skrev Ishan Chattopadhyaya <ic...@gmail.com>:
>
> If this vote is going to fail, can we re-spin based on Lucene 9.1?
>
> On Thu, Mar 31, 2022 at 5:55 PM Joel Bernstein <joelsolr@gmail.com <ma...@gmail.com>> wrote:
> Here is the jira https://issues.apache.org/jira/browse/SOLR-16131 <https://issues.apache.org/jira/browse/SOLR-16131>.
>
> My official vote for the RC:
>
> -1
>
>
> Joel Bernstein
> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/>
>
>
> On Thu, Mar 31, 2022 at 4:15 AM Jan Høydahl <jan.asf@cominvent.com <ma...@cominvent.com>> wrote:
> Joel,
>
> I could reproduce the error
> > Failed to load JDBC driver for 'org.apache.solr.handler.sql.CalciteSolrDriver'
>
> And I see that JDBCStream uses a plain Class.forName(driverClassName); to fail early if the driver is wrong.
>
> The sql module is loaded:
> > o.a.s.c.NodeConfig Added module sql. libPath=...solr-9.0.0/solr/packaging/build/solr-9.0.0/modules/sql/lib with 9 libs
>
> I wonder if we need to use SolrResourceLoader to load the class in order to find classes in sharedLib. But JDBCStream is in solrj while ResourceLoader is in core... Hmm
>
> Please file an issue for this, and cast your formal vote.
>
> Jan
>
>> 31. mar. 2022 kl. 02:57 skrev Joel Bernstein <joelsolr@gmail.com <ma...@gmail.com>>:
>>
>> I tried adding the module in the solr.in.sh <http://solr.in.sh/> and it can't find the SQLHandler after starting up. So the sql module appears to not be working.
>>
>> "error":{
>> "metadata":[
>> "error-class","org.apache.solr.common.SolrException",
>> "root-error-class","java.lang.ClassNotFoundException"],
>> "msg":" Error loading class 'solr.SQLHandler'",
>>
>>
>> Joel Bernstein
>> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/>
>>
>>
>> On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <joelsolr@gmail.com <ma...@gmail.com>> wrote:
>> I tried loading the sql module but ran into this error when running a sql query:
>>
>> Failed to load JDBC driver for 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>
>> I loaded the module using system prop from startup command line:
>>
>> bin/solr start -c -Dsolr.modules=sql
>>
>>
>>
>>
>>
>> Joel Bernstein
>> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/>
>>
>>
>> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <jan.asf@cominvent.com <ma...@cominvent.com>> wrote:
>> I found a minor glitch.
>>
>> In solr-exporter, the default config solr-exporter-config.xml still uses solr_metrics_core_replication_master as key for the REPLICATION./replication.isLeader metric.
>>
>> In 8.x the metrics was named REPLICATION./replication.isMaster and REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in 9.0.
>> The prometheus key for follower is correctly renamed as solr_metrics_core_replication_follower already.
>> I think the master -> leader should also have been done.
>>
>> However I cannot see it being referenced in Grafana dashboard or elsewhere, so probably not worth a respin, we can do it in 9.1.
>>
>> Jan
>>
>> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <jan.asf@cominvent.com <ma...@cominvent.com>>:
>> >
>> > Please vote for release candidate 2 for Solr 9.0.0
>> >
>> > The artifacts can be downloaded from:
>> > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2>
>> >
>> > You can run the smoke tester directly with this command:
>> >
>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>> > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2>
>> >
>> > You are encouraged to do an extra thorough test and manual inspection beyond
>> > running the smoketester, since this is a major release.
>> >
>> > You can build a release-candidate of the official docker image using the following command:
>> >
>> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr <https://dist.apache.org/repos/dist/dev/solr> && \
>> > RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
>> > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
>> > --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
>> > -t solr-rc:9.0.0-2
>> >
>> > The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00 UTC.
>> >
>> > [ ] +1 approve
>> > [ ] +0 no opinion
>> > [ ] -1 disapprove (and reason why)
>> >
>> > Here is my +1
>> >
>> > SUCCESS! [0:53:16.741542]
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org <ma...@solr.apache.org>
>> For additional commands, e-mail: dev-help@solr.apache.org <ma...@solr.apache.org>
>>
>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
If this vote is going to fail, can we re-spin based on Lucene 9.1?
On Thu, Mar 31, 2022 at 5:55 PM Joel Bernstein <jo...@gmail.com> wrote:
> Here is the jira https://issues.apache.org/jira/browse/SOLR-16131.
>
> My official vote for the RC:
>
> -1
>
>
> Joel Bernstein
> http://joelsolr.blogspot.com/
>
>
> On Thu, Mar 31, 2022 at 4:15 AM Jan Høydahl <ja...@cominvent.com> wrote:
>
>> Joel,
>>
>> I could reproduce the error
>> > Failed to load JDBC driver for
>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>
>> And I see that JDBCStream uses a plain Class.forName(driverClassName); to
>> fail early if the driver is wrong.
>>
>> The sql module is loaded:
>> > o.a.s.c.NodeConfig Added module sql.
>> libPath=...solr-9.0.0/solr/packaging/build/solr-9.0.0/modules/sql/lib with
>> 9 libs
>>
>> I wonder if we need to use SolrResourceLoader to load the class in order
>> to find classes in sharedLib. But JDBCStream is in solrj while
>> ResourceLoader is in core... Hmm
>>
>> Please file an issue for this, and cast your formal vote.
>>
>> Jan
>>
>> 31. mar. 2022 kl. 02:57 skrev Joel Bernstein <jo...@gmail.com>:
>>
>> I tried adding the module in the solr.in.sh and it can't find the
>> SQLHandler after starting up. So the sql module appears to not be working.
>>
>> "error":{
>> "metadata":[
>> "error-class","org.apache.solr.common.SolrException",
>> "root-error-class","java.lang.ClassNotFoundException"],
>> "msg":" Error loading class 'solr.SQLHandler'",
>>
>>
>>
>> Joel Bernstein
>> http://joelsolr.blogspot.com/
>>
>>
>> On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <jo...@gmail.com>
>> wrote:
>>
>>> I tried loading the sql module but ran into this error when running a
>>> sql query:
>>>
>>> Failed to load JDBC driver for
>>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>>
>>> I loaded the module using system prop from startup command line:
>>>
>>> bin/solr start -c -Dsolr.modules=sql
>>>
>>>
>>>
>>>
>>>
>>> Joel Bernstein
>>> http://joelsolr.blogspot.com/
>>>
>>>
>>> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <ja...@cominvent.com>
>>> wrote:
>>>
>>>> I found a minor glitch.
>>>>
>>>> In solr-exporter, the default config solr-exporter-config.xml still
>>>> uses solr_metrics_core_replication_master as key for the
>>>> REPLICATION./replication.isLeader metric.
>>>>
>>>> In 8.x the metrics was named REPLICATION./replication.isMaster and
>>>> REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in
>>>> 9.0.
>>>> The prometheus key for follower is correctly renamed as
>>>> solr_metrics_core_replication_follower already.
>>>> I think the master -> leader should also have been done.
>>>>
>>>> However I cannot see it being referenced in Grafana dashboard or
>>>> elsewhere, so probably not worth a respin, we can do it in 9.1.
>>>>
>>>> Jan
>>>>
>>>> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <ja...@cominvent.com>:
>>>> >
>>>> > Please vote for release candidate 2 for Solr 9.0.0
>>>> >
>>>> > The artifacts can be downloaded from:
>>>> >
>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>> >
>>>> > You can run the smoke tester directly with this command:
>>>> >
>>>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>> >
>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>> >
>>>> > You are encouraged to do an extra thorough test and manual inspection
>>>> beyond
>>>> > running the smoketester, since this is a major release.
>>>> >
>>>> > You can build a release-candidate of the official docker image using
>>>> the following command:
>>>> >
>>>> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
>>>> >
>>>> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
>>>> > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
>>>> > --build-arg
>>>> SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
>>>> > -t solr-rc:9.0.0-2
>>>> >
>>>> > The vote will be open for at least 72 hours i.e. until 2022-04-02
>>>> 19:00 UTC.
>>>> >
>>>> > [ ] +1 approve
>>>> > [ ] +0 no opinion
>>>> > [ ] -1 disapprove (and reason why)
>>>> >
>>>> > Here is my +1
>>>> >
>>>> > SUCCESS! [0:53:16.741542]
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>>>> For additional commands, e-mail: dev-help@solr.apache.org
>>>>
>>>>
>>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Joel Bernstein <jo...@gmail.com>.
Here is the jira https://issues.apache.org/jira/browse/SOLR-16131.
My official vote for the RC:
-1
Joel Bernstein
http://joelsolr.blogspot.com/
On Thu, Mar 31, 2022 at 4:15 AM Jan Høydahl <ja...@cominvent.com> wrote:
> Joel,
>
> I could reproduce the error
> > Failed to load JDBC driver for
> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>
> And I see that JDBCStream uses a plain Class.forName(driverClassName); to
> fail early if the driver is wrong.
>
> The sql module is loaded:
> > o.a.s.c.NodeConfig Added module sql.
> libPath=...solr-9.0.0/solr/packaging/build/solr-9.0.0/modules/sql/lib with
> 9 libs
>
> I wonder if we need to use SolrResourceLoader to load the class in order
> to find classes in sharedLib. But JDBCStream is in solrj while
> ResourceLoader is in core... Hmm
>
> Please file an issue for this, and cast your formal vote.
>
> Jan
>
> 31. mar. 2022 kl. 02:57 skrev Joel Bernstein <jo...@gmail.com>:
>
> I tried adding the module in the solr.in.sh and it can't find the
> SQLHandler after starting up. So the sql module appears to not be working.
>
> "error":{
> "metadata":[
> "error-class","org.apache.solr.common.SolrException",
> "root-error-class","java.lang.ClassNotFoundException"],
> "msg":" Error loading class 'solr.SQLHandler'",
>
>
>
> Joel Bernstein
> http://joelsolr.blogspot.com/
>
>
> On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <jo...@gmail.com> wrote:
>
>> I tried loading the sql module but ran into this error when running a sql
>> query:
>>
>> Failed to load JDBC driver for
>> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>>
>> I loaded the module using system prop from startup command line:
>>
>> bin/solr start -c -Dsolr.modules=sql
>>
>>
>>
>>
>>
>> Joel Bernstein
>> http://joelsolr.blogspot.com/
>>
>>
>> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <ja...@cominvent.com>
>> wrote:
>>
>>> I found a minor glitch.
>>>
>>> In solr-exporter, the default config solr-exporter-config.xml still uses
>>> solr_metrics_core_replication_master as key for the
>>> REPLICATION./replication.isLeader metric.
>>>
>>> In 8.x the metrics was named REPLICATION./replication.isMaster and
>>> REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in
>>> 9.0.
>>> The prometheus key for follower is correctly renamed as
>>> solr_metrics_core_replication_follower already.
>>> I think the master -> leader should also have been done.
>>>
>>> However I cannot see it being referenced in Grafana dashboard or
>>> elsewhere, so probably not worth a respin, we can do it in 9.1.
>>>
>>> Jan
>>>
>>> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <ja...@cominvent.com>:
>>> >
>>> > Please vote for release candidate 2 for Solr 9.0.0
>>> >
>>> > The artifacts can be downloaded from:
>>> >
>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>> >
>>> > You can run the smoke tester directly with this command:
>>> >
>>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>>> >
>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>> >
>>> > You are encouraged to do an extra thorough test and manual inspection
>>> beyond
>>> > running the smoketester, since this is a major release.
>>> >
>>> > You can build a release-candidate of the official docker image using
>>> the following command:
>>> >
>>> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
>>> > RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>> && \
>>> > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
>>> > --build-arg
>>> SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
>>> > -t solr-rc:9.0.0-2
>>> >
>>> > The vote will be open for at least 72 hours i.e. until 2022-04-02
>>> 19:00 UTC.
>>> >
>>> > [ ] +1 approve
>>> > [ ] +0 no opinion
>>> > [ ] -1 disapprove (and reason why)
>>> >
>>> > Here is my +1
>>> >
>>> > SUCCESS! [0:53:16.741542]
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>>> For additional commands, e-mail: dev-help@solr.apache.org
>>>
>>>
>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Jan Høydahl <ja...@cominvent.com>.
Joel,
I could reproduce the error
> Failed to load JDBC driver for 'org.apache.solr.handler.sql.CalciteSolrDriver'
And I see that JDBCStream uses a plain Class.forName(driverClassName); to fail early if the driver is wrong.
The sql module is loaded:
> o.a.s.c.NodeConfig Added module sql. libPath=...solr-9.0.0/solr/packaging/build/solr-9.0.0/modules/sql/lib with 9 libs
I wonder if we need to use SolrResourceLoader to load the class in order to find classes in sharedLib. But JDBCStream is in solrj while ResourceLoader is in core... Hmm
Please file an issue for this, and cast your formal vote.
Jan
> 31. mar. 2022 kl. 02:57 skrev Joel Bernstein <jo...@gmail.com>:
>
> I tried adding the module in the solr.in.sh <http://solr.in.sh/> and it can't find the SQLHandler after starting up. So the sql module appears to not be working.
>
> "error":{
> "metadata":[
> "error-class","org.apache.solr.common.SolrException",
> "root-error-class","java.lang.ClassNotFoundException"],
> "msg":" Error loading class 'solr.SQLHandler'",
>
>
> Joel Bernstein
> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/>
>
>
> On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <joelsolr@gmail.com <ma...@gmail.com>> wrote:
> I tried loading the sql module but ran into this error when running a sql query:
>
> Failed to load JDBC driver for 'org.apache.solr.handler.sql.CalciteSolrDriver'
>
> I loaded the module using system prop from startup command line:
>
> bin/solr start -c -Dsolr.modules=sql
>
>
>
>
>
> Joel Bernstein
> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/>
>
>
> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <jan.asf@cominvent.com <ma...@cominvent.com>> wrote:
> I found a minor glitch.
>
> In solr-exporter, the default config solr-exporter-config.xml still uses solr_metrics_core_replication_master as key for the REPLICATION./replication.isLeader metric.
>
> In 8.x the metrics was named REPLICATION./replication.isMaster and REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in 9.0.
> The prometheus key for follower is correctly renamed as solr_metrics_core_replication_follower already.
> I think the master -> leader should also have been done.
>
> However I cannot see it being referenced in Grafana dashboard or elsewhere, so probably not worth a respin, we can do it in 9.1.
>
> Jan
>
> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <jan.asf@cominvent.com <ma...@cominvent.com>>:
> >
> > Please vote for release candidate 2 for Solr 9.0.0
> >
> > The artifacts can be downloaded from:
> > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2>
> >
> > You can run the smoke tester directly with this command:
> >
> > python3 -u dev-tools/scripts/smokeTestRelease.py \
> > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2>
> >
> > You are encouraged to do an extra thorough test and manual inspection beyond
> > running the smoketester, since this is a major release.
> >
> > You can build a release-candidate of the official docker image using the following command:
> >
> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr <https://dist.apache.org/repos/dist/dev/solr> && \
> > RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
> > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
> > --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
> > -t solr-rc:9.0.0-2
> >
> > The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00 UTC.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Here is my +1
> >
> > SUCCESS! [0:53:16.741542]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org <ma...@solr.apache.org>
> For additional commands, e-mail: dev-help@solr.apache.org <ma...@solr.apache.org>
>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Joel Bernstein <jo...@gmail.com>.
I tried adding the module in the solr.in.sh and it can't find the
SQLHandler after starting up. So the sql module appears to not be working.
"error":{
"metadata":[
"error-class","org.apache.solr.common.SolrException",
"root-error-class","java.lang.ClassNotFoundException"],
"msg":" Error loading class 'solr.SQLHandler'",
Joel Bernstein
http://joelsolr.blogspot.com/
On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <jo...@gmail.com> wrote:
> I tried loading the sql module but ran into this error when running a sql
> query:
>
> Failed to load JDBC driver for
> 'org.apache.solr.handler.sql.CalciteSolrDriver'
>
> I loaded the module using system prop from startup command line:
>
> bin/solr start -c -Dsolr.modules=sql
>
>
>
>
>
>
> Joel Bernstein
> http://joelsolr.blogspot.com/
>
>
> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <ja...@cominvent.com> wrote:
>
>> I found a minor glitch.
>>
>> In solr-exporter, the default config solr-exporter-config.xml still uses
>> solr_metrics_core_replication_master as key for the
>> REPLICATION./replication.isLeader metric.
>>
>> In 8.x the metrics was named REPLICATION./replication.isMaster and
>> REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in
>> 9.0.
>> The prometheus key for follower is correctly renamed as
>> solr_metrics_core_replication_follower already.
>> I think the master -> leader should also have been done.
>>
>> However I cannot see it being referenced in Grafana dashboard or
>> elsewhere, so probably not worth a respin, we can do it in 9.1.
>>
>> Jan
>>
>> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <ja...@cominvent.com>:
>> >
>> > Please vote for release candidate 2 for Solr 9.0.0
>> >
>> > The artifacts can be downloaded from:
>> >
>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>> >
>> > You can run the smoke tester directly with this command:
>> >
>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>> >
>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>> >
>> > You are encouraged to do an extra thorough test and manual inspection
>> beyond
>> > running the smoketester, since this is a major release.
>> >
>> > You can build a release-candidate of the official docker image using
>> the following command:
>> >
>> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
>> > RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>> && \
>> > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
>> > --build-arg
>> SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
>> > -t solr-rc:9.0.0-2
>> >
>> > The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00
>> UTC.
>> >
>> > [ ] +1 approve
>> > [ ] +0 no opinion
>> > [ ] -1 disapprove (and reason why)
>> >
>> > Here is my +1
>> >
>> > SUCCESS! [0:53:16.741542]
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>> For additional commands, e-mail: dev-help@solr.apache.org
>>
>>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Joel Bernstein <jo...@gmail.com>.
I tried loading the sql module but ran into this error when running a sql
query:
Failed to load JDBC driver for
'org.apache.solr.handler.sql.CalciteSolrDriver'
I loaded the module using system prop from startup command line:
bin/solr start -c -Dsolr.modules=sql
Joel Bernstein
http://joelsolr.blogspot.com/
On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <ja...@cominvent.com> wrote:
> I found a minor glitch.
>
> In solr-exporter, the default config solr-exporter-config.xml still uses
> solr_metrics_core_replication_master as key for the
> REPLICATION./replication.isLeader metric.
>
> In 8.x the metrics was named REPLICATION./replication.isMaster and
> REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in
> 9.0.
> The prometheus key for follower is correctly renamed as
> solr_metrics_core_replication_follower already.
> I think the master -> leader should also have been done.
>
> However I cannot see it being referenced in Grafana dashboard or
> elsewhere, so probably not worth a respin, we can do it in 9.1.
>
> Jan
>
> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <ja...@cominvent.com>:
> >
> > Please vote for release candidate 2 for Solr 9.0.0
> >
> > The artifacts can be downloaded from:
> >
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
> >
> > You can run the smoke tester directly with this command:
> >
> > python3 -u dev-tools/scripts/smokeTestRelease.py \
> >
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
> >
> > You are encouraged to do an extra thorough test and manual inspection
> beyond
> > running the smoketester, since this is a major release.
> >
> > You can build a release-candidate of the official docker image using the
> following command:
> >
> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
> > RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
> && \
> > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
> > --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz
> \
> > -t solr-rc:9.0.0-2
> >
> > The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00
> UTC.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Here is my +1
> >
> > SUCCESS! [0:53:16.741542]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Jan Høydahl <ja...@cominvent.com>.
I found a minor glitch.
In solr-exporter, the default config solr-exporter-config.xml still uses solr_metrics_core_replication_master as key for the REPLICATION./replication.isLeader metric.
In 8.x the metrics was named REPLICATION./replication.isMaster and REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in 9.0.
The prometheus key for follower is correctly renamed as solr_metrics_core_replication_follower already.
I think the master -> leader should also have been done.
However I cannot see it being referenced in Grafana dashboard or elsewhere, so probably not worth a respin, we can do it in 9.1.
Jan
> 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <ja...@cominvent.com>:
>
> Please vote for release candidate 2 for Solr 9.0.0
>
> The artifacts can be downloaded from:
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py \
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>
> You are encouraged to do an extra thorough test and manual inspection beyond
> running the smoketester, since this is a major release.
>
> You can build a release-candidate of the official docker image using the following command:
>
> DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
> docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
> --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
> -t solr-rc:9.0.0-2
>
> The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00 UTC.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Here is my +1
>
> SUCCESS! [0:53:16.741542]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Jan Høydahl <ja...@cominvent.com>.
Anshum, can you provide details on your setup (OS, JVM) as well as the exact test failure log? From your earlier mail it looked like your install used a class from $HOME/.m2/ which is not in security manager allow-list. Wonder if it is the same happening this time?
Jan
> 30. mar. 2022 kl. 23:11 skrev Anshum Gupta <an...@anshumgupta.net>:
>
> I've run into the same issue w/ failing tests (:solr:solrj:testAdminUI and solr:modules:hdfs:) due to the security manager. Is anyone else also seeing this?
>
> On Wed, Mar 30, 2022 at 11:53 AM Jan Høydahl <jan.asf@cominvent.com <ma...@cominvent.com>> wrote:
> Please vote for release candidate 2 for Solr 9.0.0
>
> The artifacts can be downloaded from:
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2>
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py \
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2>
>
> You are encouraged to do an extra thorough test and manual inspection beyond
> running the smoketester, since this is a major release.
>
> You can build a release-candidate of the official docker image using the following command:
>
> DIST_BASE=https://dist.apache.org/repos/dist/dev/solr <https://dist.apache.org/repos/dist/dev/solr> && \
> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \
> docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
> --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
> -t solr-rc:9.0.0-2
>
> The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00 UTC.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Here is my +1
>
> SUCCESS! [0:53:16.741542]
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org <ma...@solr.apache.org>
> For additional commands, e-mail: dev-help@solr.apache.org <ma...@solr.apache.org>
>
>
>
> --
> Anshum Gupta
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Joel Bernstein <jo...@gmail.com>.
+1
SUCCESS! [1:26:27.731406]
I also spent some time working with artifacts, creating collections,
loading data, querying, streaming expressions. All looked good.
Joel Bernstein
http://joelsolr.blogspot.com/
On Wed, Mar 30, 2022 at 6:47 PM Houston Putman <ho...@apache.org> wrote:
> +1 (binding)
>
> SUCCESS! [0:50:48.458378]
>
> I also tried building a custom image via the TGZ, and building the
> official image.
> Custom image built via:
>
> docker build --file /solr-9.0.0/docker/Dockerfile
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2/solr/solr-9.0.0.tgz -t
> solr-rc:9.0.0-2-local
>
>
> Unfortunately, it looks like we never actually delete the TGZ after
> untarring it in the official docker image, making it 200 MB bigger than the
> local/custom image. (uncompressed). I wouldn't say this is a release
> blocker, but something I will fix in the meantime and it will get into the
> next RC or the next release.
>
> I did the Solr Operator smoke test with the "official" docker image, and
> everything passed as well (query, metrics, backup and replica migration).
> The only issue I got to was that the 8.7.0 version of the prometheus
> exporter was incompatible with the 9.0.0 Solr Cloud. This is fine as long
> as we make sure it's documented. (it's because SolrJ is only compatible
> with 9.x for versions 8.10+, this is already documented)
> This is also not a veto, since we can patch the ref-guide after the
> release.
>
> I'll follow up with two PRs to fix these issues.
>
> - Houston Putman
>
> On Wed, Mar 30, 2022 at 5:11 PM Anshum Gupta <an...@anshumgupta.net>
> wrote:
>
>> I've run into the same issue w/ failing tests (:solr:solrj:testAdminUI
>> and solr:modules:hdfs:) due to the security manager. Is anyone else also
>> seeing this?
>>
>> On Wed, Mar 30, 2022 at 11:53 AM Jan Høydahl <ja...@cominvent.com>
>> wrote:
>>
>>> Please vote for release candidate 2 for Solr 9.0.0
>>>
>>> The artifacts can be downloaded from:
>>>
>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>
>>> You can run the smoke tester directly with this command:
>>>
>>> python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>
>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>>
>>> You are encouraged to do an extra thorough test and manual inspection
>>> beyond
>>> running the smoketester, since this is a major release.
>>>
>>> You can build a release-candidate of the official docker image using the
>>> following command:
>>>
>>> DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
>>> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>> && \
>>> docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
>>> --build-arg
>>> SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
>>> -t solr-rc:9.0.0-2
>>>
>>> The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00
>>> UTC.
>>>
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove (and reason why)
>>>
>>> Here is my +1
>>>
>>> SUCCESS! [0:53:16.741542]
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>>> For additional commands, e-mail: dev-help@solr.apache.org
>>>
>>>
>>
>> --
>> Anshum Gupta
>>
>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Houston Putman <ho...@apache.org>.
+1 (binding)
SUCCESS! [0:50:48.458378]
I also tried building a custom image via the TGZ, and building the official
image.
Custom image built via:
docker build --file /solr-9.0.0/docker/Dockerfile
https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2/solr/solr-9.0.0.tgz
-t
solr-rc:9.0.0-2-local
Unfortunately, it looks like we never actually delete the TGZ after
untarring it in the official docker image, making it 200 MB bigger than the
local/custom image. (uncompressed). I wouldn't say this is a release
blocker, but something I will fix in the meantime and it will get into the
next RC or the next release.
I did the Solr Operator smoke test with the "official" docker image, and
everything passed as well (query, metrics, backup and replica migration).
The only issue I got to was that the 8.7.0 version of the prometheus
exporter was incompatible with the 9.0.0 Solr Cloud. This is fine as long
as we make sure it's documented. (it's because SolrJ is only compatible
with 9.x for versions 8.10+, this is already documented)
This is also not a veto, since we can patch the ref-guide after the release.
I'll follow up with two PRs to fix these issues.
- Houston Putman
On Wed, Mar 30, 2022 at 5:11 PM Anshum Gupta <an...@anshumgupta.net> wrote:
> I've run into the same issue w/ failing tests (:solr:solrj:testAdminUI and
> solr:modules:hdfs:) due to the security manager. Is anyone else also seeing
> this?
>
> On Wed, Mar 30, 2022 at 11:53 AM Jan Høydahl <ja...@cominvent.com>
> wrote:
>
>> Please vote for release candidate 2 for Solr 9.0.0
>>
>> The artifacts can be downloaded from:
>>
>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>
>> You can run the smoke tester directly with this command:
>>
>> python3 -u dev-tools/scripts/smokeTestRelease.py \
>>
>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>>
>> You are encouraged to do an extra thorough test and manual inspection
>> beyond
>> running the smoketester, since this is a major release.
>>
>> You can build a release-candidate of the official docker image using the
>> following command:
>>
>> DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
>> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>> && \
>> docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
>> --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz
>> \
>> -t solr-rc:9.0.0-2
>>
>> The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00
>> UTC.
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and reason why)
>>
>> Here is my +1
>>
>> SUCCESS! [0:53:16.741542]
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>> For additional commands, e-mail: dev-help@solr.apache.org
>>
>>
>
> --
> Anshum Gupta
>
Re: [VOTE] Release Solr 9.0.0 RC2
Posted by Anshum Gupta <an...@anshumgupta.net>.
I've run into the same issue w/ failing tests (:solr:solrj:testAdminUI and
solr:modules:hdfs:) due to the security manager. Is anyone else also seeing
this?
On Wed, Mar 30, 2022 at 11:53 AM Jan Høydahl <ja...@cominvent.com> wrote:
> Please vote for release candidate 2 for Solr 9.0.0
>
> The artifacts can be downloaded from:
>
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py \
>
> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2
>
> You are encouraged to do an extra thorough test and manual inspection
> beyond
> running the smoketester, since this is a major release.
>
> You can build a release-candidate of the official docker image using the
> following command:
>
> DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \
> RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 &&
> \
> docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
> --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \
> -t solr-rc:9.0.0-2
>
> The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00
> UTC.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Here is my +1
>
> SUCCESS! [0:53:16.741542]
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
>
--
Anshum Gupta