[GitHub] [james-project] chibenwa commented on a change in pull request #933: JAMES-3733 Support multi EventBus when re-deliver events from the dea…

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #933:
URL: https://github.com/apache/james-project/pull/933#discussion_r834049607



##########
File path: server/container/guice/distributed/src/main/java/org/apache/james/modules/event/RabbitMQEventBusModule.java
##########
@@ -50,6 +50,10 @@ protected void configure() {
         bind(RabbitMQEventBus.class).in(Scopes.SINGLETON);
         bind(EventBus.class).to(RabbitMQEventBus.class);
 
+        Multibinder.newSetBinder(binder(), EventBus.class)
+            .addBinding()
+            .to(EventBus.class);

Review comment:
       No I prefer define the targeted binding here rather than the source one.

##########
File path: server/container/guice/mailbox/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java
##########
@@ -57,6 +57,10 @@ protected void configure() {
         bind(EventDelivery.class).to(InVmEventDelivery.class);
         bind(EventBus.class).to(InVMEventBus.class);
 
+        Multibinder.newSetBinder(binder(), EventBus.class)
+            .addBinding()
+            .to(EventBus.class);

Review comment:
       No I prefer define the targeted binding here rather than the source one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org