[GitHub] [kafka] jsancio commented on a diff in pull request #12750: MINOR: Inline "Running a Kafka broker in KRaft mode" in README.md

[GitBox <gi...@apache.org>]

jsancio commented on code in PR #12750:
URL: https://github.com/apache/kafka/pull/12750#discussion_r996023706


##########
README.md:
##########
@@ -83,15 +83,17 @@ fail due to code changes. You can just run:
  
     ./gradlew processMessages processTestMessages
 
+### Running a Kafka broker in KRaft mode
+
+    KAFKA_CLUSTER_ID="$(./bin/kafka-storage.sh random-uuid)"
+    ./bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c config/kraft/server.properties
+    ./bin/kafka-server-start.sh config/kraft/server.properties
+

Review Comment:
   Can we have a `###` heading with something like "Running a Kafka Broker" with 2 `####` heading, one for KRaft-mode and one for ZK-mode?
   
   The `### Running a Kafka Broker` should mention that only one subsection should be followed. In other words the Kafka cluster should have one KRaft-mode server or ZK-mode server but not both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org