svn commit: r755515 - /mina/trunk/integration-jmx/src/main/java/org/apache/mina/integration/jmx/ObjectMBean.java

[ap...@apache.org]

Author: apaliwal
Date: Wed Mar 18 09:02:54 2009
New Revision: 755515

URL: http://svn.apache.org/viewvc?rev=755515&view=rev
Log:
JIRA Issue: DIRMINA-676
Added check for attribute not found exception, to avoid null pointer, for unknown attributes
Submitted By: Ashish Paliwal (apaliwal.at.apache.org)

Modified:
    mina/trunk/integration-jmx/src/main/java/org/apache/mina/integration/jmx/ObjectMBean.java

Modified: mina/trunk/integration-jmx/src/main/java/org/apache/mina/integration/jmx/ObjectMBean.java
URL: http://svn.apache.org/viewvc/mina/trunk/integration-jmx/src/main/java/org/apache/mina/integration/jmx/ObjectMBean.java?rev=755515&r1=755514&r2=755515&view=diff
==============================================================================
--- mina/trunk/integration-jmx/src/main/java/org/apache/mina/integration/jmx/ObjectMBean.java (original)
+++ mina/trunk/integration-jmx/src/main/java/org/apache/mina/integration/jmx/ObjectMBean.java Wed Mar 18 09:02:54 2009
@@ -159,9 +159,16 @@
         } catch (Throwable e) {
             throwMBeanException(e);
         }
+
+        // Check if the attribute exist, if not throw an exception
+        PropertyDescriptor pdesc = propertyDescriptors.get(fqan);
+        if (pdesc == null) {
+            throwMBeanException(new IllegalArgumentException(
+                    "Unknown attribute: " + fqan));
+        }
         
         try {
-            PropertyDescriptor pdesc = propertyDescriptors.get(fqan);
+
             Object parent = getParent(fqan);
             boolean writable = isWritable(source.getClass(), pdesc);