You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/02/26 15:43:34 UTC

Re: Review Request 72017: SSL Socket: Added downgrade support.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72017/#review219664
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Jan. 16, 2020, 6:49 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72017/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2020, 6:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10073
>     https://issues.apache.org/jira/browse/MESOS-10073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds downgrade support, in the same fashion that the
> Libevent SSL socket does (and copies a good chunk of the code
> from there too).  To account for Windows not having `io::poll`,
> a slight hack is taken to check for readable bytes.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/ssl/openssl_socket.cpp 74f9fe2443efa37c0b6c7f77120b140f5ac0b53b 
> 
> 
> Diff: https://reviews.apache.org/r/72017/diff/1/
> 
> 
> Testing
> -------
> 
> make check (tests enabled with the previous review now pass)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>