You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/04 23:19:02 UTC

[GitHub] [airflow] SamWheating opened a new pull request #14086: fixes to dataproc operators and hook

SamWheating opened a new pull request #14086:
URL: https://github.com/apache/airflow/pull/14086


   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   Two quick fixes to Dataproc operators and hooks. 
   
   1) Add more templated fields to the DataprocClusterDeleteOperator
   
   as per https://github.com/apache/airflow/issues/13454. There were a few other fields which could easily be templated so I added them as well.
   
   2) Don't use the `global-dataproc.googleapis.com:443` URL when creating dataproc clients. 
   
   This was partially done in https://github.com/apache/airflow/pull/12907 but the other two client creation methods were not updated. Using the `global-dataproc` URL results in 404s when trying to create clusters in the `global` region. 
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jhtimmins commented on pull request #14086: Fixes to dataproc operators and hook

Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #14086:
URL: https://github.com/apache/airflow/pull/14086#issuecomment-774423662


   The code itself looks good, but it looks like you'll need to update the tests to handle the new client values. Right now it's causing a couple tests to fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #14086: Fixes to dataproc operators and hook

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14086:
URL: https://github.com/apache/airflow/pull/14086#issuecomment-773711713


   [The Workflow run](https://github.com/apache/airflow/actions/runs/538969804) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #14086: Fixes to dataproc operators and hook

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14086:
URL: https://github.com/apache/airflow/pull/14086


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #14086: Fixes to dataproc operators and hook

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14086:
URL: https://github.com/apache/airflow/pull/14086#issuecomment-773711713


   [The Workflow run](https://github.com/apache/airflow/actions/runs/538969804) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org