[GitHub] [trafficserver] maskit commented on a diff in pull request #10087: Fix quiche m4 macros.

["maskit (via GitHub)" <gi...@apache.org>]

maskit commented on code in PR #10087:
URL: https://github.com/apache/trafficserver/pull/10087#discussion_r1274092712


##########
m4/quiche.m4:
##########
@@ -58,7 +58,7 @@ if test "$has_quiche" != "0"; then
   quiche_have_libs=0
   if test "$quiche_base_dir" != "/usr"; then
     TS_ADDTO(CPPFLAGS, [-I${quiche_include}])
-    TS_ADDTO(LDFLAGS, [-L${quiche_ldflags} -rpath ${quiche_ldflags}])
+    TS_ADDTO(LDFLAGS, [-L${quiche_ldflags} -Wl,-rpath,${quiche_ldflags}])

Review Comment:
   Although this way of passing rpath looks more familiar, why do we need to do this where we have `TS_ADDTO_RPATH` below?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org