You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ewen Cheslack-Postava <me...@ewencp.org> on 2014/12/02 00:49:34 UTC
Review Request 28582: Patch for KAFKA-1642
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28582/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1642
https://issues.apache.org/jira/browse/KAFKA-1642
Repository: kafka
Description
-------
KAFKA-1642 Make nodes as connecting before making connect request so exceptions are handled properly.
KAFKA-1642 Update last time no nodes were available when updating metadata has to initiate a connection.
KAFKA-1642 Don't busy wait trying to send metadata to a node that is connected but has too many in flight requests.
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java 525b95e98010cd2053eacd8c321d079bcac2f910
Diff: https://reviews.apache.org/r/28582/diff/
Testing
-------
Thanks,
Ewen Cheslack-Postava
Re: Review Request 28582: Patch for KAFKA-1642
Posted by Ewen Cheslack-Postava <me...@ewencp.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28582/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 2:56 a.m.)
Review request for kafka.
Bugs: KAFKA-1642
https://issues.apache.org/jira/browse/KAFKA-1642
Repository: kafka
Description (updated)
-------
KAFKA-1642 Make nodes as connecting before making connect request so exceptions are handled properly.
KAFKA-1642 Update last time no nodes were available when updating metadata has to initiate a connection.
KAFKA-1642 Don't busy wait trying to send metadata to a node that is connected but has too many in flight requests.
Improve handling of fast-fail connection attempts in NetworkClient and add some comments explaining how each branch of maybeUpdateMetadata works.
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java 525b95e98010cd2053eacd8c321d079bcac2f910
Diff: https://reviews.apache.org/r/28582/diff/
Testing
-------
Thanks,
Ewen Cheslack-Postava