You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/07/13 00:37:08 UTC
[GitHub] [accumulo] keith-turner opened a new issue, #3605: Look into why the merge code was splitting
keith-turner opened a new issue, #3605:
URL: https://github.com/apache/accumulo/issues/3605
The tablet merge code was adding splits to the table at the merge boundaries and calling the tablet server to do the split. This code is there in the elasticity branch but does not function after changes like #3604. Need to determine why the merge code was doing this and if was tightly coupled to chop merges and would even be needed after the changes in #1327. If the split at merge boundry is still needed even with #1327, then will need to have the merge code call new split code in the manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on issue #3605: Look into why the merge code was splitting
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on issue #3605:
URL: https://github.com/apache/accumulo/issues/3605#issuecomment-1656046499
I looked into this and the split request is only done for when a range is deleted from a table and not during a merge. It's kind of interesting how things are designed as merging a range and deleting a range code is coupled together and the MergeInfo object defines the [Operation](https://github.com/apache/accumulo/blob/4ec6dd2054d6a588dfc5a9a5f139d32799c90e83/server/base/src/main/java/org/apache/accumulo/server/manager/state/MergeInfo.java#L36) type
Inside of the split request code you can see that if it's not a delete (so a merge) it just [returns](https://github.com/apache/accumulo/blob/4ec6dd2054d6a588dfc5a9a5f139d32799c90e83/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L567).
I didn't look into the deletes yet but based off on this I will also need to update #3640 to handle metadata updates for range deletion. If we can update the code to do proper fencing of the files then maybe we can avoid having to do splits and the Elasticity branch wouldn't need to worry about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on issue #3605: Look into why the merge code was splitting
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #3605:
URL: https://github.com/apache/accumulo/issues/3605#issuecomment-1633375279
There is a method in TabletGroupWatcher named sendSplitRequest() that would call the split RPC on tsever. This method is used by the merge code. #3604 made this method throw UnsupportedOperationException, which motivated opening this follow on issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on issue #3605: Look into why the merge code was splitting
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on issue #3605:
URL: https://github.com/apache/accumulo/issues/3605#issuecomment-1652405870
I can look into why the merge code is splitting later this week as I'm already in that code anyways with #1327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on issue #3605: Look into why the merge code was splitting
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #3605:
URL: https://github.com/apache/accumulo/issues/3605#issuecomment-1656054478
> If we can update the code to do proper fencing of the files then maybe we can avoid having to do splits and the Elasticity branch wouldn't need to worry about it.
That would be nice, would simplify the algorithm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on issue #3605: Look into why the merge code was splitting
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #3605:
URL: https://github.com/apache/accumulo/issues/3605#issuecomment-1728092877
Can probably close this issue after #3761 is merged into elasticity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner closed issue #3605: Look into why the merge code was splitting
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner closed issue #3605: Look into why the merge code was splitting
URL: https://github.com/apache/accumulo/issues/3605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org