[jira] [Commented] (HTRACE-28) htraced: add web UI directory

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260787#comment-14260787 ] 

stack commented on HTRACE-28:
-----------------------------

Does the resource need a package as in org.apache.htrace? Does the resource need to be tied to particular classes? (Don't know, just asking -- if tied to classes, sure, have it in a package otherwise, put at src/resource?)

84	    go run "$SCRIPT_DIR/src/org/apache/htrace/bundler/bundler.go" \
85	        --src="$SCRIPT_DIR/../web/" --dst="$SCRIPT_DIR/src/org/apache/htrace/resource/" \

The go stuff is building into the src dir (we also download go dependencies into src dir).  Better if src dir goes unviolated?  Download into target dir or build dir?  Maybe the above is go convention, if so, ignore my remark.

What we doing here? 

	// This is useful for serving HTML and Javascript files from a self-contained binary.

The index.html will be in the binary too?

Those are fat tabs in your go code.  That convention?  Looks 'strange' after our hadoop escapades.

What are dfiles and sfiles (src and dst?)

// Delete generated files that are in dfiles but not sfiles.

Above are nits to fix on commit and just questions for my own edification.  +1 Fix on commit.



> htraced: add web UI directory
> -----------------------------
>
>                 Key: HTRACE-28
>                 URL: https://issues.apache.org/jira/browse/HTRACE-28
>             Project: HTrace
>          Issue Type: Improvement
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-28.001.patch
>
>
> Add the web UI directory for htraced.  Bundle the index.html file and any other files in that directory into the htraced daemon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)