[GitHub] [spark] HyukjinKwon commented on issue #25423: [SPARK-28701][test-hadoop3.2][test-java11][k8s] adding java11 support for pull request builds

[GitBox <gi...@apache.org>]

HyukjinKwon commented on issue #25423: [SPARK-28701][test-hadoop3.2][test-java11][k8s] adding java11 support for pull request builds
URL: https://github.com/apache/spark/pull/25423#issuecomment-522318935
 
 
   @srowen and @shaneknapp, if the tests ^^^ fail,
   
   How about, for now, we go back to https://github.com/apache/spark/pull/25423/commits/f285b7094fbb6123f116e9ba7410408a43f8d256#diff-3c9f4fccf7d30ce2e8fa86db2ad1fdadR187?
   
   ```python
       # Test with Java 11
       if "test-java11" in ghprb_pull_title:
           os.environ["JAVA_HOME"] = "/usr/java/jdk-11.0.1"
           os.environ["PATH"] = "%s/bin:%s" % (os.environ["JAVA_HOME"], os.environ["PATH"])
   ```
   
   Because ..
   
    - this way is basically same as `hadoop-3.2` - so if anything should be fixed for this mechanism, we can fix it together in a separate PR if we should.
     - I think we couldn't conclude, yet:
       - if we want JDK 8 to build for both JDK 8 and 11, or ..
       - if we want JDK 11 (with `--release`) to build for both JDK 8 and 11.
   
   I am taking a look for [SPARK-28750](https://issues.apache.org/jira/browse/SPARK-28750) so maybe we can conclude the second point soon.
   
   Advantage of doing the suggested way is, we can at least build and run the tests with JDK 11 since the tests will pass now with #25443 without adding more changes in this PR.
   
   So, I was thinking: after this PR, we can conclude how we're going to handle JDK 8 or 11 to build, and make some more changes separately later.
     

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org